Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pra #4957

Closed
wants to merge 24 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
b7148d0
feat: Move publicise into publisher app (#4844)
steverydz Sep 9, 2024
8cacd7e
feat: Move settings into publisher app (#4847)
steverydz Sep 10, 2024
fbb281a
Wd 14634 metrics page (#4851)
ilayda-cp Sep 20, 2024
a69af94
Wd 15262 improve performance of metric page (#4863)
ilayda-cp Oct 3, 2024
f8dbf3f
chore: Move listing page into publisher app (#4865)
steverydz Oct 3, 2024
2d1670a
feat: add breadcrumb nav to the metrics page (#4871)
ilayda-cp Oct 8, 2024
175a239
feat: Create endpoints to get repo data and builds data (#4873)
steverydz Oct 8, 2024
46f36b5
feat: update badge sources (#4892)
ilayda-cp Oct 21, 2024
4453b7c
feat: Add builds section to publisher pages (#4890)
steverydz Oct 24, 2024
a7f35e7
feat: Move releases section into the publisher app (#4902)
steverydz Nov 18, 2024
a303422
fix: Fix publicise disabled notification (#4911)
steverydz Nov 20, 2024
97b72ac
fix: Fix issue with saving settings when navigating from listing (#4913)
steverydz Nov 21, 2024
47ded70
fix: Fix publicise view for private snaps (#4914)
steverydz Nov 21, 2024
655bc4c
Rebase
steverydz Nov 22, 2024
2c77db4
fix: Fix issues with tour styles (#4916)
steverydz Nov 25, 2024
e2a1395
fix: Fix code linting errors in publisher app (#4921)
steverydz Dec 4, 2024
e69125f
fix: Fix a11y errors in builds section (#4922)
steverydz Dec 5, 2024
d6aee20
fix: Fix publisher a11y errors in the publicise cards section (#4923)
steverydz Dec 5, 2024
e192b7a
fix: Fix publisher a11y errors in publicise badges section (#4924)
steverydz Dec 5, 2024
8ecf8eb
fix: Fix publisher a11y errors in publicise buttons section (#4925)
steverydz Dec 5, 2024
1d92a4b
fix: Fix publisher a11y errors in settings section (#4926)
steverydz Dec 5, 2024
ca89c9e
fix: Fix a11y errors in license search (#4928)
steverydz Dec 5, 2024
bc93343
fix: Fix a11y errors in search autocomplete (#4929)
steverydz Dec 5, 2024
74e7a1e
chore: Remove legacy publisher JS (#4930)
steverydz Dec 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Fix publisher a11y errors in the publicise cards section (#4923)
steverydz committed Dec 9, 2024
commit d6aee20fb0c793ad2a113c0d15810ba9d7f3a7a9
11 changes: 6 additions & 5 deletions static/js/publisher-pages/pages/Publicise/PubliciseCards.tsx
Original file line number Diff line number Diff line change
@@ -38,13 +38,13 @@ function PubliciseCards(): JSX.Element {
iframeQueryParameters,
).toString();

const htmlSnippet = `<iframe src="https://snapcraft.io/${snapId}/embedded?${iframeQueryString}"width="100%" height="990px" style="border: 1px solid #CCC; border-radius: 2px;"></iframe>`;
const htmlSnippet = `<iframe title="Publicise card" src="https://snapcraft.io/${snapId}/embedded?${iframeQueryString}"width="100%" height="990px" style="border: 1px solid #CCC; border-radius: 2px;"></iframe>`;

return (
<>
<Row>
<Col size={2}>
<label>Snap Store button:</label>
<p>Snap Store button:</p>
</Col>
<Col size={10}>
<p>
@@ -77,7 +77,7 @@ function PubliciseCards(): JSX.Element {
</Row>
<Row>
<Col size={2}>
<label>Options:</label>
<p>Options:</p>
</Col>
<Col size={10}>
<p>
@@ -119,11 +119,12 @@ function PubliciseCards(): JSX.Element {
</Row>
<Row>
<Col size={2}>
<label>Preview:</label>
<p>Preview:</p>
</Col>
<Col size={8}>
<p>
<iframe
title="Card preview"
src={`/${snapId}/embedded?${iframeQueryString}`}
width="100%"
style={{
@@ -137,7 +138,7 @@ function PubliciseCards(): JSX.Element {
</Row>
<Row>
<Col size={2}>
<label>HTML:</label>
<p>HTML:</p>
</Col>
<Col size={10}>
<div className="p-code-snippet">