Test pra #4957
Test pra #4957
Conversation
* feat: migrate metrics page to react
* feat: added downsampling and pagination
Simplify step 1 Simplify step 2 Simplify step 3 Simplify step 4 Simplify step 5
fix: Ignore metrics TS errors for now (#4933) fix: Fix checkbox values resetting in publisher settings form (#4937) fix: Fix primary website field clearing on revert (#4938) fix: Make sure Edit button on preview page closes current tab (#4939) fix: Fix deleting icon or banner not activating save button (#4940) fix: render selected language in HTML and markdown snippets (#4942) fix: remove extra whitespace in embeddable card (#4943) fix: Fix missing contact links in preview (#4944) fix: Fix preview card button being squashed (#4945) fix: Fix display of releases table (#4946) fix: Add loading state to single build page (#4947) fix: ensure markdown is rendered correctly (#4948) fix: build page showing stale data while fetching logs (#4949) fix: Fix missing banner in listing publisher page (#4950) fix: Fix form not resetting when making changes to images (#4952)
Demo
Jenkins 
demos.haus ![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| def get_settings_data(snap_name): | ||
| snap_details = publisher_api.get_snap_info(snap_name, flask.session) | ||
|
|
||
| if "whitelist_country_codes" in snap_details: |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist may be insensitive, use allowlist instead
| snap_details = publisher_api.get_snap_info(snap_name, flask.session) | ||
|
|
||
| if "whitelist_country_codes" in snap_details: | ||
| whitelist_country_codes = ( |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist may be insensitive, use allowlist instead
|
|
||
| if "whitelist_country_codes" in snap_details: | ||
| whitelist_country_codes = ( | ||
| snap_details["whitelist_country_codes"] |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist may be insensitive, use allowlist instead
| if "whitelist_country_codes" in snap_details: | ||
| whitelist_country_codes = ( | ||
| snap_details["whitelist_country_codes"] | ||
| if len(snap_details["whitelist_country_codes"]) > 0 |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist may be insensitive, use allowlist instead
| else [] | ||
| ) | ||
| else: | ||
| whitelist_country_codes = [] |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist may be insensitive, use allowlist instead
| visibility: string; | ||
| visibility_locked: boolean; | ||
| whitelist_countries: string[]; | ||
| whitelist_country_keys: string; |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist may be insensitive, use allowlist instead
| issues: { url: string }[]; | ||
| primary_website: string; | ||
| public_metrics_enabled: boolean; | ||
| public_metrics_blacklist: string[]; |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
| source: string[]; | ||
| }; | ||
| categories?: string[] | undefined; | ||
| public_metrics_blacklist?: string[]; |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
| > | ||
| tar.gz | ||
| </a> | ||
| <a href="https://raw.githubusercontent.com/snapcore/snap-store-badges/master/LICENSE.md"> |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] master may be insensitive, use primary, main instead
|
|
||
| function RepoSelector({ githubData, setAutoTriggerBuild }: Props) { | ||
| const rawLogsUrl = | ||
| "https://github.com/canonical/juju-dashboard-1/new/master?filename=snap%2Fsnapcraft.yaml&value=%0A%20%20%23%20After%20registering%20a%20name%20on%20build.snapcraft.io%2C%20commit%20an%20uncommented%20line%3A%0A%20%20%23%20name%3A%20steve-test-snap%0A%20%20version%3A%20%270.1%27%20%23%20just%20for%20humans%2C%20typically%20%271.2%2Bgit%27%20or%20%271.3.2%27%0A%20%20summary%3A%20Single-line%20elevator%20pitch%20for%20your%20amazing%20snap%20%23%2079%20char%20long%20summary%0A%20%20description%3A%20%7C%0A%20%20%20%20This%20is%20my-snap%27s%20description.%20You%20have%20a%20paragraph%20or%20two%20to%20tell%20the%0A%20%20%20%20most%20important%20story%20about%20your%20snap.%20Keep%20it%20under%20100%20words%20though%2C%0A%20%20%20%20we%20live%20in%20tweetspace%20and%20your%20description%20wants%20to%20look%20good%20in%20the%20snap%0A%20%20%20%20store.%0A%0A%20%20grade%3A%20devel%20%23%20must%20be%20%27stable%27%20to%20release%20into%20candidate%2Fstable%20channels%0A%20%20confinement%3A%20devmode%20%23%20use%20%27strict%27%20once%20you%20have%20the%20right%20plugs%20and%20slots%0A%0A%20%20parts%3A%0A%20%20%20%20my-part%3A%0A%20%20%20%20%20%20%23%20See%20%27snapcraft%20plugins%27%0A%20%20%20%20%20%20plugin%3A%20nil%0A%20%20"; |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] master may be insensitive, use primary, main instead
Done
How to QA
Testing
Issue / Card
Fixes #
Screenshots