Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model policies view #4346

Merged
merged 1 commit into from
Jul 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions static/js/brand-store/atoms/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { atom } from "recoil";
import type { Store, Model, Policy } from "../types/shared";
import type { Store, Model, Policy, SigningKey } from "../types/shared";

const brandStoresState = atom({
key: "brandStores",
Expand All @@ -24,15 +24,27 @@ const newModelState = atom({
},
});

const policiesState = atom({
key: "policies",
const policiesListState = atom({
key: "policiesList",
default: [] as Array<Policy>,
});

const policiesListFilterState = atom({
key: "policiesListFilter",
default: "" as string,
});

const signingKeysListState = atom({
key: "signingKeysList",
default: [] as Array<SigningKey>,
});

export {
brandStoresState,
modelsListState,
modelsListFilterState,
newModelState,
policiesState,
policiesListState,
policiesListFilterState,
signingKeysListState,
};
172 changes: 172 additions & 0 deletions static/js/brand-store/components/Model/CreatePolicyForm.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,172 @@
import React, { useState } from "react";
import { useRecoilState } from "recoil";
import { useParams, Link, useNavigate } from "react-router-dom";
import { useQuery, useMutation } from "react-query";
import { Button } from "@canonical/react-components";

import { signingKeysListState } from "../../atoms";

import type { Query } from "../../types/shared";

type Props = {
setShowNotification: Function;
setShowErrorNotification: Function;
refetchPolicies: Function;
};

function CreatePolicyForm({
setShowNotification,
setShowErrorNotification,
refetchPolicies,
}: Props) {
const getSigningKeys = async () => {
const response = await fetch(`/admin/store/${id}/signing-keys`);

if (!response.ok) {
throw new Error("There was a problem fetching signing keys");
}

const signingKeysData = await response.json();

if (!signingKeysData.success) {
throw new Error(signingKeysData.message);
}

setSigningKeys(signingKeysData.data);
};

const { id, model_id } = useParams();
const navigate = useNavigate();
const { isLoading, isError, error }: Query = useQuery(
"signingKeys",
getSigningKeys
);
const [signingKeys, setSigningKeys] = useRecoilState(signingKeysListState);
const [selectedSigningKey, setSelectedSigningKey] = useState("");

const handleError = () => {
setShowErrorNotification(true);
navigate(`/admin/${id}/models/${model_id}/policies`);
setSelectedSigningKey("");
setTimeout(() => {
setShowErrorNotification(false);
}, 5000);
};

const mutation = useMutation({
mutationFn: (policySigningKey: string) => {
const formData = new FormData();

formData.set("csrf_token", window.CSRF_TOKEN);
formData.set("signing_key", policySigningKey);

navigate(`/admin/${id}/models/${model_id}/policies`);

return fetch(`/admin/store/${id}/models/${model_id}/policies`, {
method: "POST",
body: formData,
});
},
onSuccess: async (response) => {
if (!response.ok) {
handleError();
throw new Error(`${response.status} ${response.statusText}`);
}

const policiesData = await response.json();

if (!policiesData.success) {
throw new Error(policiesData.message);
}

setShowNotification(true);
setSelectedSigningKey("");
refetchPolicies();
navigate(`/admin/${id}/models/${model_id}/policies`);
setTimeout(() => {
setShowNotification(false);
}, 5000);
},
onError: () => {
handleError();
throw new Error("Unable to create a new policy");
},
});

return (
<form
onSubmit={(event) => {
event.preventDefault();
mutation.mutate(selectedSigningKey);
}}
style={{ height: "100%" }}
>
<div className="p-panel is-flex-column">
<div className="p-panel__header">
<h4 className="p-panel__title">Create new policy</h4>
</div>
<div className="p-panel__content">
<div className="u-fixed-width">
{isLoading && <p>Fetching signing keys...</p>}
{isError && error && <p>Error: {error.message}</p>}

<label htmlFor="signing-key">Signing key</label>
<select
name="signing-key"
id="signing-key"
required
disabled={signingKeys.length < 1}
value={selectedSigningKey}
onChange={(event) => {
setSelectedSigningKey(event.target.value);
}}
>
<option value="">Select a signing key</option>
{signingKeys.map((signingKey) => (
<option
key={signingKey.fingerprint}
value={signingKey["sha3-384"]}
>
{signingKey.name}
</option>
))}
</select>

{signingKeys.length < 1 && (
<p className="p-form-help-text">
No signing keys available, please{" "}
<Link to={`/admin/${id}/models/signing-keys/create`}>
create one
</Link>{" "}
first.
</p>
)}
</div>
</div>
<hr />
<div className="p-panel__footer u-align--right">
<div className="u-fixed-width">
<Button
className="u-no-margin--bottom"
onClick={() => {
navigate(`/admin/${id}/models/${model_id}/policies`);
}}
>
Cancel
</Button>
<Button
type="submit"
appearance="positive"
className="u-no-margin--bottom u-no-margin--right"
disabled={!selectedSigningKey}
>
Add policy
</Button>
</div>
</div>
</div>
</form>
);
}

export default CreatePolicyForm;
14 changes: 13 additions & 1 deletion static/js/brand-store/components/Model/Policies.test.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React from "react";
import { BrowserRouter } from "react-router-dom";
import { RecoilRoot } from "recoil";
import { QueryClient, QueryClientProvider } from "react-query";
import { render, screen } from "@testing-library/react";
import userEvent from "@testing-library/user-event";

Expand All @@ -17,11 +18,22 @@ jest.mock("react-router-dom", () => {
};
});

const queryClient = new QueryClient({
defaultOptions: {
queries: {
refetchOnWindowFocus: false,
refetchOnReconnect: false,
},
},
});

function renderComponent() {
return render(
<RecoilRoot>
<BrowserRouter>
<Policies />
<QueryClientProvider client={queryClient}>
<Policies />
</QueryClientProvider>
</BrowserRouter>
</RecoilRoot>
);
Expand Down
Loading