Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model policies view #4346

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Add model policies view #4346

merged 1 commit into from
Jul 20, 2023

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Jul 20, 2023

Done

Built the policies view

How to QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-4738
Fixes https://warthogs.atlassian.net/browse/WD-4740

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4346.demos.haus

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #4346 (9701c86) into main (7682768) will not change coverage.
The diff coverage is n/a.

❗ Current head 9701c86 differs from pull request most recent head ea8865b. Consider uploading reports for the commit ea8865b to get more accurate results

@@           Coverage Diff           @@
##             main    #4346   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files          95       95           
  Lines        6814     6814           
=======================================
  Hits         5850     5850           
  Misses        964      964           
Flag Coverage Δ
python 85.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Lukewh
Copy link
Contributor

Lukewh commented Jul 20, 2023

If you go to a different model and policy list, the old policy information is still there:
ghost-policies

Maybe clear the data on the equivalent of an "unmount"?

Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@steverydz steverydz merged commit dd9d187 into canonical:main Jul 20, 2023
8 checks passed
@steverydz steverydz deleted the policies-view branch July 20, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants