-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parallel backup tests #355
Conversation
If backup tests are run in parallel, they will upload to the same path and cause 1+ of the tests to fail Use a UUID in the path to avoid parallel backup tests from affecting each other Parallel backup tests can happen for testing multiple Juju versions or if 2 PRs (or a PR & release) run at the same time
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
=======================================
Coverage 65.43% 65.43%
=======================================
Files 17 17
Lines 3127 3127
Branches 415 415
=======================================
Hits 2046 2046
Misses 950 950
Partials 131 131 ☔ View full report in Codecov by Sentry. |
15f1448
to
2a98e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look sane!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
If backup tests are run in parallel, they will upload to the same path and cause 1+ of the tests to fail
Use a UUID in the path to avoid parallel backup tests from affecting each other
Parallel backup tests can happen for testing multiple Juju versions or if 2 PRs (or a PR & release) run at the same time