Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel backup tests #355

Merged
merged 9 commits into from
Nov 28, 2023
Merged

Fix parallel backup tests #355

merged 9 commits into from
Nov 28, 2023

Conversation

carlcsaposs-canonical
Copy link
Contributor

If backup tests are run in parallel, they will upload to the same path and cause 1+ of the tests to fail

Use a UUID in the path to avoid parallel backup tests from affecting each other

Parallel backup tests can happen for testing multiple Juju versions or if 2 PRs (or a PR & release) run at the same time

If backup tests are run in parallel, they will upload to the same path and cause 1+ of the tests to fail

Use a UUID in the path to avoid parallel backup tests from affecting each other

Parallel backup tests can happen for testing multiple Juju versions or if 2 PRs (or a PR & release) run at the same time
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (04de94f) 65.43% compared to head (54c4f19) 65.43%.

Files Patch % Lines
lib/charms/mysql/v0/s3_helpers.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   65.43%   65.43%           
=======================================
  Files          17       17           
  Lines        3127     3127           
  Branches      415      415           
=======================================
  Hits         2046     2046           
  Misses        950      950           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sane!

@deusebio deusebio self-requested a review November 17, 2023 15:40
deusebio
deusebio previously approved these changes Nov 17, 2023
Copy link
Contributor Author

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@carlcsaposs-canonical carlcsaposs-canonical merged commit 8afdce6 into main Nov 28, 2023
30 of 31 checks passed
@carlcsaposs-canonical carlcsaposs-canonical deleted the backup-test branch November 28, 2023 12:19
carlcsaposs-canonical added a commit to canonical/mysql-k8s-operator that referenced this pull request Feb 6, 2024
carlcsaposs-canonical added a commit to canonical/mysql-k8s-operator that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants