Use reusable integration test workflow #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
carlcsaposs-canonical
force-pushed
the
reusable-integration-workflow
branch
from
69f7e35 to
be2678c
Compare
|
needs #355 |
carlcsaposs-canonical
force-pushed
the
reusable-integration-workflow
branch
2 times, most recently
from
04b755c to
d4dc431
Compare
carlcsaposs-canonical
force-pushed
the
reusable-integration-workflow
branch
from
6e9dd85 to
5899116
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
=======================================
Coverage ? 65.43%
=======================================
Files ? 17
Lines ? 3127
Branches ? 415
=======================================
Hits ? 2046
Misses ? 950
Partials ? 131 ☔ View full report in Codecov by Sentry. |
carlcsaposs-canonical
requested review from
taurus-forever and
shayancanonical
taurus-forever
approved these changes
Nov 28, 2023
@juditnovak can probably explain it better than I can tl;dr a quick solution to get unit tests with & without secrets working, I think |
Use pytest.mark.skipif to skip at collection time instead of runtime
Instead of juju CLI version So that version is accessible during test collection without installing juju
This reverts commit fef462e.
carlcsaposs-canonical
force-pushed
the
reusable-integration-workflow
branch
from
d754f48 to
133c6a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.