DPE-2758 better messaging when no bucket #350
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
- Coverage 65.91% 65.78% -0.14%
==========================================
Files 17 17
Lines 3122 3130 +8
Branches 411 412 +1
==========================================
+ Hits 2058 2059 +1
- Misses 936 943 +7
Partials 128 128 ☔ View full report in Codecov by Sentry. |
dpe-2758-better-messaging-when-no-bucket # Conflicts: # .github/workflows/ci.yaml # lib/charms/data_platform_libs/v0/data_interfaces.py # lib/charms/mysql/v0/s3_helpers.py # tests/integration/test_backups.py # tox.ini
paulomach
dismissed stale reviews from taurus-forever and shayancanonical
via
12e9f38
since reusable workflow cannot be nested
|
Blocked by: canonical/data-platform-workflows#111 |
dpe-2758-better-messaging-when-no-bucket # Conflicts: # .github/workflows/ci.yaml
Unblocked |
tox.ini
Outdated
| @@ -80,6 +80,7 @@ set_env = | |||
| {[testenv]set_env} | |||
| # Workaround for https://github.com/python-poetry/poetry/issues/6958 | |||
| POETRY_INSTALLER_PARALLEL = false | |||
| LIBJUJU_VERSION_SPECIFIER = {env:LIBJUJU_VERSION_SPECIFIER:3.2.2} | |||
There was a problem hiding this comment.
why was this added?
There was a problem hiding this comment.
it shouldn't be in tox.ini
if removing it breaks something, please lmk
There was a problem hiding this comment.
iirc, was related to unit-test - anyway, it didn't broke anything
paulomach
deleted the
feature/dpe-2758-better-messaging-when-no-bucket
branch
Lib sync/port from k8s PR#332