Skip database creation for mysqlrouter extra user role
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
shayancanonical
carlcsaposs-canonical
added a commit
to canonical/mysql-operator
that referenced
this pull request
May 15, 2023
This was referenced May 15, 2023
delgod
approved these changes
May 15, 2023
shayancanonical
approved these changes
May 15, 2023
| @@ -90,7 +90,7 @@ def wait_until_mysql_connection(self) -> None: | |||
|
|
|||
| # Increment this PATCH version before using `charmcraft publish-lib` or reset | |||
| # to 0 if you are raising the major API version | |||
| LIBPATCH = 26 | |||
| LIBPATCH = 28 | |||
There was a problem hiding this comment.
i believe this should be libpatch 27 (on the vm charm - which where the charm lib gets published)
There was a problem hiding this comment.
taurus-forever
approved these changes
May 16, 2023
Comment on lines
+176
to
+178
| # TODO: | ||
| # add setup of tls, tls_ca and status | ||
| # add extra roles parsing from relation data |
There was a problem hiding this comment.
paulomach
approved these changes
May 16, 2023
carlcsaposs-canonical
added a commit
to canonical/mysql-operator
that referenced
this pull request
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.