Code

[snapshots] Unit tests#3256

Code

Closed

ricab wants to merge 139 commits intomaincanonical/multipass:mainfrom snapshots-unit-testscanonical/multipass:snapshots-unit-testsCopy head branch name to clipboard

+2,310-27

Commits

Commits on Jan 9, 2024

• [tests] Add file to test base snapshots

  Show description for f0fd629
  ricab

  committed
  f0fd629

• [tests] Test BaseSnapshot adopts given name

  ricab

  committed
  a25bc2a

• [tests] Test a couple other snapshot properties

  ricab

  committed
  4d49b4f

• [tests] Test that BaseSnapshot rejects empty name

  ricab

  committed
  180ee91

• [tests] Check that snapshots adopt given specs

  ricab

  committed
  81385ee

• [tests] Check snapshots index

  ricab

  committed
  5502ceb

• [tests] Check parent properties

  ricab

  committed
  abe717c

• [tests] Check snapshot timestamp

  ricab

  committed
  ced651a

• [tests] Check required state for snapshots

  ricab

  committed
  089e58b

• [tests] Check invalid number of cores in snapshot

  ricab

  committed
  993355e

• [tests] Verify invalid memory and disk in snapshot

  ricab

  committed
  9059a35

• [tests] Reorganize includes slightly

  ricab

  committed
  47d8312

• [tests] Check snapshot reconstruction from JSON

  ricab

  committed
  6bb202e

• [tests] Fix dangling temporary path in MockVM

  ricab

  committed
  84e2bfa

• [tests] Check snapshot name from JSON

  ricab

  committed
  5bca2e1

• [tests] Check snapshot comment from JSON

  ricab

  committed
  d29b24d

• [tests] Use camelCase names in base snapshot tests

  ricab

  committed
  3c5b0bd

• [tests] Check snapshot parent from JSON

  ricab

  committed
  ca9f600

• [tests] Remove no-op moves

  Show description for fa811d3
  ricab

  committed
  fa811d3

• [tests] Add a few missing consts

  ricab

  committed
  7508682

• [tests] Check snapshot index from JSON

  ricab

  committed
  388121d

• [tests] Check snapshot timestamp from JSON

  ricab

  committed
  2603808

• [tests] Check snapshot cores from JSON

  ricab

  committed
  3dc41ab

• [tests] Check snapshot mem from JSON

  ricab

  committed
  8ddf57c

• [tests] Check snapshot disk from JSON

  ricab

  committed
  0bcd54f

• [tests] Check snapshot state from JSON

  ricab

  committed
  bd1c1f8

• [tests] Check snapshot metadata from JSON

  ricab

  committed
  e6cf46b

• [tests] Check snapshot mounts from JSON

  ricab

  committed
  f3e5b3d

• [snapshot] Fix assert when loading from disk

  Show description for ca85ff8
  ricab

  committed
  ca85ff8

• [tests] Check refused non-positive snapshot index

  ricab

  committed
  52993d0

• [tests] Check refused snapshot index over max

  ricab

  committed
  8b3f823

• [tests] Check snapshot persistence on edition

  ricab

  committed
  0b1c7fb

• [tests] Check snapshot setters

  ricab

  committed
  44cb34b

• [tests] Check capture persists snapshots

  ricab

  committed
  a3aa61c

• [tests] Check operations that delegate to impl

  ricab

  committed
  bedbadb

• [tests] Verify that erase deletes snapshot file

  ricab

  committed
  48b6ccb

• [tests] Check erase throws if unable to move file

  ricab

  committed
  bbd86a7

• [tests] Check rollback on failure to erase

  ricab

  committed
  b5b3c60

• [tests] Cover mounts in JSON-based snapshot tests

  ricab

  committed
  1682f42

• [tests] Check handling of inability to open file

  ricab

  committed
  5d7356a

• [tests] Test snapshot handling of bad JSON

  ricab

  committed
  f5e9414

• [snapshot] Fix wrong order in error message

  ricab

  committed
  c5a12d8

• [tests] Check handling of missing snapshot parent

  ricab

  committed
  c73385d

• [tests] Refactor test-snapshot file path

  ricab

  committed
  e893695

• [tests] Name file-path symbols consistently

  ricab

  committed
  eef6012

• [tests] Silence benign mock warnings

  ricab

  committed
  ad0a29f

• [tests] Add macros to delegate mock calls on base

  ricab

  committed
  34d13fa

• [tests] Implement MockBaseVirtualMachine

  ricab

  committed
  ea37faa

• [tests] Implement MockSnapshot

  ricab

  committed
  307a348

• [tests] Check that BaseVM takes/deletes snapshots

  ricab

  committed
  489c227

• [tests] Check that BaseVM counts current snapshots

  ricab

  committed
  17859ce

• [tests] Check that BaseVM tracks snapshot totals

  ricab

  committed
  efecaee

• [tests] Move BaseVM-snapshot tests to common suite

  ricab

  committed
  972a02f

• [tests] Check that BaseVM provides a snapshot view

  ricab

  committed
  475fe1c

• [tests] Remove repeated method mocking

  ricab

  committed
  4af7df9

• [tests] Mock missing const method overloads

  ricab

  committed
  16f4ea0

• [tests] Check BaseVM provides snapshot by name

  ricab

  committed
  386eb49

• [tests] Use nice snapshot mocks in BaseVM tests

  Show description for f32a2b2
  ricab

  committed
  f32a2b2

• [tests] Check BaseVM provides snapshot by index

  ricab

  committed
  43e2f27

• [tests] Fix mock method signature

  ricab

  committed
  51bea06

• [tests] Verify handling of missing snapshot index

  ricab

  committed
  73fbae5

• [tests] Refactor mocking for indexed snapshotting

  ricab

  committed
  6ae9773

• [tests] Verify handling of missing snapshot names

  ricab

  committed
  12cbd6f

• [tests] Slight renaming

  ricab

  committed
  27c7db9

• [tests] Verify repeated snapshot names are refused

  ricab

  committed
  37d3a42

• [tests] Verify snapshot deletion updates parents

  ricab

  committed
  fb5fcf2

• [tests] Avoid unnecessary casts

  Show description for f743a6d
  ricab

  committed
  f743a6d

• [tests] Avoid repeated calls

  ricab

  committed
  45ce49c

• [tests] Check that VM can get snapshots' children

  ricab

  committed
  eeb6b06

• [tests] Move "snapshot album" to test-case class

  ricab

  committed
  58f5a12

• [tests] Check renaming of snapshots by VM

  ricab

  committed
  df524da

• [tests] Check deletion of missing snapshot throws

  ricab

  committed
  7c69061

• [tests] Confirm logging of head snapshot

  ricab

  committed
  2095fbb

• [tests] Check that BaseVM restores snapshots

  ricab

  committed
  b23321a

• [tests] Check restored snapshot used as parent

  ricab

  committed
  8d4169a

• [tests] Fix dangling reference in stub VM

  ricab

  committed
  bd3a917

• [tests] Take unique_ptrs by value in stub VMs

  ricab

  committed
  b1bbb34

• [tests] Fix using mp-namespace shortcut in header

  ricab

  committed
  b3e735c

• [tests] Check BaseVM refuses to take snapshot

  Show description for f3f9f79
  ricab

  committed
  f3f9f79

• [vm] Use smallcase "snapshots" feature name

  Show description for 55cba85
  ricab

  committed
  55cba85

• [tests] Fix a couple of test names

  ricab

  committed
  7be366c

• [tests] Check generated snapshot names

  ricab

  committed
  7324ceb

• [tests] Check loading of snapshot-count

  ricab

  committed
  8995999

• [tests] Verify loading of padded counts

  ricab

  committed
  d51b2ef

• [tests] Use a single helper to mock snapshotting

  ricab

  committed
  2638588

• [tests] Extract verification of test params

  ricab

  committed
  d08698c

• [tests] Verify loading of head index

  ricab

  committed
  40b1972

• [tests] Check loading of snapshots by VM

  ricab

  committed
  f21fd9b

• [tests] Check missing generic-snapshot-info files

  ricab

  committed
  1708cf9

• [tests] Fix platform-dependent regex

  ricab

  committed
  bceaeb8

• [tests] Check handling of repeated snapshot names

  Show description for d92cd2c
  ricab

  committed
  d92cd2c

• [test] Check parent rollback on erase failure

  ricab

  committed
  8b76be7

• [tests] Check head rollback on deletion

  ricab

  committed
  2f8464f

• [tests] Check null head after capture failure

  ricab

  committed
  dd0cb9f

• [tests] Check rollback to previous head on failure

  ricab

  committed
  53dca77

• [tests] Check handling of rename failure

  ricab

  committed
  1b100d5

• [tests] Refactor platform-dependent regex elements

  ricab

  committed
  d77e0af

• [tests] Check persistence of generic snapshot info

  ricab

  committed
  4081c0f

• [tests] Fix include order

  ricab

  committed
  5344418

• [tests] Check new info files removed on failure

  Show description for 991fbd6
  ricab

  committed
  991fbd6

• [tests] Factor out a couple of constants

  ricab

  committed
  17af3e3

• [tests] Reorder test-case class contents slightly

  ricab

  committed
  c51882f

• [tests] Factor out a couple common vars in tests

  ricab

  committed
  7fd4c84

• [tests] Further refactor common snapshot file vars

  ricab

  committed
  bdbdc86

• [tests] Check rollback of existing info files

  Show description for 23313a3
  ricab

  committed
  23313a3

• [tests] Check head persisted on restore

  ricab

  committed
  c050833

• [tests] Refactor derivation of regex matcher

  ricab

  committed
  acb8fcb

• [tests] Refactor platform dependent constants

  ricab

  committed
  99a1e07

• [tests] Fix gmock warning

  ricab

  committed
  c3b6d13

• [tests] Test rollback of failed snapshot restore

  ricab

  committed
  97a8e5b

• [tests] Add file to test QemuSnapshot

  ricab

  committed
  e8d1364

• [tests] Add a PublicQemuSnapshot class for testing

  Show description for 8f19a06
  ricab

  committed
  8f19a06

• [tests] Extract MockSnapshot

  Show description for afa6282
  ricab

  committed
  afa6282

• [tests] Check init of base fields in QemuSnapshot

  ricab

  committed
  18c6122

• [tests] Check init of QemuSnapshot from JSON

  ricab

  committed
  4328bbd

Commits on Jan 10, 2024

• [tests] Extract vm specs for reuse

  ricab

  committed
  3fa389b

• [tests] Check capture of QEMU snapshots

  ricab

  committed
  e54b44c

• [tests] Refactor bits for reuse

  ricab

  committed
  657d98b

• [tests] Check QemuSnapshot capture throws

  Show description for 3a86969
  ricab

  committed
  3a86969

• [tests] Refactor common test components

  ricab

  committed
  99b6ff6

• [snapshot] Be robust to missing file on erase

  Show description for be5fe2e
  ricab

  committed
  be5fe2e

• [tests] Check erasure of QEMU snapshots

  ricab

  committed
  1dbdeae

• [tests] Check erase on missing QEMU snapshot

  ricab

  committed
  738344f

• [tests] Check applying QEMU snapshots

  ricab

  committed
  d31af84

• [tests] Check rollback on failure to apply

  ricab

  committed
  5e84c28

Commits on Jan 12, 2024

• [tests] Check throw on unsupported snapshots

  ricab

  committed
  1712a0e

• [tests] Improve test for trim_end utility

  ricab

  committed
  cb3f61d

• [test] Check trim_begin utility

  ricab

  committed
  31056e6

• [test] Check trim utility

  ricab

  committed
  4612ec9

• [tests] Refactor sample string out of trim tests

  ricab

  committed
  0a790c4

Commits on Jan 15, 2024

• [tests] Check creation of QEMU-specific snapshots

  ricab

  committed
  7aab0c6

• [tests] Use a mock vm to test QEMU snapshots

  ricab

  committed
  32c063f

• [tests] Snapshot creation from file by QEMU VM

  ricab

  committed
  9020fa2

• [tests] Compare shared_ptr directly where possible

  ricab

  committed
  fe4f7f1

• [tests] Verify support for snapshots in QEMU

  ricab

  committed
  1cdd044

• [tests] Check writeJson creates parent directory

  ricab

  committed
  1665ae4

• [tests] Check handling of failure to create dir

  Show description for 7ec8b45
  ricab

  committed
  7ec8b45

• [tests] Check full sequence to write JSON

  ricab

  committed
  0f5ff28

• [tests] Check remaining failure cases of writeJson

  ricab

  committed
  f6bfb48