[snapshots] Unit tests #3256
Closed
[snapshots] Unit tests #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3256 +/- ##
==========================================
+ Coverage 84.06% 87.71% +3.65%
==========================================
Files 251 251
Lines 13792 13801 +9
==========================================
+ Hits 11594 12106 +512
+ Misses 2198 1695 -503 ☔ View full report in Codecov by Sentry. |
ricab
force-pushed
the
snapshots-unit-tests
branch
3 times, most recently
from
a84026f to
c317e6a
Compare
ricab
force-pushed
the
snapshots-unit-tests
branch
from
c317e6a to
cd543c8
Compare
ricab
force-pushed
the
snapshots
branch
2 times, most recently
from
ef4a85e to
8b3c7a6
Compare
ricab
force-pushed
the
snapshots-unit-tests
branch
2 times, most recently
from
44f9682 to
e79eaef
Compare
ricab
force-pushed
the
snapshots-unit-tests
branch
3 times, most recently
from
adadffd to
dc5a04b
Compare
ricab
force-pushed
the
snapshots-unit-tests
branch
3 times, most recently
from
873e8d6 to
fa2bf2e
Compare
ricab
force-pushed
the
snapshots-unit-tests
branch
from
f583acf to
8d6b26e
Compare
ricab
force-pushed
the
snapshots-unit-tests
branch
4 times, most recently
from
9296d1d to
909258f
Compare
ricab
force-pushed
the
snapshots-unit-tests
branch
5 times, most recently
from
6310719 to
6dd30d2
Compare
Add a file to test BaseSnapshot, with basic structure and a placeholder test.
Verify that QemuSnapshot capture throws on repeated snapshot tag.
Avoids failing to erase a snapshot because its JSON file is not available.
Check handling of failure to create parent directory in `JsonUtils::writeJson`
|
Oh, GH doesn't let me reopen 🤔 |
|
Hey @ricab! In order to be able to reopen this PR, the |
|
Hmm I see, thanks! Well I have since moved on from that so I guess I'll live with the replacement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.