Add IPv6 unittests for cluster setup #698
Conversation
| @@ -81,7 +81,7 @@ func kubelet(snap snap.Snap, hostname string, nodeIP net.IP, clusterDNS string, | |||
| args["--cluster-domain"] = clusterDomain | |||
| } | |||
| if nodeIP != nil && !nodeIP.IsLoopback() { | |||
| args["--node-ip"] = utils.ToIPString(nodeIP) | |||
| args["--node-ip"] = nodeIP.String() | |||
There was a problem hiding this comment.
drive-by fix: brackets around the IPv6 are only required/accepted if combined with a port.
There was a problem hiding this comment.
Maybe we need to document this somewhere. I personally totally forgot about out brackets convention.
There was a problem hiding this comment.
This is not our convention but the actual IP standard.
| key string | ||
| expectedVal string | ||
| }{ | ||
| {key: "--advertise-address", expectedVal: "2001:db8::"}, |
There was a problem hiding this comment.
nit: Maybe we can extract these IP strings.
There was a problem hiding this comment.
this test validates that the --advertise-address flag is configured with the IP string that we expect. I don't think it makes sense to have this as an IP object just to stringify it later in the test.
Or do I misunderstand your comment?
There was a problem hiding this comment.
No no I mean that we could have variables for these IPs that we pass to both setup.KubeAPIServer() and expectedVal. It's not really important, ignore this if you don't feel like it.
| @@ -81,7 +81,7 @@ func kubelet(snap snap.Snap, hostname string, nodeIP net.IP, clusterDNS string, | |||
| args["--cluster-domain"] = clusterDomain | |||
| } | |||
| if nodeIP != nil && !nodeIP.IsLoopback() { | |||
| args["--node-ip"] = utils.ToIPString(nodeIP) | |||
| args["--node-ip"] = nodeIP.String() | |||
There was a problem hiding this comment.
Maybe we need to document this somewhere. I personally totally forgot about out brackets convention.
bschimke95
force-pushed
the
KU-1584/ipv6-testcases
branch
from
cf185c9
to
c4029e4
Compare
No description provided.