Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPv6 unittests #703

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Fix IPv6 unittests #703

merged 1 commit into from
Sep 27, 2024

Conversation

bschimke95
Copy link
Contributor

I merged #697 after merging #698 without rebasing. This caused a conflict as the function signature changed.

@bschimke95 bschimke95 requested a review from a team as a code owner September 27, 2024 18:40
addyess
addyess approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @bschimke95

@bschimke95 bschimke95 merged commit 1a7bafd into main Sep 27, 2024
20 checks passed
@bschimke95 bschimke95 deleted the bschimke95/fix-ipv6-tests branch September 27, 2024 19:21
evilnick pushed a commit to evilnick/k8s-snap that referenced this pull request Nov 14, 2024
@bschimke95 @evilnick
fix unittests after rebase (canonical#703)
2c04aec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addyess addyess addyess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bschimke95 @addyess