Decouple update k8sd-config configmap from k8s set API #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2024
neoaggelos
suggested changes
Apr 16, 2024
berkayoz
reviewed
Apr 16, 2024
bschimke95
force-pushed
the
KU-614/decouple-config-update
branch
2 times, most recently
from
c432250
to
51a3fad
Compare
neoaggelos
suggested changes
Apr 16, 2024
neoaggelos
approved these changes
Apr 17, 2024
bschimke95
force-pushed
the
KU-530/updates-for-external-datastore
branch
from
7e71884
to
cf5e5bc
Compare
neoaggelos
suggested changes
Apr 17, 2024
neoaggelos
reviewed
Apr 17, 2024
bschimke95
force-pushed
the
KU-614/decouple-config-update
branch
from
dbe5dcf
to
5a02237
Compare
|
neoaggelos
approved these changes
Apr 17, 2024
neoaggelos
merged commit 1233ff8
into
KU-530/updates-for-external-datastore
3 checks passed
neoaggelos
added a commit
that referenced
this pull request
Apr 17, 2024
This reverts commit 1233ff8.
neoaggelos
added a commit
that referenced
this pull request
Apr 17, 2024
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a controller that updates the
k8sd-configconfig map of the cluster asynchronously.It is triggered by the sending
struct{}to the controllersUpdateCh(e.g. by the bootstrap hook ork8s set).This is a first effort of making commands return fast instead of e.g. waiting for service restarts and apply changes async. Follow-up work will move the component updates to a controller as well.
Relates and works towards fixing:
#321 and #277