Decouple update k8sd-config configmap from k8s set API #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
force-pushed
the
KU-614/decouple-config-update
branch
from
fc0a81f
to
404d156
Compare
bschimke95
force-pushed
the
KU-614/decouple-config-update
branch
from
404d156
to
c253663
Compare
bschimke95
changed the base branch from
KU-530/updates-for-external-datastore
to
main
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work by @bschimke95, because I clicked the wrong button in #339
This PR adds a controller that updates the k8sd-config config map of the cluster asynchronously.
It is triggered by the sending struct{} to the controllers UpdateCh (e.g. by the bootstrap hook or k8s set).
This is a first effort of making commands return fast instead of e.g. waiting for service restarts and apply changes async. Follow-up work will move the component updates to a controller as well.
Relates and works towards fixing:
#321 and #277