Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add doc page on enabling Intel GPUs for dss #160

Merged
merged 32 commits into from
Aug 16, 2024
Merged

docs: Add doc page on enabling Intel GPUs for dss #160

merged 32 commits into from
Aug 16, 2024

Conversation

mvlassis
Copy link
Contributor

@mvlassis mvlassis commented Aug 9, 2024

This PR create a new how-to guide on the documentation that describes enabling the Intel GPU for DSS. It follows the steps described in the intel-dss-plugins-for-kubernetes repo.

To avoid confusion between the guides for Intel and NVIDIA GPUs, the guide for enabling NVIDIA GPUs has been renamed to be more descriptive.

In the Jupyter Notebooks how-to guide that focus on NVIDIA workflows, the description has been updated to reflect that change.

Closes #148.

@mvlassis mvlassis requested a review from a team as a code owner August 9, 2024 11:47
kimwnasptd
kimwnasptd reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@kimwnasptd kimwnasptd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR @mvlassis! Left some mostly structural comments

docs/how-to/enable-intel-gpu.rst Outdated Show resolved Hide resolved
docs/how-to/enable-intel-gpu.rst Outdated Show resolved Hide resolved
afgambin
afgambin reviewed Aug 12, 2024
View reviewed changes
docs/how-to/index.rst Outdated Show resolved Hide resolved
afgambin
afgambin reviewed Aug 12, 2024
View reviewed changes
docs/how-to/index.rst Outdated Show resolved Hide resolved
afgambin
afgambin reviewed Aug 12, 2024
View reviewed changes
docs/how-to/index.rst Outdated Show resolved Hide resolved
afgambin
afgambin reviewed Aug 13, 2024
View reviewed changes
docs/reuse/links.txt Outdated Show resolved Hide resolved
@afgambin afgambin changed the title Add doc page on enabling Intel GPUs for dss docs: Add doc page on enabling Intel GPUs for dss Aug 13, 2024
@NohaIhab NohaIhab mentioned this pull request Aug 14, 2024
Merged
afgambin
afgambin reviewed Aug 14, 2024
View reviewed changes
docs/how-to/index.rst Outdated Show resolved Hide resolved
afgambin
afgambin approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@afgambin afgambin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good to go from my side. good job all!

misohu
misohu approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DnPlas DnPlas merged commit 55e4bcf into main Aug 16, 2024
9 checks passed
@DnPlas DnPlas deleted the kf-6037-intel-gpu-doc branch August 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnPlas DnPlas DnPlas left review comments

@kimwnasptd kimwnasptd kimwnasptd left review comments

@afgambin afgambin afgambin approved these changes

@misohu misohu misohu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write dss doc about how to setup Intel GPU device plugin to microk8s
5 participants
@mvlassis @afgambin @kimwnasptd @misohu @DnPlas