Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add how-to guide to create Intel Notebook #163

Merged
merged 10 commits into from
Aug 20, 2024
Merged

docs: Add how-to guide to create Intel Notebook #163

merged 10 commits into from
Aug 20, 2024

Conversation

NohaIhab
Copy link
Contributor

@NohaIhab NohaIhab commented Aug 14, 2024 •
edited
Loading

closes #149

Note to reviewer: I'm referencing the guide from PR #160 that is not merged yet so the documentation build is expected to fail

@NohaIhab NohaIhab requested a review from a team as a code owner August 14, 2024 12:52
@afgambin
Copy link
Contributor

lgtm @NohaIhab. Let's wait for merging before the other PR. One comment, can we add any confirmation/verification the notebook has been properly created? as we do for the NVIDIA case

@NohaIhab
Copy link
Contributor Author

Hi @afgambin, I dropped the Intel team a question to ask if such command exists with which we can verify the same way we do with NVIDIA. In case it is not possible, we can instead link the calculation example Michal is working on in #150 telling users to try running it.

@afgambin
Copy link
Contributor

@NohaIhab the PR from Intel GPU has been merged. We can link it now from here.

@afgambin
Copy link
Contributor

afgambin commented Aug 19, 2024 •
edited
Loading

It was actually better to keep the previous way of linking using :ref: @NohaIhab. I just reedit it.

@afgambin
Copy link
Contributor

Did a pass @NohaIhab, left you some suggestions.

afgambin
afgambin approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@afgambin afgambin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some minor tweaks. lgtm @NohaIhab now, good job!

@NohaIhab NohaIhab merged commit 2001a65 into main Aug 20, 2024
9 checks passed
@NohaIhab NohaIhab deleted the kf-6038-docs-create-notebook-intel branch August 20, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afgambin afgambin afgambin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write dss doc on how to spin up Notebook from Intel with IPEX or ITEX
2 participants
@NohaIhab @afgambin