Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: clean up/rename errors #312

Merged
merged 2 commits into from
Dec 14, 2023
Merged

style: clean up/rename errors #312

merged 2 commits into from
Dec 14, 2023

Conversation

jsstevenson
Copy link
Member

@jsstevenson jsstevenson commented Dec 14, 2023 •
edited
Loading

close #297

  • Pulled out some unused code. Moved the only remaining custom ETL exception back into base.py, didn't think we needed a whole module for one exception.
  • Name custom exceptions as "Errors" per rule N818

@jsstevenson jsstevenson merged commit 305359b into interface-updates-epic Dec 14, 2023
21 checks passed
@jsstevenson jsstevenson deleted the fix-error-names branch December 14, 2023 17:40
@jsstevenson jsstevenson mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korikuzma korikuzma korikuzma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsstevenson @korikuzma