Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up errors and error names #297

Closed
jsstevenson opened this issue Nov 15, 2023 · 1 comment
Closed

Clean up errors and error names #297

jsstevenson opened this issue Nov 15, 2023 · 1 comment
Labels
priority:low Low priority

Comments

@jsstevenson
Copy link
Member

jsstevenson commented Nov 15, 2023 •
edited
Loading

They should all be "Error", not "Exception", per one of the linting rules.

We should also check that they live in the right place (ie not in __init__.py)
@jsstevenson jsstevenson added good first issue Good for newcomers priority:low Low priority labels Nov 17, 2023
@jsstevenson jsstevenson changed the title Update error names Clean up errors and error names Nov 21, 2023
@jsstevenson jsstevenson removed the good first issue Good for newcomers label Nov 21, 2023
@jsstevenson jsstevenson mentioned this issue Dec 14, 2023
Merged
@jsstevenson
Copy link
Member Author

closed in #312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsstevenson