Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate processInstanceId for execution jobs when invocationsPerBatchJob=1 #4205

Open
2 tasks
Tracked by #4199
yanavasileva opened this issue Mar 22, 2024 · 1 comment
Open
2 tasks
Tracked by #4199
Assignees
Labels
scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue.

Comments

@yanavasileva
Copy link
Member

yanavasileva commented Mar 22, 2024

Acceptance Criteria (Required on creation)

  • Populate process instance id (and process definition id where possible) for jobs
    • In case invocationsPerBatchJob=1 (jobConfiguration.getIds() != null && jobConfiguration.getIds().size() == 1)
      • Set the processInstanceId to the job.
      • Set the processDefinitionId to the job Edit: if the information is already available in the batch's configuration, at the moment only for restart batches. (That way the job logs will be visible in the Historic Process Definition page, Job log view.)
      • Code: org.camunda.bpm.engine.impl.batch.AbstractBatchJobHandler.createJobEntities(BatchEntity, T, String, List<String>, int)
  • Clean up the process instance population that is already done for some type of batches in org.camunda.bpm.engine.impl.batch.AbstractBatchJobHandler.postProcessJob(T, JobEntity, T)

Hints

  • Keep in mind that this implementation needs to be adopted by the users implementing custom batches

Links

Breakdown

Pull Requests

  1. punitdarira
  2. ci:all-db ci:default-build
    yanavasileva
@yanavasileva yanavasileva added the type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. label Mar 22, 2024
@yanavasileva yanavasileva changed the title Populate processInstanceId for execution jobs when invocationsPerBatchJob=1 Populate processInstanceId for execution jobs when invocationsPerBatchJob=1 Mar 22, 2024
@yanavasileva yanavasileva added the scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI label Mar 22, 2024
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue May 13, 2024
@yanavasileva yanavasileva self-assigned this May 17, 2024
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Jun 2, 2024
@yanavasileva yanavasileva removed their assignment Jun 12, 2024
@yanavasileva
Copy link
Member Author

yanavasileva commented Jun 28, 2024

Update on population of processDefinitionId for the batch execution jobs. The information is not available out of the box for most of the batches. With consideration of the performance (querying for each PI to fetch the process definition ID), we decided to populate the id only if it's already available (restart batch). We can iterate later on that if we receive user's feedback that this is needed.

punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Jun 29, 2024
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Jun 29, 2024
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Jul 9, 2024
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Sep 2, 2024
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Sep 2, 2024
yanavasileva pushed a commit that referenced this issue Sep 5, 2024
yanavasileva pushed a commit that referenced this issue Sep 5, 2024
yanavasileva pushed a commit that referenced this issue Sep 5, 2024
@yanavasileva yanavasileva self-assigned this Sep 10, 2024
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue.
Projects
None yet
Development

No branches or pull requests

1 participant