Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Optional) Introduce affectedByBatch filter criteria for historic process instance query #4215

Open
7 tasks
Tracked by #4198
yanavasileva opened this issue Mar 22, 2024 · 0 comments
Open
7 tasks
Tracked by #4198
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix.

Comments

@yanavasileva
Copy link
Member

yanavasileva commented Mar 22, 2024

Acceptance Criteria (Required on creation)

  • Extend the historic process instance query (HistoricProcessInstanceQuery) with #affectedByBatch(String batchId) filter criteria
    • filter historic process instances which are related to job log with the given batchId
    • check if an index can be added to improve the query
  • Expose changes in REST API
    • document in OpenAPI
  • Expose the filter in Cockpit and add a deep link button on the Batches page that leads to the process dashboard where filter will be preselect to display the impacted process instances
  • Document the new deep link in https://docs.camunda.org/manual/develop/webapps/cockpit/batch/monitoring/

Hints

  • query idea: SELECT from ACT_HI_PROCINST RES join ACT_HI_JOB_LOG JL where JL.batchId = param.batchId and RES.PROCESS_INSTANCE_ID_=JL.PROCESS_INSTANCE_ID_ - there will be more than one job log use the “exists” structure
  • Code:
    • org.camunda.bpm.engine.history.HistoricProcessInstanceQuery
    • engine\src\main\resources\org\camunda\bpm\engine\impl\mapping\entity\HistoricProcessInstance.xml
    • org.camunda.bpm.engine.rest.dto.history.HistoricProcessInstanceQueryDto
  • ❓ HPI supports OR queries, can/do we want the filter be supported for both AND and OR queries?
  • Add to javadoc hint for: If there’s a performance issue, the user needs to clean up their history tables.

Links

Breakdown

Pull Requests

No tasks being tracked yet.

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@yanavasileva yanavasileva added the type:task Issues that are a change to the project that is neither a feature nor a bug fix. label Mar 22, 2024
@yanavasileva yanavasileva changed the title Introduce impactedByBatch filter criteria for historic process instance query (Optional) Introduce impactedByBatch filter criteria for historic process instance query Mar 22, 2024
@yanavasileva yanavasileva changed the title (Optional) Introduce impactedByBatch filter criteria for historic process instance query (Optional) Introduce affectedByBatch filter criteria for historic process instance query Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix.
Projects
None yet
Development

No branches or pull requests

1 participant