Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce notAffectedByModificationBatch filter criteria for process instances #4209

Open
4 tasks
Tracked by #4200
yanavasileva opened this issue Mar 22, 2024 · 2 comments
Open
4 tasks
Tracked by #4200

Introduce notAffectedByModificationBatch filter criteria for process instances #4209

yanavasileva opened this issue Mar 22, 2024 · 2 comments
Labels
scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI type:feature Issues that add a new user feature to the project. type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue.

Comments

@yanavasileva
Copy link
Member

yanavasileva commented Mar 22, 2024 •
edited
Loading

Acceptance Criteria (Required on creation)

  • Extend the process instance query (ProcessInstanceQuery) with #notAffectedByModificationBatch filter criteria
    • process instances for which exist jobs with not empty batch and instance-modification type
    • check if an index can be added to improve the query
  • Expose changes in REST API
    • document in OpenAPI

Hints

  • Affected public API code:
    • selectExecutionsByQueryCriteriaSql in /camunda-engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/Execution.xml
      • Join Execution table with ACT_RU_JOB where job.processInstanceId == processInstanceId and job.batchId != null and job.type == “instance-modification”
    • org.camunda.bpm.engine.runtime.ProcessInstanceQuery and implementation
    • org.camunda.bpm.engine.rest.dto.runtime.ProcessInstanceQueryDto

Links

Breakdown

Pull Requests
Beta Give feedback
No tasks being tracked yet.
@yanavasileva yanavasileva added the type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. label Mar 22, 2024
@yanavasileva yanavasileva mentioned this issue Mar 22, 2024
Open
1 task
@yanavasileva yanavasileva changed the title Introduce notPartOfModificationBatch filter criteria for process instances Introduce notPartOfModificationBatch filter criteria for historic process instances Mar 22, 2024
@yanavasileva yanavasileva added the scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI label Mar 22, 2024
@yanavasileva yanavasileva changed the title Introduce notPartOfModificationBatch filter criteria for historic process instances Introduce notPartOfModificationBatch filter criteria for process instances Mar 22, 2024
@yanavasileva yanavasileva changed the title Introduce notPartOfModificationBatch filter criteria for process instances Introduce notAffectedByModificationBatch filter criteria for process instances Mar 27, 2024
@yanavasileva yanavasileva mentioned this issue May 17, 2024
Open
2 tasks
@tasso94 tasso94 added type:feature Issues that add a new user feature to the project. version:7.22.0 and removed version:7.22.0 labels Sep 6, 2024
@tasso94
Copy link
Member

tasso94 commented Sep 6, 2024

Hi @yanavasileva,

Low prio question: we are currently busy replacing the runtime with the history query in Cockpit.
Can we apply the changes outlined in this ticket to the history query?

Best,
Tassilo

@yanavasileva
Copy link
Member Author

Low prio question

I haven't forgotten about this. I will try to have a look next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI type:feature Issues that add a new user feature to the project. type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tasso94 @yanavasileva