[18.0][MIG] hr_holidays_public: Migration to 18.0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaviedoanhduy
force-pushed
the
18.0-mig-hr_holidays_public
branch
7 times, most recently
from
53fa8b5 to
5234789
Compare
henrybackman
approved these changes
Oct 10, 2024
|
to be moved to OCA |
|
Also, consider implementing OCA#111 |
Add correct calculation of holidays in hr_public_holidays, instead of hr_holidays_compute_days. Remove dependancy of contracts. Add unlink at onchnage of public holiday lines. Update code. Fix flake. Update code, add calculation in hours, update views. Update flake. Update calendar creation with no attendances, otherwise default values were set. Remove config of show days/hours. Update flake. Update readme. Rename module. Updated holiday reports. Update klake and pylint. Update flaket. Update hr_holidays_views.xml Add readonly to show_full_days. Update code according with comments. Increase coverage. update flake8.
Hours part will be in module hr_holidays_hour.
Reduce to the minimum the footprint of this module, adding only public holidays as leaves in a transparent way by other modules.
This has been totally reworked for decoupling parts, not depending now on hr_holidays_public, and making transparent its use for compatibility with other modules.
Currently translated at 52.5% (21 of 40 strings) Translation: hr-11.0/hr-11.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_public/de/
Currently translated at 55.0% (22 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/
Currently translated at 95.0% (38 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/fr/
Currently translated at 92.5% (37 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/
Currently translated at 92.5% (37 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/de/
Currently translated at 100.0% (40 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/
…idays are defined for each year
decorate hr.holidays.public.line::create with api.model_create_multi
Currently translated at 100.0% (41 of 41 strings) Translation: hr-holidays-15.0/hr-holidays-15.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-15-0/hr-holidays-15-0-hr_holidays_public/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-holidays-16.0/hr-holidays-16.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-16-0/hr-holidays-16-0-hr_holidays_public/
- Include context keys for avoiding mail operations overhead.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/
Currently translated at 100.0% (40 of 40 strings) Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/it/
…loyee Use case: - Go to Employees to an employee with a different address (country) than our own and with specific public holidays for that country. - Go to the Time-off smart-buttons - We will have to see there the public holidays according to the employee's address TT49839
…hod if the record does not exist yet)
Helper functions to find public holidays did allow to use an hr.employee to filter country and states based on the employee address. Since only the address of the employee was used, modifying the functions to use a res.partner instead of an hr.employee allows more possibilities such as checking public holidays for customers and suppliers.
xaviedoanhduy
force-pushed
the
18.0-mig-hr_holidays_public
branch
from
5234789 to
8c38d8a
Compare
|
Supersedes: OCA#147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change on version 18.0
number_of_hours_displayfields has been removed inhttps://github.com/odoo/odoo/pull/156117On the occasion
OCA - port
https://github.com/OCA/hr-holidays/pull/144