forked from OCA/hr-attendance
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] hr_attendance_report_theoretical_time: Migration to 18.0 #4
Closed
xaviedoanhduy
wants to merge
40
commits into
18.0-dev
from
18.0-mig-hr_attendance_report_theoretical_time
Closed
[18.0][MIG] hr_attendance_report_theoretical_time: Migration to 18.0 #4
xaviedoanhduy
wants to merge
40
commits into
18.0-dev
from
18.0-mig-hr_attendance_report_theoretical_time
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaviedoanhduy
force-pushed
the
18.0-mig-hr_attendance_report_theoretical_time
branch
from
October 1, 2024 09:44
e36289a
to
5d3e707
Compare
chaule97
approved these changes
Oct 2, 2024
thienvh332
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xaviedoanhduy
force-pushed
the
18.0-mig-hr_attendance_report_theoretical_time
branch
from
October 3, 2024 10:09
4d47567
to
4d44a47
Compare
Theoretical vs Attended Time Analysis ===================================== This module adds a new report called "Theoretical vs Attended Time Analysis" that compares worked time, measured through attendances records, with the theoretical time, computed from employee's working calendar, public holidays and employee specific leaves. There is the possibility of counting as theoretical time some leave types if specified in them. Installation ============ On installation time, this module computes the theoretical hours for the day of the attendance check-in, so if you have a lot of records, this would be a bit slow. Configuration ============= You need to be at least "Attendance / Manual Attendance" for being able to see the attendances report. For including some leave types in the theoretical time, you have to: * Go to Leaves > Configuration. * Select leave type you want to include. * Check the mark "Include in theoretical hours". Usage ===== * Go to *Attendances > Reports > Theoretical vs Attended Time Analysis*. * Check pivot table or look at the graph view. Known issues / Roadmap ====================== * Employees with less than 1 week in the company will show full week theoretical hours. * Activate ORM cache for improving performance on computing theoretical hours, but assuring that the cache is cleared when the conditions of the computation changes. * If you change employee's working time, theoretical hours for non attended days will be computed according this new calendar. You have to define start and end dates inside the calendar for avoiding this side effect. * Recompute theoretical hours of affected days when changing the leave type to be included or not in theoretical time.
* Standard procedure * Adapt data model * Adapt views * Adapt code for date handling * Adapt tests [UPD] Update hr_attendance_report_theoretical_time.pot
…fault filter Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/
[UPD] Update hr_attendance_report_theoretical_time.pot hr_attendance_report_theoretical_time 12.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/
Currently translated at 97.6% (41 of 42 strings) Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/de/
- We add a wizard so the already existing attendances can be recomputed according to an employee calendar change, like a different for a set of dates that weren't took into consideration in advance, so the wrong theoretical hours are computed. [UPD] Update hr_attendance_report_theoretical_time.pot [UPD] README.rst hr_attendance_report_theoretical_time 12.0.1.2.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_attendance_report_theoretical_time/
- Although the minor permission to access the theoretical time report is "Manual Attendance", the menu wasn't accessible due to permissions. - Record rules also prevent such users from seeing other employees attendances. hr_attendance_report_theoretical_time 12.0.1.3.0
…rm related to employee public (user without employee groups)
… (context) when hr_attendance_theoretical_action is load from wizard
[UPD] Update hr_attendance_report_theoretical_time.pot [UPD] README.rst
…d in wizard correctly according to companies
…(including archived employees) in wizard hr_attendance_report_theoretical_time 14.0.1.0.1
Currently translated at 96.1% (50 of 52 strings) Translation: hr-attendance-14.0/hr-attendance-14.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-14-0/hr-attendance-14-0-hr_attendance_report_theoretical_time/bg/
…port hr_attendance_report_theoretical_time 14.0.1.0.2
…the tests in TestHrAttendanceReportTheoreticalTimeBase to improve the inheritance of tests in other modules. TT34898 hr_attendance_report_theoretical_time 14.0.1.0.3
…ate the total hours in two-week calendars with defined start and end dates (solved since odoo/odoo#96391). TT34416 hr_attendance_report_theoretical_time 14.0.1.0.4
Tests rely on removing tz from the current user and it isn't possible anymore after odoo/odoo@d6f2437#diff-38469def2f870bb866f971f57797dd7c21b6a95d52a8eae72f832f0eea2434f9R105
Currently translated at 100.0% (53 of 53 strings) Translation: hr-attendance-15.0/hr-attendance-15.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-15-0/hr-attendance-15-0-hr_attendance_report_theoretical_time/it/
…cover different use cases.
Currently translated at 100.0% (53 of 53 strings) Translation: hr-attendance-16.0/hr-attendance-16.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-16-0/hr-attendance-16-0-hr_attendance_report_theoretical_time/es/
… a basic user We need to leave the action empty for consistency because we are going to set different submenus, otherwise the Reports menu would not be displayed to a basic user. TT44849
Currently translated at 47.1% (25 of 53 strings) Translation: hr-attendance-16.0/hr-attendance-16.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-16-0/hr-attendance-16-0-hr_attendance_report_theoretical_time/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-attendance-17.0/hr-attendance-17.0-hr_attendance_report_theoretical_time Translate-URL: https://translation.odoo-community.org/projects/hr-attendance-17-0/hr-attendance-17-0-hr_attendance_report_theoretical_time/
xaviedoanhduy
force-pushed
the
18.0-mig-hr_attendance_report_theoretical_time
branch
from
October 14, 2024 10:42
4d44a47
to
8f3ced6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
https://github.com/camptocamp/hr-holidays/pull/2
OCA-Port
https://github.com/OCA/hr-attendance/pull/181