-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: run DBT from devcontainer #3515
base: main
Are you sure you want to change the base?
Conversation
404f963
to
5fb0819
Compare
Starting a review of this. Gonna try opening up the devcontainer! |
The devcontainer was created and opened for me 🎉 I think I'm now at the point of setting up my dbt profile (probably the command in Snippets of my output:
...
Nothing happens here. 🤔 |
I tried copying the URL from the output and opening that in a browser manually, and that did show me a Google consent screen for Google Cloud SDK, but then when I finished going through the consent screens, it redirected me to a My devcontainer terminal is still waiting for me to log in. 🤔 Screenshot of devcontainer terminal![image](https://github.com/user-attachments/assets/ded884f6-ac1e-4cb6-b5e8-373b74b7b98e) |
That second screenshot with the links in the console, can you click from there? That's what I had to do, and it worked after I logged in to my Google account on the browser. |
It doesn't let me click the full link, unfortunately. For some reason, it's getting cut off maybe by a line break or something. If it'd be helpful for me to get on a screenshare with you, let me know |
The devcontainer was created and it opened for me too 🙂. I did notice an error when
Then I was able to create my profile using my name as |
- remove node install - add google-cloud-cli install - use non-root user
- extra mounted volumes - env vars modernize devcontainer.json syntax use postAttach to ensure dbt and gcloud are configured
script seems unused
5fb0819
to
da3a916
Compare
@lalver1 I see in your output:
This seems strange? Did your Docker VM run out of virtual hard disk? |
Looks like the problem was with my Docker Engine @thekaveman. I cleaned up several dangling images I had and rebuilt the container and |
Description
After working on #3468 and trying to get things running on a new local environment, I thought it would be nice to encode the dependencies and tools into the devcontainer configuration. This makes it much easier to get DBT running from a fresh environment, and is system/platform agnostic.
Type of change
How has this been tested?
See the README updates for steps to test/run this locally.
Post-merge follow-ups
Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.