Fix: reorder Benefits mart fields #3518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently on top of #3515, so I could test this locally more easily. Once that PR is merged, this can be rebased onmain
.Description
Follow up to #3468.
The
UNION DISTINCT
was producing strange results, e.g. combining results from different columns into the same output column.This was due to one or both of:
This PR alphabetizes the fields in both
SELECT
statements, and ensures that the transformSELECTS
all fields from the baseline CTE.A minor side effect of this cleanup was to remove the transform CTE in favor of a direct
SELECT
statement. This simplifies the back-and-forth to keep the field order straight.This is a full list of the fields in alphabetical order (from BigQuery)
Type of change
How has this been tested?
Post-merge follow-ups