n8n: new service #1630
Open
n8n: new service #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-am-logger
force-pushed
the
logger/n8n
branch
5 times, most recently
from
13c929f to
f5fbdba
Compare
i-am-logger
force-pushed
the
logger/n8n
branch
from
f5fbdba to
8c87d38
Compare
|
working, would appriciate a review |
sandydoo
requested changes
Dec 31, 2024
There was a problem hiding this comment.
Thanks, @i-am-logger. I've requested a bunch of minor changes, but otherwise looks good overall.
| }; | ||
|
|
||
| processes.n8n = { | ||
| exec = "${pkgs.n8n}/bin/n8n"; |
There was a problem hiding this comment.
It's nice to have a package option in the module to let people override the package used.
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
To test that it launches, you can add a .test.sh script in this folder and curl a health endpoint of some kind. There are lots of examples of this in the repo.
| @@ -0,0 +1,2 @@ | |||
| { ... }: | |||
There was a problem hiding this comment.
The n8n can be removed in favor of the test.
|
@i-am-logger, I think quite a few of the requested changes are also applicable to your previous PR. I'll be happy to review it once updated. |
Co-authored-by: sander <[email protected]>
Co-authored-by: sander <[email protected]>
Co-authored-by: sander <[email protected]>
Co-authored-by: sander <[email protected]>
Co-authored-by: sander <[email protected]>
Co-authored-by: sander <[email protected]>
Co-authored-by: sander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having an issue #1628 will appriciate the help.