Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is closed due to some issues don't go through it. #87

Closed
wants to merge 6 commits into from
Closed

This is closed due to some issues don't go through it. #87

wants to merge 6 commits into from

Conversation

Hemu21
Copy link

@Hemu21 Hemu21 commented Feb 24, 2024

Fixed the Remove Header from 404 Page because 404 page does not contain any header or any footer.

Description

Fixed the Remove Header from 404 Page because 404 page does not contain any header or any footer. But You can find the header in 404 page. 404 page can contain a button that redirect to the home page. This is the bug present in 404 page. I had Fixed it and Updated the test file that contain the incorrect path that searches for hamburger menu. So in wrong path user can't find the website details and user can redirect to home page on clicking the back to home button.

Related Issue

Remove Header from 404 Page resolve #86

steps to reproduce

  • Go to any url location not present in the website.
  • example url http://localhost:5173/werty
  • You can see the 404 page. It contains the header.
  • As shown in below Image

create_issue

Link of the Issue

https://github.com/c2siorg/Codelabz/issues/86

Motivation and Context

404 is a one of the important page. why because you it is the page that doesn't present in the url pattern. it is the page that you doesn't created any specific function or not redirecting the user. So it doesn't contain any data of our website and user but it has capability to redirect our user to home page. This makes good user experience and makes our website functionality good.

How Has This Been Tested?

  • setup the project in your localhost.
  • If you go to any url location not present in the website.
  • example url "http://localhost:5173/werty"
  • You can see the 404 page. It does not contain the header.
  • As shown in below Image

Screenshots or GIF (In case of UI changes):

404_expected

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review Request

@Maahi10001 @ABHISHEK-PANDEY2 @Shiva-Nanda @c2sibot Please Review My PR. Approve My PR

@Hemu21 Hemu21 closed this by deleting the head repository Feb 25, 2024
@Hemu21 Hemu21 changed the title Remove Header from 404 Page #86 Fixed This is closed due to some issues don't go through it. Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Header from 404 Page
1 participant