Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Header from 404 Page #86

Closed
Hemu21 opened this issue Feb 24, 2024 · 6 comments · May be fixed by #102
Closed

Remove Header from 404 Page #86

Hemu21 opened this issue Feb 24, 2024 · 6 comments · May be fixed by #102
Labels
bug Something isn't working stale UI/UX

Comments

@Hemu21
Copy link

Hemu21 commented Feb 24, 2024

Describe the bug

404 page does not contain any header or any footer. But You can find the header in 404 page. 404 page can contain a button that redirect to the home page. This is the bug present in 404 page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any url location not present in the website.
  2. example url "http://localhost:5173/werty"
  3. You can see the 404 page. It contains the header.
  4. As shown in below Image

create_issue

Expected behavior

  1. When you go to any url location not present in the website.
  2. example url "http://localhost:5173/werty"
  3. You can see the 404 page. It does not contain the header.
  4. As shown in below Image

404_expected

@github-actions github-actions bot added bug Something isn't working UI/UX labels Feb 24, 2024
Copy link

Hello 👋🏻 @Hemu21! Thankyou for creating an issue!

@rohitPandey469
Copy link

Give it a fixed width and height, make it go exact at the center. And, for the time being, the access control requirements will stay same, so decentralized check in the routes file would be ok I think i.e. UserIsAllowed CheckSSS in one file. What are your thoughts about this @Hemu21 ??

@Hemu21
Copy link
Author

Hemu21 commented Feb 24, 2024

@rohitPandey469 Ok, I will make it center.

@Hemu21
Copy link
Author

Hemu21 commented Feb 24, 2024

@rohitPandey469 Now Fixed in the #87 Thank you for the suggestion.

Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Mar 26, 2024
Copy link

github-actions bot commented Apr 9, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale UI/UX
Projects
None yet
2 participants