pass part echo CI in windows

monoio/src/driver/op/read.rs

@@ -9,7 +9,7 @@ use {
     std::ffi::c_void,
     windows_sys::Win32::{
         Foundation::TRUE,
-        Networking::WinSock::{WSAGetLastError, WSARecv, SOCKET_ERROR},
+        Networking::WinSock::{WSAGetLastError, WSARecv},
         Storage::FileSystem::{ReadFile, SetFilePointer, FILE_CURRENT, INVALID_SET_FILE_POINTER},
     },
 };
@@ -155,9 +155,7 @@ impl<T: IoVecBufMut> Op<ReadVec<T>> {
 
         if let Ok(n) = res {
             // Safety: the kernel wrote `n` bytes to the buffer.
-            unsafe {
-                buf_vec.set_init(n);
-            }
+            unsafe { buf_vec.set_init(n) };
         }
         (res, buf_vec)
     }
@@ -188,26 +186,24 @@ impl<T: IoVecBufMut> OpAble for ReadVec<T> {
 
     #[cfg(all(any(feature = "legacy", feature = "poll-io"), windows))]
     fn legacy_call(&mut self) -> io::Result<u32> {
-        let mut bytes_recved = 0;
+        let mut bytes_received = 0;
         let ret = unsafe {
             WSARecv(
                 self.fd.raw_socket() as _,
                 self.buf_vec.write_wsabuf_ptr(),
-                self.buf_vec.write_wsabuf_len() as _,
-                &mut bytes_recved,
-                std::ptr::null_mut(),
+                self.buf_vec.write_wsabuf_len().min(u32::MAX as usize) as _,
+                &mut bytes_received,
+                &mut 0,
                 std::ptr::null_mut(),
                 None,
             )
         };
         match ret {
-            0 => return Err(std::io::ErrorKind::WouldBlock.into()),
-            SOCKET_ERROR => {
+            0 => Ok(bytes_received),
+            _ => {
                 let error = unsafe { WSAGetLastError() };
-                return Err(std::io::Error::from_raw_os_error(error));
+                Err(io::Error::from_raw_os_error(error))
             }
-            _ => (),
         }
-        Ok(bytes_recved)
     }
 }

monoio/src/driver/op/write.rs

@@ -5,7 +5,7 @@ use io_uring::{opcode, types};
 #[cfg(all(windows, any(feature = "legacy", feature = "poll-io")))]
 use windows_sys::Win32::{
     Foundation::TRUE,
-    Networking::WinSock::{WSAGetLastError, WSASend, SOCKET_ERROR},
+    Networking::WinSock::{WSAGetLastError, WSASend},
     Storage::FileSystem::{SetFilePointer, WriteFile, FILE_CURRENT, INVALID_SET_FILE_POINTER},
 };
 #[cfg(all(unix, any(feature = "legacy", feature = "poll-io")))]
@@ -188,13 +188,11 @@ impl<T: IoVecBuf> OpAble for WriteVec<T> {
             )
         };
         match ret {
-            0 => return Err(std::io::ErrorKind::WouldBlock.into()),
-            SOCKET_ERROR => {
+            0 => Ok(bytes_sent),
+            _ => {
                 let error = unsafe { WSAGetLastError() };
-                return Err(std::io::Error::from_raw_os_error(error));
+                Err(io::Error::from_raw_os_error(error))
             }
-            _ => (),
         }
-        Ok(bytes_sent)
     }
 }

monoio/tests/tcp_echo.rs

@@ -3,8 +3,6 @@ use monoio::{
     net::{TcpListener, TcpStream},
 };
 
-// todo fix these CI in windows
-#[cfg(not(windows))]
 #[monoio::test_all]
 async fn echo_server() {
     const ITER: usize = 1024;