pass part echo CI in windows #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loongs-zhang
commented
Feb 27, 2024
monoio/src/driver/op/read.rs
Outdated
| let error = unsafe { WSAGetLastError() }; | ||
| return Err(std::io::Error::from_raw_os_error(error)); | ||
| Err(io::Error::from_raw_os_error(error)) |
ihciah
reviewed
Feb 28, 2024
monoio/src/driver/op/read.rs
Outdated
| &mut bytes_recved, | ||
| std::ptr::null_mut(), | ||
| &mut bytes_received, | ||
| &mut 0, |
There was a problem hiding this comment.
The lpFlags here is used as both in and out. So it has to be able to read and write.
Have you tried to implement it like rust std? In std impl, it declare 2 temp variable nread and flags, and then pass the mut references.
https://github.com/rust-lang/rust/blob/master/library/std/src/sys/pal/windows/net.rs#L253
There was a problem hiding this comment.
It is equivalent.
Still blocked in monoio/tests/tcp_echo.rs:45
ihciah
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.