[wit-bindgen-rust] Fix 2024 edition compat #1183
Open
+162
−144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should fix the failing CI in bytecodealliance/cargo-component#372, triggered by the new edition. I'm not entirely sure why the tests seem to be opting into a new edition, but I guess they do? Regardless: this changes the codegen of
wit-bindgen-rust
to respect the new "unsafe fn
does not implyunsafe {}
" rule added in the 2024 edition.This PR is best reviewed commit by commit. The first commit is just the output of
cargo fix --edition
. The second commit are the actualunsafe
changes. (edit: and the third commit reverts the 2024 edition style changes to make CI pass).Thanks!