-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust Edition 2024 #374
Comments
@DrewRidley that would be great actually, thank you! |
Just bit me too. :) |
bytecodealliance/wit-bindgen#1119 It appears this issue was fixed a month ago upstream, its just has to be incorporated in |
Ah shoot, I thought this might be the same failure that was causing #372 (comment). It seems something else related might be happening that needs digging into. E.g. we're still seeing this error in CI:
|
Filed bytecodealliance/wit-bindgen#1183 which I believe should fix this |
Hey all, super excited about the work you are doing for the future of wasm!
As of recently, I think a few days ago, Edition 2024 was officially released in Rust, and it seems like one of the biggest breaking changes made was the requirement of unsafe attributes for
#[no_mangle]
and#[link_section]
Unfortunately as of late, the example code provided does not compile. Fortunately its a very easy fix (https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-attributes.html).
Let me know if I can help by getting a PR rolling to accommodate this change.
The text was updated successfully, but these errors were encountered: