Skip to content

Commit

Permalink
removed the hotfix for Cloudflare Worker issue; changed product filte…
Browse files Browse the repository at this point in the history
…rs to an array of integers
  • Loading branch information
Mohammad Tomaraei committed Sep 24, 2021
1 parent 21d015b commit 79a45a2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion src/catalog/controller/vsbridge/products.php
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ public function populateProducts($input){

foreach($product_filters as $product_filter){
if(isset($product_filter['filter_group_id']) && isset($product_filter['filter_id'])){
$product_array['filter_group_'.$product_filter['filter_group_id']] = (int) $product_filter['filter_id'];
$product_array['filter_group_'.$product_filter['filter_group_id']][] = (int) $product_filter['filter_id'];
}
}

Expand Down
5 changes: 0 additions & 5 deletions src/catalog/controller/vsbridge/sync_session.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ public function index(){
session_id($vsbridge_session_id);
session_start();

// Temporary, edge case hotfix due to https://github.com/cloudflare/cloudflare-docs/issues/17
// Summary: Cloudflare workers combine set-cookie headers, but Chrome >= 88 only takes the first cookie
// Fix: We clear previous cookies to set the session properly
header_remove('Set-Cookie');

$this->session->start('default', $vsbridge_session_id);

// to: GET parameter determining the redirection destination
Expand Down

0 comments on commit 79a45a2

Please sign in to comment.