Skip to content

Commit

Permalink
Temporary hotfix to keep a single set-cookie header in sync_session
Browse files Browse the repository at this point in the history
  • Loading branch information
Mohammad Tomaraei committed Sep 15, 2021
1 parent 7c05aa3 commit 21d015b
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/catalog/controller/vsbridge/sync_session.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ public function index(){
session_abort();
session_id($vsbridge_session_id);
session_start();

// Temporary, edge case hotfix due to https://github.com/cloudflare/cloudflare-docs/issues/17
// Summary: Cloudflare workers combine set-cookie headers, but Chrome >= 88 only takes the first cookie
// Fix: We clear previous cookies to set the session properly
header_remove('Set-Cookie');

$this->session->start('default', $vsbridge_session_id);

// to: GET parameter determining the redirection destination
Expand Down

0 comments on commit 21d015b

Please sign in to comment.