PROD-7724 - Fix: Count of connection and following in members page. #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitendrabanjara1991
requested changes
Sep 9, 2024
Comment on lines
255
to
266
| if ( bp_is_active( 'moderation' ) ) { | ||
| $suspended_user_ids = bb_moderation_get_suspended_user_ids(); | ||
|
|
||
| if ( ! empty( $suspended_user_ids ) ) { | ||
| // Use prepare to safely include suspended user IDs. | ||
| $placeholders = implode( ', ', array_fill( 0, count( $suspended_user_ids ), '%d' ) ); | ||
| $following_where_sql .= $wpdb->prepare( | ||
| " AND leader_id NOT IN ( {$placeholders} ) ", | ||
| ...$suspended_user_ids | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
@istiaq-bb Please add filter here and use that filter inside in moderation component and move moderation query there.
…spended Issue: total_friend_count meta was not updating correctly due to a strict type comparison between user_id (string) and friend_ids (integer). Root Cause: The condition 'hide' === $type && in_array( $user_id, $friend_ids, true ) was failing because in_array was performing a strict type check (true flag), and $user_id was a string while friend_ids were integers. Fix: Cast $user_id to integer before comparison to ensure the condition is satisfied.
- Added a filter to the friendship SQL query that excludes moderated/suspended users. This ensures accurate friendship counts when running the 'Repair total connections count for each member' tool from the admin panel, preventing incorrect counts for users with suspended friendships.
- Add migration code to fix my connection count and remove suspend user from follow table if any user is suspended
…owers for suspend members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue:
https://buddyboss.atlassian.net/browse/PROD-7724
General Note
Keep all conversations related to this PR in the associated Jira issue(s). Do NOT add comment on this PR or edit this PR’s description.
Notes to Developer
Notes to Reviewer