more go-like error handling #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JssDWt
force-pushed
the
jssdwt-go-snippets-error-handling
branch
2 times, most recently
from
98542fc to
d74f966
Compare
dangeross
reviewed
Jan 10, 2025
snippets/go/connecting_lsp.go
Outdated
Comment on lines
42
to
45
| if err != nil { | ||
| return err | ||
| } | ||
| log.Printf("%#v", err) |
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| return err | |
| } | |
| log.Printf("%#v", err) | |
| if err != nil { | |
| log.Printf("%#v", err) | |
| return err | |
| } |
There was a problem hiding this comment.
Good catch. I will just remove the logline here.
JssDWt
force-pushed
the
jssdwt-go-snippets-error-handling
branch
from
d74f966 to
42f734b
Compare
dangeross
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.