-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify error handling in golang snippets #158
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ross Savage <[email protected]>
Co-authored-by: Ross Savage <[email protected]>
Co-authored-by: Ross Savage <[email protected]>
Co-authored-by: Ross Savage <[email protected]>
Co-authored-by: Ross Savage <[email protected]>
Co-authored-by: Ross Savage <[email protected]>
@JssDWt is this what you had in mind? |
ok300
force-pushed
the
ok300-simplify-golang-error-handling
branch
from
April 30, 2024 13:01
bf86feb
to
b4486af
Compare
For the functions where an
or if there is already a return type:
|
That's exactly what I had in mind! |
Base automatically changed from
ok300-add-channel-open-fees-receive-payment
to
pre-release
September 8, 2024 07:27
Replaced by #183 because it was easier to recreate than to fix the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #122 (comment) , this PR updates the error handling in golang snippets.