Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeHealth][rust] Update chrono-0.4.24 => chrono-0.4.39 #27693

Merged
merged 3 commits into from
Feb 19, 2025
Merged

[CodeHealth][rust] Update chrono-0.4.24 => chrono-0.4.39 #27693

merged 3 commits into from
Feb 19, 2025

Conversation

cdesouza-chromium
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium commented Feb 17, 2025 •
edited
Loading

This PR updates chrono to version 0.4.39. This is one of the steps to eventually allow dropping [email protected].

Updating this crate has run into issues with the list remove_crates in gnrt_config.toml, which had to be updated to better match the upstream version. Addional changes were necessary to correct failures around license file paths for some of the crates affected.

Resolves brave/brave-browser#44035

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@cdesouza-chromium cdesouza-chromium self-assigned this Feb 17, 2025
@cdesouza-chromium cdesouza-chromium requested review from a team and bridiver as code owners February 17, 2025 12:58
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Feb 17, 2025
@cdesouza-chromium cdesouza-chromium changed the title Update to chrono 0.4.39 [CodeHealth][rust] Update chrono-0.4.24 => chrono-0.4.39 Feb 17, 2025
bridiver
bridiver approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should follow-up to see if we can remove any parts of the clock feature

cdesouza-chromium added a commit that referenced this pull request Feb 18, 2025
@cdesouza-chromium
[CodeHealth][rust] Update features 0.3.27 => 0.3.31
d895f37 
This PR updates the `features` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change removes the previous `extra_src_roots` instructions for the
future deps, as those started panicking when running `gnrt` in the
current version.

`chrono` PR: #27693

Resolves brave/brave-browser#44057
cdesouza-chromium added a commit that referenced this pull request Feb 18, 2025
@cdesouza-chromium
[CodeHealth][rust] Update features 0.3.27 => 0.3.31
35f8684 
This PR updates the `features` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change contains all the files changed by `gnrt`.

`chrono` PR: #27693

Resolves brave/brave-browser#44057
@cdesouza-chromium cdesouza-chromium mentioned this pull request Feb 18, 2025
Merged
24 tasks
cdesouza-chromium added a commit that referenced this pull request Feb 18, 2025
@cdesouza-chromium
[CodeHealth][rust] Update futures 0.3.27 => 0.3.31
2333ddc 
This PR updates the `futures` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change removes the previous `extra_src_roots` instructions for the
future deps, as those started panicking when running `gnrt` in the
current version.

`chrono` PR: #27693

Resolves brave/brave-browser#44057
cdesouza-chromium added a commit that referenced this pull request Feb 18, 2025
@cdesouza-chromium
[CodeHealth][rust] Update futures 0.3.27 => 0.3.31
3235a6b 
This PR updates the `futures` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change contains all the files changed by `gnrt`.

`chrono` PR: #27693

Resolves brave/brave-browser#44057
@github-actions GitHub Actions
Copy link
Contributor

Chromium major version is behind target branch (133.0.6943.98 vs 134.0.6998.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
cdesouza-chromium added a commit that referenced this pull request Feb 18, 2025
@cdesouza-chromium
[CodeHealth][rust] Update futures 0.3.27 => 0.3.31
4a28ef2 
This PR updates the `futures` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change removes the previous `extra_src_roots` instructions for the
future deps, as those started panicking when running `gnrt` in the
current version.

`chrono` PR: #27693

Resolves brave/brave-browser#44057
cdesouza-chromium added a commit that referenced this pull request Feb 18, 2025
@cdesouza-chromium
[CodeHealth][rust] Update futures 0.3.27 => 0.3.31
803b09e 
This PR updates the `futures` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change contains all the files changed by `gnrt`.

`chrono` PR: #27693

Resolves brave/brave-browser#44057
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
mkarolin pushed a commit that referenced this pull request Feb 19, 2025
@cdesouza-chromium
[CodeHealth][rust] Update futures 0.3.27 => 0.3.31 (#27707)
e475ac9 
* [CodeHealth][rust] Update `futures` `0.3.27` => `0.3.31`

This PR updates the `futures` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change removes the previous `extra_src_roots` instructions for the
future deps, as those started panicking when running `gnrt` in the
current version.

`chrono` PR: #27693

Resolves brave/brave-browser#44057

* [CodeHealth][rust] Update `futures` `0.3.27` => `0.3.31`

This PR updates the `futures` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change contains all the files changed by `gnrt`.

`chrono` PR: #27693

Resolves brave/brave-browser#44057
@cdesouza-chromium
[CodeHealth][rust] Update chrono-0.4.24 => chrono-0.4.39
bdc2549 
This PR updates `chrono` to version `0.4.39`. This is one of the steps
to eventually allow dropping `[email protected]`.

Updating this crate has run into issues with the list `remove_crates` in
`gnrt_config.toml`, which had to be updated to better match the upstream
version. Addional changes were necessary to correct failures around
license file paths for some of the crates affected.

Resolves brave/brave-browser#44035
@cdesouza-chromium
[CodeHealth][rust] Update remove_crates list with upstream
3970c9a 
This list was not entirely matching the upstream one, which at first was
not a problem, but this has run into issues running `gnrt gen` once
`chrono` was updated. This change adds the missing `windows_*` crates
that belong to that list to the brave file.
@cdesouza-chromium
[CodeHealth][rust] Using a common Apache-2.0 for some crates
c7e84a4 
For some reason some of these crates are trying to set the path for the
license file under `//brave`, rather than on the source. This change
redirects the license file to the common `Apache-2.0` license.
@wknapik wknapik merged commit 1177e90 into master Feb 19, 2025
17 of 18 checks passed
@wknapik wknapik deleted the update-to-chrono-0.4.39 branch February 19, 2025 03:48
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 19, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.52

kdenhartog pushed a commit that referenced this pull request Feb 19, 2025
@cdesouza-chromium @kdenhartog
[CodeHealth][rust] Update futures 0.3.27 => 0.3.31 (#27707)
aa3a365 
* [CodeHealth][rust] Update `futures` `0.3.27` => `0.3.31`

This PR updates the `futures` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change removes the previous `extra_src_roots` instructions for the
future deps, as those started panicking when running `gnrt` in the
current version.

`chrono` PR: #27693

Resolves brave/brave-browser#44057

* [CodeHealth][rust] Update `futures` `0.3.27` => `0.3.31`

This PR updates the `futures` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change contains all the files changed by `gnrt`.

`chrono` PR: #27693

Resolves brave/brave-browser#44057
kdenhartog pushed a commit that referenced this pull request Feb 19, 2025
@cdesouza-chromium @kdenhartog
[CodeHealth][rust] Update chrono-0.4.24 => chrono-0.4.39 (#27693)
b5e2429 
* [CodeHealth][rust] Update `chrono-0.4.24` => `chrono-0.4.39`

This PR updates `chrono` to version `0.4.39`. This is one of the steps
to eventually allow dropping `[email protected]`.

Updating this crate has run into issues with the list `remove_crates` in
`gnrt_config.toml`, which had to be updated to better match the upstream
version. Addional changes were necessary to correct failures around
license file paths for some of the crates affected.

Resolves brave/brave-browser#44035

* [CodeHealth][rust] Update `remove_crates` list with upstream

This list was not entirely matching the upstream one, which at first was
not a problem, but this has run into issues running `gnrt gen` once
`chrono` was updated. This change adds the missing `windows_*` crates
that belong to that list to the brave file.

* [CodeHealth][rust] Using a common `Apache-2.0` for some crates

For some reason some of these crates are trying to set the path for the
license file under `//brave`, rather than on the source. This change
redirects the license file to the common `Apache-2.0` license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver approved these changes

Assignees

@cdesouza-chromium cdesouza-chromium

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Milestone
1.77.x - Nightly
Development

Successfully merging this pull request may close these issues.

Update chrono crate
4 participants
@cdesouza-chromium @brave-builds @bridiver @wknapik