Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeHealth][rust] Update futures 0.3.27 => 0.3.31 #27707

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

cdesouza-chromium
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium commented Feb 18, 2025

This PR updates the futures crate to 0.3.31. This crate was causing audit failures on a different PR updating chrono.

chrono PR: #27693

Resolves brave/brave-browser#44057

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@cdesouza-chromium cdesouza-chromium self-assigned this Feb 18, 2025
@cdesouza-chromium cdesouza-chromium requested review from a team and bridiver as code owners February 18, 2025 12:43
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Feb 18, 2025
Copy link
Contributor

[puLL-Merge] - brave/brave-core@27707

Description

This PR downgrades the futures crate and its subcrates from version 0.3.31 to 0.3.27 in the third-party Rust dependencies. This appears to be part of maintaining compatibility with a specific version of the Chromium codebase's Rust dependencies.

Changes

Changes

The following crates were downgraded from 0.3.31 to 0.3.27:

  • futures
  • futures-channel
  • futures-core
  • futures-executor
  • futures-io
  • futures-macro
  • futures-sink
  • futures-task
  • futures-util

Changes involved:

  • Renaming directories to reflect new version numbers
  • Maintaining identical file content but under new version paths
  • Preserving all license and documentation files
  • Moving test files to match new directory structure

Note: This appears to be mostly a mechanical change to align version numbers rather than introducing functional changes, as the file contents remain identical between versions.```mermaid
sequenceDiagram
participant Old as Futures 0.3.31
participant New as Futures 0.3.27
Old->>New: Move source files
Old->>New: Move tests
Old->>New: Move documentation
Old->>New: Move licenses
Note over Old,New: Version downgrade with content preserved

</details>

<!-- Generated by claude-3-5-sonnet-20241022 -->

@cdesouza-chromium cdesouza-chromium changed the title [CodeHealth][rust] Update features 0.3.27 => 0.3.31 [CodeHealth][rust] Update futures 0.3.27 => 0.3.31 Feb 18, 2025
Copy link
Contributor

Chromium major version is behind target branch (133.0.6943.98 vs 134.0.6998.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
This PR updates the `futures` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change removes the previous `extra_src_roots` instructions for the
future deps, as those started panicking when running `gnrt` in the
current version.

`chrono` PR: #27693

Resolves brave/brave-browser#44057
This PR updates the `futures` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change contains all the files changed by `gnrt`.

`chrono` PR: #27693

Resolves brave/brave-browser#44057
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@mkarolin
Copy link
Collaborator

noplatform fails with unrelated js audit findings that have already been fixed in #27712

@mkarolin mkarolin merged commit e475ac9 into master Feb 19, 2025
17 of 18 checks passed
@mkarolin mkarolin deleted the update-to-futures-0.3.31 branch February 19, 2025 01:17
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 19, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.52

kdenhartog pushed a commit that referenced this pull request Feb 19, 2025
* [CodeHealth][rust] Update `futures` `0.3.27` => `0.3.31`

This PR updates the `futures` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change removes the previous `extra_src_roots` instructions for the
future deps, as those started panicking when running `gnrt` in the
current version.

`chrono` PR: #27693

Resolves brave/brave-browser#44057

* [CodeHealth][rust] Update `futures` `0.3.27` => `0.3.31`

This PR updates the `futures` crate to `0.3.31`. This crate was causing
audit failures on a different PR updating `chrono`.

This change contains all the files changed by `gnrt`.

`chrono` PR: #27693

Resolves brave/brave-browser#44057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update futures crate
4 participants