-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeHealth][rust] Update futures
0.3.27
=> 0.3.31
#27707
Conversation
[puLL-Merge] - brave/brave-core@27707 DescriptionThis PR downgrades the futures crate and its subcrates from version 0.3.31 to 0.3.27 in the third-party Rust dependencies. This appears to be part of maintaining compatibility with a specific version of the Chromium codebase's Rust dependencies. ChangesChangesThe following crates were downgraded from 0.3.31 to 0.3.27:
Changes involved:
Note: This appears to be mostly a mechanical change to align version numbers rather than introducing functional changes, as the file contents remain identical between versions.```mermaid
|
features
0.3.27
=> 0.3.31
futures
0.3.27
=> 0.3.31
35f8684
to
3235a6b
Compare
Chromium major version is behind target branch (133.0.6943.98 vs 134.0.6998.15). Please rebase. |
This PR updates the `futures` crate to `0.3.31`. This crate was causing audit failures on a different PR updating `chrono`. This change removes the previous `extra_src_roots` instructions for the future deps, as those started panicking when running `gnrt` in the current version. `chrono` PR: #27693 Resolves brave/brave-browser#44057
This PR updates the `futures` crate to `0.3.31`. This crate was causing audit failures on a different PR updating `chrono`. This change contains all the files changed by `gnrt`. `chrono` PR: #27693 Resolves brave/brave-browser#44057
3235a6b
to
803b09e
Compare
|
Released in v1.77.52 |
* [CodeHealth][rust] Update `futures` `0.3.27` => `0.3.31` This PR updates the `futures` crate to `0.3.31`. This crate was causing audit failures on a different PR updating `chrono`. This change removes the previous `extra_src_roots` instructions for the future deps, as those started panicking when running `gnrt` in the current version. `chrono` PR: #27693 Resolves brave/brave-browser#44057 * [CodeHealth][rust] Update `futures` `0.3.27` => `0.3.31` This PR updates the `futures` crate to `0.3.31`. This crate was causing audit failures on a different PR updating `chrono`. This change contains all the files changed by `gnrt`. `chrono` PR: #27693 Resolves brave/brave-browser#44057
This PR updates the
futures
crate to0.3.31
. This crate was causing audit failures on a different PR updatingchrono
.chrono
PR: #27693Resolves brave/brave-browser#44057
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: