Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 131 to Chromium 132. #26068

Draft
wants to merge 159 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
159 commits
Select commit Hold shift + click to select a range
3da1cd2
Update from Chromium 130.0.6723.58 to Chromium 131.0.6778.3.
cdesouza-chromium Sep 19, 2024
5dd99bd
Conflict-resolved patches from Chromium 130.0.6723.44 to Chromium 131…
cdesouza-chromium Sep 19, 2024
d8f8414
Updated strings for Chromium 131.0.6778.1.
cdesouza-chromium Oct 4, 2024
7fb2800
`gnrt` run for Chromium 131.0.6768.2.
cdesouza-chromium Sep 23, 2024
edbbdbe
`ShouldUseEphemeralStorage` passing a `optional_ref`
cdesouza-chromium Sep 19, 2024
9448f87
`WTF::String::CreateUninitialized` using out span.
cdesouza-chromium Sep 19, 2024
9a558e6
CrIconElement's updateIcon is now private.
mkarolin Sep 19, 2024
45446c2
Changes to SidePanel API.
mkarolin Sep 19, 2024
b18f488
TabSearchBubbleHost::ShowTabSearchBubble signature changed.
mkarolin Sep 19, 2024
d72c32d
InstallServiceWorkItem c'tor signature changed.
mkarolin Sep 19, 2024
4128ab9
Fixes keystone_app_name value collision.
mkarolin Sep 19, 2024
e329d9d
[Android] Use ServiceLoaderUtil with AppHooks
samartnik Sep 25, 2024
0c4cb9e
[Android] Draw edge to edge on NTP
samartnik Sep 25, 2024
ef6d3f4
[Android] Remove improved bookmarks feature flag and cleanup code
samartnik Sep 25, 2024
724ca10
[Android] Rename quickactionsearchwidget to shortcuts_widget
samartnik Sep 25, 2024
2100ff3
[Android] [C131] Fixes for bytecode tests
samartnik Sep 25, 2024
73edf9e
`ChromeMetricsServicesManagerClient` enabled checks removed
cdesouza-chromium Sep 23, 2024
e84c0db
Add `kPrivacyPolicyOnlineDarkModeURLPath` URL
cdesouza-chromium Sep 23, 2024
4ca92e6
`g_api_key_cache` now retrieved from factory function
cdesouza-chromium Sep 23, 2024
7c5ab85
`blink::DecodeURLEscapeSequences` takes `StringView`
cdesouza-chromium Sep 23, 2024
6f7788e
`//brave/browser/ui` depends on speedreader flags
cdesouza-chromium Sep 23, 2024
9f4f75d
`SidePanel::UpdateWidthOnEntryChanged` implentation
cdesouza-chromium Sep 23, 2024
0722f9b
`KURL::GetPath` returning `StringView`
cdesouza-chromium Sep 23, 2024
4f34de6
`BookmarkUndoServiceFactory` to be retrieved with Profile
cdesouza-chromium Sep 23, 2024
538a288
`google_api_keys-inc.cc` not to be reincluded
cdesouza-chromium Sep 24, 2024
94c227d
Patch `ApiKeyCache` with a substitution
cdesouza-chromium Sep 24, 2024
caeba12
`isolation_info` arg added to `HandleExternalProtocol`
cdesouza-chromium Sep 26, 2024
092801b
`RegisterEmbedderObservers` removed
cdesouza-chromium Sep 26, 2024
d63f5e2
`KURL::Host` returning `StringView`
cdesouza-chromium Sep 26, 2024
e96cf9c
Use `//chrome/browser/download`
cdesouza-chromium Sep 27, 2024
63ac60f
Use `chrome/browser/ui/hats`
cdesouza-chromium Sep 27, 2024
7b0345e
Update hermetic tool to SDK v15.0
cdesouza-chromium Sep 27, 2024
437bc2b
Premting `version_updater_mac.mm` `WrapUnique` replacement
cdesouza-chromium Sep 27, 2024
32ddb0f
[Android] Adopt ServiceLoaderUtil for LanguageProfileDelegate
samartnik Sep 27, 2024
4303869
[Android] Pad scrollable views in the hub
samartnik Sep 27, 2024
e1ed8dc
[Android] TaskRunner postTask -> execute rename
samartnik Sep 27, 2024
a189279
Revert "[Android] Rename quickactionsearchwidget to shortcuts_widget"
samartnik Sep 27, 2024
b33b3c4
[Android] Update a11y strings for toolbar TabSwitcherDrawable
samartnik Sep 27, 2024
86f80e3
[Android] Add basic search box layout for Hub
samartnik Sep 27, 2024
d0f4008
[install_static] Command line function refactored
cdesouza-chromium Sep 30, 2024
04e78e8
Fixing `brave_wayback_machine` dependency order
cdesouza-chromium Oct 1, 2024
342153a
Fixes SharedPinnedTabServiceBrowserTest.NewBrowser on Linux.
mkarolin Oct 1, 2024
ff06265
Update UserDataDir unit tests to follow upstream.
mkarolin Oct 1, 2024
37e3ba2
Revert "Fixing `brave_wayback_machine` dependency order"
cdesouza-chromium Oct 2, 2024
a82010f
`chrome` namespace removed from `incognito_helpers.h`
cdesouza-chromium Sep 26, 2024
c508785
`ProfilerThreadType` moved to `sampling_profile`
cdesouza-chromium Sep 26, 2024
33641e7
`chrome::` removed from `process_state.h`
cdesouza-chromium Sep 26, 2024
d4a891e
[rust] `syn` v1 deleted upstream
cdesouza-chromium Sep 26, 2024
6fbea67
[cr131] No patching needed for `syn/v1/BUILD.gn` in upstream
cdesouza-chromium Oct 10, 2024
53b476f
Static `AccountConsistencyModeManager::GetForProfile` deleted
cdesouza-chromium Sep 27, 2024
5969dcb
`PrepopulatedEngine` using span for arrays
cdesouza-chromium Sep 27, 2024
4863f76
[update_client] Observers events simplified
cdesouza-chromium Sep 30, 2024
417d073
`kDisabledRecentlyClosedHeaderCommandId` now a dynamic value
cdesouza-chromium Sep 30, 2024
c41fe6f
`TransportSecurityState::AddHSTSHeader` passing `string_view`
cdesouza-chromium Sep 30, 2024
e473383
Fix `BookmarkSubMenuModel` substitution failure
cdesouza-chromium Sep 30, 2024
ea9c192
`ClientHints` blink features made default
cdesouza-chromium Oct 2, 2024
3a9268b
[WIP] `omnibox` state flags deleted
cdesouza-chromium Oct 2, 2024
9967651
`SidePanel::HorizontalAlignment` now a scoped enum
cdesouza-chromium Oct 2, 2024
6a84dbd
`GetAllPrepopulatedEngines` returning a `span`
cdesouza-chromium Oct 2, 2024
257e29b
`SearchEngineChoiceService` added extra arg to ctor
cdesouza-chromium Oct 2, 2024
230eb6b
IWYU fix `absl::Cleanup`
cdesouza-chromium Oct 2, 2024
fde8dc4
Use `LoadDataResourceString` to unzip JSON
cdesouza-chromium Oct 2, 2024
dcfb4ed
`AccountsInCookieJarInfo` coverted into a `class`
cdesouza-chromium Oct 2, 2024
2cc6a69
Controller access encapsulated in `DataTypeManager`
cdesouza-chromium Oct 2, 2024
7b1e20c
`MigrateObsoleteBrowserStatePrefs` renamed
cdesouza-chromium Oct 2, 2024
80fddc9
[ios] Several `T::GetForBrowserState` deletions
cdesouza-chromium Oct 2, 2024
d71fe9e
`GetLastUsedProfileDeprecatedDoNotUse` removed
cdesouza-chromium Oct 2, 2024
132e187
[Android] Migrate LensControllerDelegate
samartnik Oct 3, 2024
1da4372
Disables crashing/failing upstream unit tests.
mkarolin Oct 3, 2024
ddce970
[Android] Adopt ServiceLoaderUtil for CustomizationProviderDelegate
samartnik Oct 3, 2024
9d6781c
[Android] Desktop windowing code moved from //chrome to //components
samartnik Oct 3, 2024
127e900
[Android] Adjustment to extending the omnibox suggestions when drawin…
samartnik Oct 3, 2024
d21aad4
//chrome/browser/content_settings was modularized.
mkarolin Oct 7, 2024
7d4a559
//chrome/browser/ui/prefs was modularized.
mkarolin Oct 7, 2024
39290b0
//chrome/browser/importer was modularized.
mkarolin Oct 7, 2024
c322437
//chrome/browser/ui/safety_hub was modularized.
mkarolin Oct 7, 2024
af607ef
//chrome/browser/ui/tabs was modularized.
mkarolin Oct 7, 2024
00dc8d0
[iOS] Credential now has creationDate method.
mkarolin Oct 7, 2024
ac844fd
c/b/android/signin moved to c/b/signin/android
mkarolin Oct 7, 2024
17ba7df
Removes obsolete override for generated_notification_pref_unittest.cc
mkarolin Oct 7, 2024
d8e1202
Removes obsolete override for companion_page_browsertest.cc.
mkarolin Oct 7, 2024
6274fd4
Java: replace assert (false); -> assert false;
mkarolin Oct 7, 2024
aa9d1fb
[iOS] HttpsUpgradeServiceFactory::GetForBrowserState was removed.
mkarolin Oct 8, 2024
0eaa4ea
[Android] Fixes for new lint warnings
samartnik Oct 8, 2024
fe41c30
[Android] Missing DEP for java unit tests
samartnik Oct 9, 2024
282cb60
Disables crashing/failing upstream browser tests.
mkarolin Oct 9, 2024
2c18701
[cr131] `visual_query` deleted in chromium
cdesouza-chromium Oct 3, 2024
6fdadde
[cr131] Forward declare missing `BookmarkModel`
cdesouza-chromium Oct 3, 2024
1d81efc
[cr131] `NotificationDisplayService::GetForProfile` relocated
cdesouza-chromium Oct 3, 2024
b1b1d3e
[cr131] Use `GaiaCookieManagerService::TriggerListAccounts`
cdesouza-chromium Oct 3, 2024
4301d3c
[cr131] Canvas passing winding as an enum
cdesouza-chromium Oct 4, 2024
75921cd
[cr131] Fix `nullptr` deref on `BookmarkMergedSurfaceService`
cdesouza-chromium Oct 6, 2024
cab14ff
[cr131] Add `ECDSA_SHA384` handling for `UnexportableKeyProvide`
cdesouza-chromium Oct 7, 2024
74e82fb
[cr131] Preempt `c/b/u/t/p/tab_features.h` substitutions
cdesouza-chromium Oct 8, 2024
af297c6
[cr131] `include_polymer.gni` deleted upstream
cdesouza-chromium Oct 8, 2024
5380da6
[cr131] `//chrome/browser/ui/hid` modularised
cdesouza-chromium Oct 10, 2024
4d5fa52
[cr131] `//chrome/browser/ui:url_identity` modularised
cdesouza-chromium Oct 10, 2024
fd0b8c3
[Android] Migrate LocaleManagerDelegate to ServiceLoaderUtil
samartnik Oct 10, 2024
636404a
[Android] Adopt ServiceLoaderUtil for SearchEngineCountryDelegate
samartnik Oct 10, 2024
0731e1f
[Android] Move base.cached_flags to components.cached_flags
samartnik Oct 10, 2024
55b1bc7
[Android] Moved `touch_to_fill_header_item.xml` file
samartnik Oct 10, 2024
e386aa2
[Android] Introduce an empty ToolbarLongPressMenuHandler
samartnik Oct 10, 2024
0589983
[Android] Add ToolbarPositionController
samartnik Oct 10, 2024
d40f925
[Android] Rename SettingsLauncher to SettingsNavigation
samartnik Oct 10, 2024
0bcfe41
[Android] Fixes for bytecode unit tests
samartnik Oct 11, 2024
08c6dbd
Refactor SidebarContainerView
cdesouza-chromium Oct 11, 2024
649f58c
NewTabUI was migrated to WebUIConfig.
mkarolin Oct 11, 2024
8f82de6
Formatting fix.
mkarolin Oct 11, 2024
590d158
[cr131] `kDevToolsConsoleInsights` moved into its own file
cdesouza-chromium Oct 9, 2024
aaf7144
[cr131] Add `kWallpaperSearchLearnMorePageURL` definition
cdesouza-chromium Oct 9, 2024
7a0bc33
[cr131] `AccountsInCookieJarInfo` ctor dropped one arg
cdesouza-chromium Oct 9, 2024
8178e6f
[cr131] `kTabNotFoundError` under `ExtensionTabUtil` now
cdesouza-chromium Oct 10, 2024
9c9614a
[cr131] Reanchor `InfobarView` override
cdesouza-chromium Oct 10, 2024
ca99200
[cr131] `kTabOrganizationLearnMorePageURL` impl added
cdesouza-chromium Oct 10, 2024
d679924
[cr131] `//chrome/browser/devtools` for `devtools/features.h`
cdesouza-chromium Oct 10, 2024
be7ca75
[Android] Fixes for lint new warnings
samartnik Oct 14, 2024
1b83069
[Android] Fix for unused private tab resource
samartnik Oct 14, 2024
4845310
[Android] Fix UnusedVariable Error Prone warnings in //chrome/browser
samartnik Oct 14, 2024
722379b
[Android] Split TabModelFilter into interface
samartnik Oct 14, 2024
ef28e69
[Android] Password settings crash fix
samartnik Oct 14, 2024
a1afb9c
[Android] kDevToolsConsoleInsights is not available on Android
samartnik Oct 14, 2024
3f3998f
[Android] Fixes for bytecode unit tests
samartnik Oct 14, 2024
1677203
[cr131][ios] `ChromeBrowserState` deleted
cdesouza-chromium Oct 14, 2024
79bb0ab
[cr131][ios] Add `share_kit` provider
cdesouza-chromium Oct 14, 2024
be8e0ea
SettingsUI was migrated to WebUIConfig.
mkarolin Oct 14, 2024
066426e
[cr131] `RefCountedBytes::TakeVector` deleted
cdesouza-chromium Oct 12, 2024
2b9eabf
[cr131] `TabSearchBubbleHost` requires `TabDeclutterController` arg
cdesouza-chromium Oct 12, 2024
6c2ae5e
[cr131] `DeriveKeyPbkdf2HmacSha256` to `kdf` interface
cdesouza-chromium Oct 12, 2024
aca30ba
[cr131] `Tab::set_group` => `Tab::SetGroup`
cdesouza-chromium Oct 14, 2024
c976941
[cr131] `kHistorySearchV2SettingURL` url impl
cdesouza-chromium Oct 14, 2024
4efaad3
[cr131] `kColorPageInfo*` constants renamed
cdesouza-chromium Oct 15, 2024
5b606ac
Add KDF implementations without CHECKs.
mkarolin Oct 16, 2024
f0d9ac7
Java formatting fixes.
mkarolin Oct 16, 2024
903fc74
[Android] Deprecate tab_groups package
samartnik Oct 16, 2024
25057d5
[Android] Changes for fetching bookmark favicons
samartnik Oct 16, 2024
88f1fc1
[Android] Add EdgeToEdgeStateProvider
samartnik Oct 16, 2024
8b9b284
[Android] Changes for UMA metrics
samartnik Oct 16, 2024
f465313
[Android] Fixes for the unit tests
samartnik Oct 16, 2024
d1bd842
Updates snapshots for notification ad popups.
mkarolin Oct 16, 2024
bfc3fa2
Disables flaky browser tests on Linux.
mkarolin Oct 16, 2024
88eff2f
Update patches from Chromium 130.0.6723.58 to Chromium 131.0.6778.3.
cdesouza-chromium Oct 16, 2024
16bfef3
Bumps resource_ids.spec starting id.
mkarolin Oct 16, 2024
1f3083b
Update from Chromium 130.0.6723.58 to Chromium 131.0.6778.4.
cdesouza-chromium Oct 16, 2024
db8ae32
Update from Chromium 131.0.6778.1 to Chromium 132.0.6779.1.
cdesouza-chromium Oct 16, 2024
b22407f
Conflict-resolved patches from Chromium 131.0.6778.1 to Chromium 132.…
cdesouza-chromium Oct 16, 2024
f30eec7
[cr132] `kPrivacySandboxProactiveTopicsBlocking` deleted
cdesouza-chromium Oct 16, 2024
7e24e4d
[cr132] IWYU additions
cdesouza-chromium Oct 16, 2024
6072f57
[cr132] `Configurator::EnabledDeltas` deleted
cdesouza-chromium Oct 16, 2024
67a142b
[REVERT ME BEFORE FIX] OnEntryWillDeregister deleted
cdesouza-chromium Oct 16, 2024
f311ea1
[cr132] Fix `unused variable` warning for `radii`
cdesouza-chromium Oct 16, 2024
569767b
[Android] OTR to [oO]tr in java code
AlexeyBarabash Oct 16, 2024
acae8d6
[Android] Removed AutocompleteMatch.mRelevance field
AlexeyBarabash Oct 16, 2024
340994c
fixup! [cr132] IWYU additions
cdesouza-chromium Oct 17, 2024
7585842
Revert "[REVERT ME BEFORE FIX] OnEntryWillDeregister deleted"
cdesouza-chromium Oct 17, 2024
4f4153d
Removed using SidePanelCoordinator::OnEntryWillDeregister
simonhong Oct 17, 2024
5dae4f5
Update patches from Chromium 131.0.6778.3 to Chromium 132.0.6779.1.
cdesouza-chromium Oct 17, 2024
149de94
Updated strings for Chromium 132.0.6779.1.
cdesouza-chromium Oct 17, 2024
9b44711
fixup! Removed using SidePanelCoordinator::OnEntryWillDeregister
cdesouza-chromium Oct 17, 2024
7403158
[cr132] `//chrome/browser/ui/javascript_dialogs` modularised
cdesouza-chromium Oct 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 0 additions & 6 deletions android/android_browser_tests.gni
Original file line number Diff line number Diff line change
Expand Up @@ -133,22 +133,16 @@ android_only_test_deps = [
"//brave/browser/partnercustomizations:delegate_public_impl_java",
"//brave/components/brave_wallet/browser:test_support",
"//brave/components/cosmetic_filters/browser:browser",
"//brave/components/language/android:java",
"//brave/third_party/android_deps:com_android_installreferrer_java",
"//chrome:chrome_android_core",
"//chrome/android:app_hooks_java",
"//chrome/android:delegate_public_impl_java",
"//chrome/browser/flags:flags_android",
"//chrome/browser/lens:delegate_public_impl_java",
"//chrome/browser/locale:delegate_public_impl_java",
"//chrome/browser/metrics:test_support",
"//chrome/test:android_browsertests_assets",
"//chrome/test:android_browsertests_java",
"//chrome/test:test_support",
"//chrome/test:test_support_ui_android",
"//components/browser_ui/widget/android:java",
"//components/externalauth/android:google_delegate_public_impl_java",
"//components/language/android:ulp_delegate_public_java",

# TODO(crbug.com/961849): This is needed for ShellManager which is what
# the ChromeBrowserTestsActivity is using to build the java UI. It's
Expand Down
4 changes: 2 additions & 2 deletions android/brave_java_sources.gni
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@ import("//brave/android/features/tab_ui/brave_tab_management_java_sources.gni")
import("//brave/android/feed/brave_feed_java_sources.gni")
import("//brave/android/java/org/chromium/chrome/browser/billing/sources.gni")
import("//brave/android/java/org/chromium/chrome/browser/playlist/sources.gni")
import("//brave/base/brave_base_cached_flags_java_sources.gni")
import("//brave/base/brave_base_shared_preferences_java.gni")
import("//brave/browser/brave_ads/android/java_sources.gni")
import("//brave/browser/hub/internal/android/java/java_sources.gni")
import("//brave/browser/incognito/android/java_sources.gni")
import("//brave/browser/share/android/java_sources.gni")
import("//brave/browser/tab_ui/android/brave_tab_ui_sources.gni")
import(
"//brave/components/cached_flags/brave_components_cached_flags_java_sources.gni")
import("//brave/components/embedder_support/android/java_sources.gni")
import("//brave/components/permissions/android/java_sources.gni")
import("//brave/components/safetynet/java_sources.gni")
Expand Down Expand Up @@ -539,7 +540,6 @@ brave_java_base_module_sources = [
]

brave_java_base_module_deps = [
"//brave/components/language/android:java",
"//brave/third_party/android_deps:com_wireguard_android_java",
"//third_party/androidx:androidx_core_core_java",
"//third_party/androidx:androidx_lifecycle_lifecycle_livedata_core_java",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@
import androidx.annotation.Nullable;

import org.chromium.base.BraveReflectionUtil;
import org.chromium.base.supplier.ObservableSupplier;
import org.chromium.base.supplier.OneshotSupplier;
import org.chromium.base.supplier.Supplier;
import org.chromium.chrome.browser.hub.ResourceButtonData;
import org.chromium.chrome.browser.incognito.reauth.IncognitoReauthController;
import org.chromium.chrome.browser.profiles.ProfileProvider;
import org.chromium.chrome.browser.tabmodel.TabModelFilter;
import org.chromium.chrome.browser.tabmodel.TabGroupModelFilter;
import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeController;
import org.chromium.chrome.browser.user_education.UserEducationHelper;
import org.chromium.chrome.tab_ui.R;

Expand All @@ -29,11 +31,12 @@ public BraveIncognitoTabSwitcherPane(
@NonNull Context context,
@NonNull OneshotSupplier<ProfileProvider> profileProviderSupplier,
@NonNull TabSwitcherPaneCoordinatorFactory factory,
@NonNull Supplier<TabModelFilter> incognitoTabModelFilterSupplier,
@NonNull Supplier<TabGroupModelFilter> incognitoTabModelFilterSupplier,
@NonNull OnClickListener newTabButtonClickListener,
@Nullable OneshotSupplier<IncognitoReauthController> incognitoReauthControllerSupplier,
@NonNull DoubleConsumer onToolbarAlphaChange,
@NonNull UserEducationHelper userEducationHelper) {
@NonNull UserEducationHelper userEducationHelper,
@NonNull ObservableSupplier<EdgeToEdgeController> edgeToEdgeSupplier) {
super(
context,
profileProviderSupplier,
Expand All @@ -42,7 +45,8 @@ public BraveIncognitoTabSwitcherPane(
newTabButtonClickListener,
incognitoReauthControllerSupplier,
onToolbarAlphaChange,
userEducationHelper);
userEducationHelper,
edgeToEdgeSupplier);

ResourceButtonData newReferenceButtonData =
new ResourceButtonData(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,14 @@

import androidx.annotation.NonNull;

import org.chromium.base.supplier.ObservableSupplier;
import org.chromium.base.supplier.OneshotSupplier;
import org.chromium.chrome.browser.hub.HubContainerView;
import org.chromium.chrome.browser.hub.HubLayoutAnimatorProvider;
import org.chromium.chrome.browser.profiles.ProfileProvider;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tasks.tab_management.TabListCoordinator.TabListMode;
import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeController;
import org.chromium.chrome.browser.user_education.UserEducationHelper;

import java.util.function.DoubleConsumer;
Expand All @@ -26,14 +28,16 @@ public abstract class BraveTabSwitcherPaneBase extends TabSwitcherPaneBase {
@NonNull TabSwitcherPaneCoordinatorFactory factory,
boolean isIncognito,
@NonNull DoubleConsumer onToolbarAlphaChange,
@NonNull UserEducationHelper userEducationHelper) {
@NonNull UserEducationHelper userEducationHelper,
@NonNull ObservableSupplier<EdgeToEdgeController> edgeToEdgeSupplier) {
super(
context,
profileProviderSupplier,
factory,
isIncognito,
onToolbarAlphaChange,
userEducationHelper);
userEducationHelper,
edgeToEdgeSupplier);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -503,20 +503,6 @@
The price of this item recently dropped from <ph name="PREVIOUS_PRICE">%1$s<ex>$42</ex></ph> to <ph name="NEW_PRICE">%2$s<ex>$30</ex></ph>
</message>

<!-- Price Alerts Card strings -->
<message name="IDS_PRICE_DROP_ALERTS_CARD_TITLE" desc="This text shows on the price drop alerts message card if any item in the open tabs has a price drop. It familiarizes users with the feature getting price drop alerts.">
Get alerts for price drops?
</message>
<message name="IDS_PRICE_DROP_ALERTS_CARD_GET_NOTIFIED_CONTENT" desc="This text shows below 'Get alerts for price drops?'. It describes what will happen when clicking 'Get notified' button.">
You'll get an alert when there's a lower price in an open tab
</message>
<message name="IDS_PRICE_DROP_ALERTS_CARD_GET_NOTIFIED" desc="This text button shows below 'Get alerts for price drops?'. When user clicks on the text button, the price drop notifications feature will be turned on.">
Get notified
</message>
<message name="IDS_PRICE_DROP_ALERTS_CARD_GO_TO_SETTINGS_CONTENT" desc="This text shows below 'Get alerts for price drops?'. It asks users to turn on notifications in Android settings to get the price drop notifications.">
To get an alert when there's a lower price in an open tab, turn on notifications in Settings.
</message>

<!-- Price Tracking Settings Dialog strings -->
<message name="IDS_TRACK_PRICES_ON_TABS" desc="This text shows in the price tracking settings dialog. It tells users the switch on the side can be used to turn on/off the 'Track prices on tabs' feature.">
Track prices on tabs
Expand Down Expand Up @@ -803,6 +789,9 @@
<message name="IDS_OPEN_NEW_TAB_IN_GROUP_CONTEXT_MENU_ITEM" desc="Menu item text which will be display for tab group context menu on strip to allow opening a new tab in the tab group.">
New tab in group
</message>
<message name="IDS_SHARE_TAB_GROUP_CONTEXT_MENU_ITEM" desc="Menu item text which will be display for tab group context menu on strip to allow sharing a tab group.">
Share group
</message>
<message name="IDS_TAB_GROUP_RENAME_DIALOG_TITLE" desc="When users edit an existing tab group, a dialog will pop up and this text is the title of that dialog. [CHAR_LIMIT=24]">
Rename tab group
</message>
Expand Down Expand Up @@ -832,17 +821,39 @@
<message name="IDS_CLOSE_FROM_GROUP_DIALOG_TITLE" desc="Title of a dialog asking if the user really wants to close a tab and group.">
Close tab and delete group?
</message>
<message name="IDS_KEEP_TAB_GROUP_DIALOG_TITLE" desc="Title of a dialog asking the user if they want to keep the tab group.">
Keep tab group?
</message>
<message name="IDS_KEEP_TAB_GROUP_DIALOG_DESCRIPTION_OWNER" desc="Main text content of a dialog asking the owner of a shared group if they want to keep it. The &#10; is a newline character to force formatting.">
Keep this group to add tabs later, or delete it if you no longer need it.

If you delete it, everyone will immediately lose access to the "<ph name="TITLE_OF_GROUP">%1$s<ex>Shopping cart</ex></ph>" tab group, and it will be deleted from all devices.
</message>
<message name="IDS_KEEP_TAB_GROUP_DIALOG_DESCRIPTION_MEMBER" desc="Main text content of a dialog asking a member of a shared group if they want to keep it or leave. The &#10; is a newline character to force formatting.">
Keep this group to add tabs later, or leave.

If you leave, you will immediately lose access to the "<ph name="TITLE_OF_GROUP">%1$s<ex>Shopping cart</ex></ph>" tab group.
</message>
<message name="IDS_KEEP_TAB_GROUP_DIALOG_KEEP_ACTION" desc="Action button to keep the tab group in the keep group dialog.">
Keep group
</message>
<message name="IDS_KEEP_TAB_GROUP_DIALOG_DELETE_ACTION" desc="Action button for the owner of a group to delete the tab group in the keep group dialog.">
Delete group
</message>
<message name="IDS_KEEP_TAB_GROUP_DIALOG_LEAVE_ACTION" desc="Action button for a member of a group to leave the tab group in the keep group dialog.">
Leave group
</message>
<message name="IDS_CLOSE_TAB_GROUP_MENU_ITEM" desc="Menu item text which will prompt a confirmation dialog to close a tab group.">
Close
</message>
<message name="IDS_RENAME_TAB_GROUP_MENU_ITEM" desc="Menu item text which will prompt a confirmation dialog to rename a tab group.">
Rename
</message>
<message name="IDS_ACCESSIBILITY_OPEN_TAB_GROUP_OVERFLOW_MENU_WITH_GROUP_NAME" desc="Accessibility string for opening the overflow menu on a tab group, which will allow the user to perform several actions on the tab group. TITLE_OF_GROUP is the title of the group.">
Open the tab group action menu for tab group <ph name="TITLE_OF_GROUP">%1$s<ex>Shopping cart</ex></ph>
<message name="IDS_ACCESSIBILITY_OPEN_TAB_GROUP_OVERFLOW_MENU_WITH_GROUP_NAME_WITH_COLOR" desc="Accessibility string for opening the overflow menu on a tab group, which will allow the user to perform several actions on the tab group. TITLE_OF_GROUP is the title of the group. COLOR_NAME is the color of the group.">
Open the tab group action menu for tab group <ph name="TITLE_OF_GROUP">%1$s<ex>Shopping cart</ex></ph>, color <ph name="COLOR_NAME">%2$s<ex>Blue</ex></ph>.
</message>
<message name="IDS_ACCESSIBILITY_OPEN_SHARED_TAB_GROUP_OVERFLOW_MENU_WITH_GROUP_NAME" desc="Accessibility string for opening the overflow menu on a shared tab group, which will allow the user to perform several actions on the tab group. TITLE_OF_GROUP is the title of the group.">
Open the tab group action menu for shared tab group <ph name="TITLE_OF_GROUP">%1$s<ex>Shopping cart</ex></ph>
<message name="IDS_ACCESSIBILITY_OPEN_SHARED_TAB_GROUP_OVERFLOW_MENU_WITH_GROUP_NAME_WITH_COLOR" desc="Accessibility string for opening the overflow menu on a shared tab group, which will allow the user to perform several actions on the tab group. TITLE_OF_GROUP is the title of the group. COLOR_NAME is the color of the group.">
Open the tab group action menu for shared tab group <ph name="TITLE_OF_GROUP">%1$s<ex>Shopping cart</ex></ph>, color <ph name="COLOR_NAME">%2$s<ex>Blue</ex></ph>.
</message>
<message name="IDS_CLOSE_FROM_GROUP_DESCRIPTION" desc="Description of the action of deleting a tab and a group, shown in a confirmation dialog.">
This will delete the group from all devices signed into <ph name="USER_EMAIL">%1$s<ex>[email protected]</ex></ph>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.share.ShareDelegate;
import org.chromium.chrome.browser.toolbar.top.Toolbar;
import org.chromium.chrome.browser.ui.edge_to_edge.EdgeToEdgeController;
import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager;
import org.chromium.components.browser_ui.bottomsheet.BottomSheetController;
import org.chromium.ui.UiUtils;
Expand Down Expand Up @@ -58,7 +59,8 @@ public BraveFeedSurfaceCoordinator(
boolean overScrollDisabled,
@Nullable ViewGroup viewportView,
FeedActionDelegate actionDelegate,
@NonNull ObservableSupplier<Integer> tabStripHeightSupplier) {
@NonNull ObservableSupplier<Integer> tabStripHeightSupplier,
ObservableSupplier<EdgeToEdgeController> edgeToEdgeControllerSupplier) {
super(
activity,
snackbarManager,
Expand All @@ -81,7 +83,8 @@ public BraveFeedSurfaceCoordinator(
overScrollDisabled,
viewportView,
actionDelegate,
tabStripHeightSupplier);
tabStripHeightSupplier,
edgeToEdgeControllerSupplier);
}

public void createFrameLayoutForPolicy() {
Expand Down
24 changes: 7 additions & 17 deletions android/java/apk_for_test.flags
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@
public <init>(...);
}

-keep class org.chromium.chrome.browser.settings.SettingsLauncherImpl {
-keep class org.chromium.chrome.browser.settings.SettingsNavigationImpl {
<init>(...);
}

Expand Down Expand Up @@ -591,7 +591,7 @@
*** get(...);
}

-keep class org.chromium.chrome.browser.partnercustomizations.CustomizationProviderDelegateImpl {
-keep class org.chromium.chrome.browser.partnercustomizations.CustomizationProviderDelegateUpstreamImpl {
public <init>(...);
}

Expand Down Expand Up @@ -645,20 +645,20 @@
public <init>(...);
}

-keep class org.chromium.chrome.browser.AppHooksImpl {
-keep class org.chromium.chrome.browser.AppHooks {
public <init>(...);
}

-keep class org.chromium.chrome.browser.BraveAppHooks {
public <init>(...);
}

-keep class org.chromium.base.cached_flags.CachedFlag {
-keep class org.chromium.components.cached_flags.CachedFlag {
*** mDefaultValue;
<init>(...);
}

-keep class org.chromium.base.cached_flags.BraveCachedFlag {
-keep class org.chromium.components.cached_flags.BraveCachedFlag {
<init>(...);
}

Expand Down Expand Up @@ -745,12 +745,12 @@
public <init>(...);
}

-keep class org.chromium.chrome.browser.tasks.tab_groups.TabGroupModelFilter {
-keep class org.chromium.chrome.browser.tabmodel.TabGroupModelFilterImpl {
*** mIsResetting;
public <init>(...);
}

-keep class org.chromium.chrome.browser.tasks.tab_groups.BraveTabGroupModelFilter {
-keep class org.chromium.chrome.browser.tabmodel.BraveTabGroupModelFilter {
public <init>(...);
}

Expand Down Expand Up @@ -791,16 +791,6 @@
public <init>(...);
}

-keep class org.chromium.components.language.LocaleManagerDelegateImpl {
public <init>(...);
*** getApplicationLocale(...);
*** setApplicationLocale(...);
}

-keep class org.chromium.components.language.BraveLocaleManagerDelegateImpl {
public <init>(...);
}

-keep class org.chromium.chrome.browser.compositor.layouts.ToolbarSwipeLayout {
public <init>(...);
*** mMoveToolbar;
Expand Down
14 changes: 7 additions & 7 deletions android/java/org/chromium/base/BraveReflectionUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,14 @@ public static Object invokeMethod(
return toInvoke.invoke(obj, args);
} catch (IllegalAccessException e) {
Log.e(TAG, "Illegal access for method: " + e);
assert (false);
assert false;
} catch (InvocationTargetException e) {
Log.e(TAG, "Method invocation error e: " + e);
assert (false);
assert false;
}
} catch (NoSuchMethodException e) {
Log.e(TAG, "Method not found: " + e);
assert (false);
assert false;
}
return null;
}
Expand All @@ -59,10 +59,10 @@ public static Object getField(Class ownerClass, String fieldName, Object obj) {
return field.get(obj);
} catch (NoSuchFieldException e) {
Log.e(TAG, "Field not found: " + e);
assert (false);
assert false;
} catch (SecurityException | IllegalArgumentException | IllegalAccessException e) {
Log.e(TAG, "Get field failed: " + e);
assert (false);
assert false;
}
return null;
}
Expand All @@ -74,10 +74,10 @@ public static void setField(Class ownerClass, String fieldName, Object obj, Obje
field.set(obj, newValue);
} catch (NoSuchFieldException e) {
Log.e(TAG, "Field not found: " + e);
assert (false);
assert false;
} catch (SecurityException | IllegalArgumentException | IllegalAccessException e) {
Log.e(TAG, "Get field failed: " + e);
assert (false);
assert false;
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import org.chromium.chrome.browser.partnerbookmarks.PartnerBookmark;

public class BraveAppHooks extends AppHooksImpl {
public class BraveAppHooks extends AppHooks {
@Override
public PartnerBookmark.BookmarkIterator getPartnerBookmarkIterator() {
return null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,17 +81,17 @@ public String call() {
}

private static String getUrlForCustomTab(Intent intent) {
assert (false);
assert false;
return null;
}

private static String getUrlForWebapp(Intent intent) {
assert (false);
assert false;
return null;
}

private static boolean isJavascriptSchemeOrInvalidUrl(String url) {
assert (false);
assert false;
return false;
}
}
Loading
Loading