Upgrade from Chromium 131 to Chromium 132. #26068
Draft
+72,676
−3,738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`top_frame_origin` is not being passed as a reference to an optional anymore, as that can lead to unwanted copies. This change corrects our overrides to that function to match the signature upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/eeda933c994ab5e0e9612bc695b78e38231a8bd1 commit eeda933c994ab5e0e9612bc695b78e38231a8bd1 Author: Chris Fredrickson <[email protected]> Date: Tue Sep 17 14:06:47 2024 +0000 Use base::optional_ref<T> instead of std::optional<T>& std::optional<T> is a value that might absent, whereas base::optional_ref<T> is a reference that might be absent. Thus, use of std::optional<T> results in an unnecessary copy when implicitly converting from a T&; base::optional_ref avoids that copy. (A function parameter of type base::optional_ref<T> is similar to a parameter of type T*, except that the base::optional_ref allows the use of temporaries.) Change-Id: Ib627b18105e6a6d18d892f4731f5049b183a9df0
With the use of span as an outparam, it becomes possible to better iterate over the items. Chromium change: https://chromium.googlesource.com/chromium/src/+/b3255fdcb98caf809e094ff2016930f8abf96e74 commit b3255fdcb98caf809e094ff2016930f8abf96e74 Author: Fredrik Söderquist <[email protected]> Date: Tue Sep 17 00:16:36 2024 +0000 spanification: WTF::String::CreateUninitialized() Forward to the span<> variant on StringImpl. Bug: 351564777
Chromium change: https://source.chromium.org/chromium/chromium/src/+/924617d4a513876f7cf0097d073a037d08b9eb31 commit 924617d4a513876f7cf0097d073a037d08b9eb31 Author: dpapad <[email protected]> Date: Tue Sep 17 17:57:45 2024 +0000 Settings: Replace remaining <iron-icon src=...> usages with cr-icon. `src=...` is not supported by cr-icon. In order to accommodate, using an <img> element directly when `src=...` is needed (in both cases it was done to display throbber_small.svg). Bug: 40943652
Chromium changes: https://source.chromium.org/chromium/chromium/src/+/1ed8db05a7a2c2affbff615d8aaea759ac87bade commit 1ed8db05a7a2c2affbff615d8aaea759ac87bade Author: Erik Chen <[email protected]> Date: Tue Sep 17 07:31:34 2024 +0000 Reduce fragility in SidePanelCoordinator (part 7 / N) This CL is a refactor with no intended user-visible impact. This CL deletes the view property SidePanelContentState. This is only read by SidePanel and only set by SidePanelCoordinator. By removing the view property we remove an unnecessary layer of indirection. This is replaced by Open and Close methods on SidePanel which SidePanelCoordinator calls. This CL adds a state member to SidePanel to track and expose the internal state machine. State is one of: kClosed, kOpening, kOpen, kClosing. SidePanelCoordinator is the only entity that should be controlling visibility of SidePanel. All other calls to UpdateVisibility() were removed. These calls appear to be side effects of relying of view-properties to propagate state changes. Bug: 363743081 https://source.chromium.org/chromium/chromium/src/+/31a977c143b574bc9d85e1979e2483b3369daf54 commit 31a977c143b574bc9d85e1979e2483b3369daf54 Author: Erik Chen <[email protected]> Date: Wed Sep 18 04:28:39 2024 +0000 Reduce fragility in SidePanelCoordinator (part 9 / N) This CL is a refactor with no intended behavior change. This CL moves the class SidePanelContentSwappingContainer from SidePanelCoordinator to SidePanel. Bug: 363743081
Chromium change: https://source.chromium.org/chromium/chromium/src/+/2646de6874e08c0da01754b72486c29a01cdedd1 commit 2646de6874e08c0da01754b72486c29a01cdedd1 Author: Emily Shack <[email protected]> Date: Tue Sep 17 22:09:42 2024 +0000 Declutter: Allow opening to a specific feature Adds a profile pref for the feature the tab organization tab within the tab search bubble should display when opened. This follows the pattern used for opening the bubble to a specific tab. For now, this is used by auto tab groups entry points to bypass the selector. Future use cases such as the chip and any other new entrypoints will similarly be able to open the bubble directly to declutter. Bug: 366236403
Chromium change: https://source.chromium.org/chromium/chromium/src/+/7a7f7387efa2e2a34fe41cbef79a6f7660ce3328 commit 7a7f7387efa2e2a34fe41cbef79a6f7660ce3328 Author: S. Ganesh <[email protected]> Date: Tue Sep 17 17:18:44 2024 +0000 Add the ability to set a description for the InstallServiceWorkItem Bug: 343638931
On MacOS/iOS:
ERROR at //chrome/updater/mac/BUILD.gn:13:1: Value collision.
import("//chrome/updater/branding.gni")
^-------------------------------------
This import contains "keystone_app_name"
See //brave/chromium_src/chrome/updater/branding.gni:18:23: defined here.
keystone_app_name = "BraveSoftwareUpdate"
^--------------------
Which would clobber the one in your current scope
See //chrome/enterprise_companion/branding.gni:32:23: defined here.
keystone_app_name = "ChromiumSoftwareUpdate"
^-----------------------
Executing import should not conflict with anything in the current
scope unless the values are identical.
See //chrome/updater/BUILD.gn:23:14: which caused the file to be included.
deps = [ "//chrome/updater/mac" ]
^---------------------
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/bd96319778e6f280a4915b29f1ca16c16d6f00af
commit bd96319778e6f280a4915b29f1ca16c16d6f00af
Author: Noah Rose Ledesma <[email protected]>
Date: Tue Aug 6 21:41:11 2024 +0000
Create pkg installer for MacOS
Add a build rule which creates a pkg installer for MacOS. The pkg
installer copies the application bundle to a staging directory (adj. to
the installation), and runs the enterprise_companion binary with the
install flag, akin to O4's installer.
Behind the install flag, the logic for Linux's installer is now shared
with Mac to simply copy the executable to the install directory and
configure permissions.
Finally, a new integration test target was added to provide coverage of
this installation experience. Integration tests are distinct from unit
tests in that they will require root/admin privileges.
Bug: 344878963
Chromium change: https://source.chromium.org/chromium/chromium/src/+/21849f23ddc564a43b12c209f88cb96621c21040 Use ServiceLoaderUtil with AppHooks Bug: 40901855
Chromium change: brave/chromium@102fef6 [E2E] Draw edge to edge on NTP Use SimpleEdgeToEdgePadAdjuster to pad the feed recycler view on NTP to allow the page draw to edge. Preview: https://screenshot.googleplex.com/95y7x9RMgfXUbJw https://screenshot.googleplex.com/9nRKDBmVSZcJQFG Dark: https://screenshot.googleplex.com/5reX99dKKBFP2sQ https://screenshot.googleplex.com/3pKbxh2Xmbcuram Bug: 339025702
Chromium change: https://source.chromium.org/chromium/chromium/src/+/bec7878b1af9336b7d8ccf6926b6bf28ba658645 [bookmarks] Remove improved bookmarks feature flag and cleanup code Bug: 326237392
Chromium change: https://source.chromium.org/chromium/chromium/src/+/553ab217c7738507c2f5f969c388d82fcae375ab Rename quickactionsearchwidget to shortcuts_widget Change-Id: Ie8dbecd297925950e6a0a0da7c20e74b679383d3
Checks for whether or not metrics reporting are enabled have been removed entirely from `ChromeMetricsServicesManagerClient`, and are now retrieved straight from `ChromeEnabledStateProvider::IsReportingEnabled`. Chromium change: https://chromium.googlesource.com/chromium/src/+/bde3b49864827b605bec6ed246a785cbd252c2cd commit bde3b49864827b605bec6ed246a785cbd252c2cd Author: Alexei Svitkine <[email protected]> Date: Wed Sep 18 15:32:57 2024 +0000 Remove an extra layer of indirection for checking metrics state. This paves the way for additional clean ups. Bug: 367328884
This url is the darkmode URL for `kPrivacyPolicyOnlineURLPath`, which is also not supported. Chromium change: https://chromium.googlesource.com/chromium/src/+/811078c4cf232b15805a2edba21f90655d387af2 commit 811078c4cf232b15805a2edba21f90655d387af2 Author: Christine Ying <[email protected]> Date: Thu Sep 19 16:25:02 2024 +0000 [PrivacyPolicy] Add dark mode support to privacy policy page dark mode screencast: https://screencast.googleplex.com/cast/NjY0OTk2NTA1MTkwNDAwMHw0ODExNTQ3MS03Zg light mode screencast: https://screencast.googleplex.com/cast/NTIzMzYxNjc0MDE1NTM5MnxmNmNkNjk5Ni1kNg Change-Id: Ife38de38796a988fdfa334a8ef9335c621673c42 Bug: 365867510
This is an upstream change to allow contructor args to be passed to this instance. Chromium change: https://chromium.googlesource.com/chromium/src/+/2a1062d25522ebdb3397ad2104110dab7935ae79 commit 2a1062d25522ebdb3397ad2104110dab7935ae79 Author: Alex Ilin <[email protected]> Date: Wed Sep 18 16:25:37 2024 +0000 [google_apis] Replace LazyInstance with a static local variable Store APIKeyCache in a static local variable instead of base::LazyInstance. This will allow adding a constructor parameter to APIKeyCache. Bug: 367764868
Chromium change: https://chromium.googlesource.com/chromium/src/+/1f49958fa6c8dff699904d2b1fd1f74352d45ec2 commit 1f49958fa6c8dff699904d2b1fd1f74352d45ec2 Author: Dave Tapuska <[email protected]> Date: Thu Sep 19 19:39:37 2024 +0000 Change encoding/decoding methods to take a StringView Update methods to operate on a StringView instead of a String. Bug: 366411876
This seems to have been working incidentally, but recently CI issues have shown up in canary.
Chromium change: https://chromium.googlesource.com/chromium/src/+/a2bc8fa9487a475b3151c00bad9aafffb332ba49 commit a2bc8fa9487a475b3151c00bad9aafffb332ba49 Author: Jingqi Sun <[email protected]> Date: Sat Sep 21 06:37:06 2024 +0000 [SidePanel] Encapsulate width preference logic in SidePanel constructor This CL introduces a new method in the SidePanel class to centralize the width preference logic. This ensures that the user-specific configurations are consistently applied whenever a side panel is initialized. Bug: 357101118
`StringView` doesn't have a `StartsWith` member. Chromium changes: https://chromium.googlesource.com/chromium/src/+/a0c53ad73b71beafe9dbd51165b728717752aa6f commit a0c53ad73b71beafe9dbd51165b728717752aa6f Author: Dave Tapuska <[email protected]> Date: Fri Sep 20 19:24:27 2024 +0000 [kURL] Change GetPath to return a StringView Return StringView as returning a String can be a footgun for allocations. Eventually I'll move all properties on KURL to StringViews (this matches what Webkit did for their KURL fork). Bug: 366411876
This is part of an ongoing upstream rewrite to have these services returned by a profile instance. Chromium change: https://chromium.googlesource.com/chromium/src/+/860e3ec83a29a2e5e7c148de24a9eaba3e43ae63 commit 860e3ec83a29a2e5e7c148de24a9eaba3e43ae63 Author: Aliona DANGLA <[email protected]> Date: Tue Sep 17 09:10:29 2024 +0000 [iOS] Updates files under ios/chrome/browser/bookmarks This CL replaces: * ChromeBrowserState => ProfileIOS * GetBrowserState => GetProfile * browser_state => profile * browserState => profile * GetOriginalChromeBrowserState => GetOriginalProfile * HasOffTheRecordChromeBrowserState => HasOffTheRecordProfile * GetOffTheRecordChromeBrowserState => GetOffTheRecordProfile * DestroyOffTheRecordChromeBrowserState => DestroyOffTheRecordProfile web::BrowserState code is not updated. Fixed: 365526102
This affects the path for the shadow file we have in place for insertion. Chromium change: https://chromium.googlesource.com/chromium/src/+/c8f909854f462aeaf91943193016f704a00da9ab commit c8f909854f462aeaf91943193016f704a00da9ab Author: Alex Ilin <[email protected]> Date: Mon Sep 23 14:09:40 2024 +0000 [google-apis] Stop re-including google_api_keys-inc.cc in tests Instead of including google_api_keys-inc.cc multiple times in the tests, we can now construct ApiKeyCache instance in a test and re-assign the global pointer to it. Bug: 367764868
`ApiKeyCache` now has its own header, which allows us to use a shadow file to patch its content. Chromium change: https://chromium.googlesource.com/chromium/src/+/af38c47054c98d03e51b20cfd50e3565f925acd2 commit af38c47054c98d03e51b20cfd50e3565f925acd2 Author: Alex Ilin <[email protected]> Date: Mon Sep 23 13:59:57 2024 +0000 [google_apis] Move ApiKeyCache into a separate file Move ApiKeyCache to a separate file that is included *only once*. Bug: 367764868
This argument is just passed along with all others to the `ChromeContentBrowserClient` method. Chromium change: https://chromium.googlesource.com/chromium/src/+/3585abaa071f83fdcbf097abe7833d42d3744963 commit 3585abaa071f83fdcbf097abe7833d42d3744963 Author: Rupert Ben Wiser <[email protected]> Date: Tue Sep 24 02:58:41 2024 +0000 Add IsolationInfo for embedders handling external protocols WebView lets app developers intercept calls when an external protocol is involved. We'd like to make it clear to those developers what context the request came from. This will just be ignored by other embedders. Bug: 356891482
This change replaces `RegisterEmbedderObservers` with a refactored `RegisterObservers` in its place, and has no behavioural effect. Chromium change: https://chromium.googlesource.com/chromium/src/+/f5327eed5ae54047e2c0e31485777caa34d6d227 commit f5327eed5ae54047e2c0e31485777caa34d6d227 Author: Keren Zhu <[email protected]> Date: Tue Sep 24 20:42:27 2024 +0000 [PLM] refactor metrics embedder to prepare for adding metrics for NTP This change refactors the page load metrics embedder classes to prepare for the addition of a new observer specific to the New Tab Page (NTP). The following changes were made: - `RegisterObservers()` is refactored to accept a `NavigationHandle` argument. This allows page-specific observers to be registered based on the navigated URL. - Remove `RegisterEmbedderObservers` to give embedder subclasses direct control over observer registration. Subclasses can now choose to register common observers by calling their parent's `RegisterObservers` method. This removes the need for special case handling (Side Search, non-tab WebUI and soon NTP) within the base class. - add a placeholder within the `RegisterObservers` method to conditionally register the future NTP-specific observer. This change has no behavioral change. Bug: 365784990
This change has run into build errors because `StringView` doesn't offer a `StartsWith` method. Additionaly, in a generic context where `T::Host` is called, for types like `SecurityOrigin `, `Host` still return `String`, which has to be reconciled with the `KURL` case. Chromium change: https://chromium.googlesource.com/chromium/src/+/55f1e9efbe0c4c1dd9d53da37f030c0041c34591 commit 55f1e9efbe0c4c1dd9d53da37f030c0041c34591 Author: Dave Tapuska <[email protected]> Date: Mon Sep 23 18:46:26 2024 +0000 [kURL] Change GetHost to return a StringView Return StringView as returning a String can be a footgun for allocations. Eventually I'll move all properties on KURL to StringViews (this matches what Webkit did for their KURL fork). Collapse GetHost and GetHostView into one function. Bug: 366411876
This target has been introduced breaking away some of the download code from `//chrome/browser`. Chromium change: https://chromium.googlesource.com/chromium/src/+/8231ebef6aab18268734156dada635b087a51b2e commit 8231ebef6aab18268734156dada635b087a51b2e Author: Antonio Gomes <[email protected]> Date: Tue Sep 24 08:21:41 2024 +0000 Build more files as part of //c/b/download:download GN target ... namely, download_ui_model.h and download_commands.h. These files are included by headers in //c/b/ui/download/ and today build as part of //c/b:b GN target. Hence, modularizing this //c/b/ui/download would cause circular dependencies with //c/b/. [email protected] Bug: 368831367
Follow up issues exist/created: * brave/brave-browser#29631 * brave/brave-browser#41674
Chromium's last id went up again and was conflicting with our ids (specifically on MacOS causing a crash constructing Help menu).
This flag was already entirely gutted, so it was no-op. Chromium change: https://chromium.googlesource.com/chromium/src/+/7481666f1005dfd844d7f31d95f353b0a48000b7 commit 7481666f1005dfd844d7f31d95f353b0a48000b7 Author: Kene Okoye <[email protected]> Date: Tue Oct 15 16:30:42 2024 +0000 [PS] ProactiveTopicsEnabled: Remove ProactiveTopicsBlocking flag Bug: 356411190
This must be due to some transient inclusion changing.
This function wasn't even being used in upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/1911cb516aaf7a32618101b968ba9ad339c18632 commit 1911cb516aaf7a32618101b968ba9ad339c18632 Author: Joshua Pawlicki <[email protected]> Date: Tue Oct 15 15:41:56 2024 +0000 update_client: Remove EnabledDeltas from Configurator. This function is no longer ever called. Bug: 353249967
Chromium change: https://chromium.googlesource.com/chromium/src/+/6dd962b30f8540dcbdd48a31e5b51f788924ff21 commit 6dd962b30f8540dcbdd48a31e5b51f788924ff21 Author: Erik Chen <[email protected]> Date: Tue Oct 15 22:02:41 2024 +0000 Reduce fragility in SidePanelCoordinator (part 15 / N) This CL simplifies registration and deregistration of side panel entries. The SidePanelRegistry now has logic that checks if an entry that is about to be deregistered is showing. If so, it synchronously closes the side panel. All other logic coupling registration/deregistration with showing/closing the side panel was removed. This logic was spread across several files but was only intended for extensions. User visible side-effects: * If an active tab-scoped entry is deregistered, the side panel will close as opposed to falling back to the window-scoped side panel. This change intentionally makes the deregister flow identical to the close flow. * Registering a tab-scoped entry will have no effect on the currently showing side panel. Previously, if a window-scoped entry with the same key was showing, the side panel would switch to the tab-scoped entry. * Disabling the tab-scoped side panel for a tab no longer prevents the window-scoped side panel for showing on that tab. Non user-visible side effects: * Many tests are no longer necessary as the new behavior is simpler. * The mechanism to get the cached view from a deregistered entry is no longer necessary. * The logic that dynamically registered/deregistered the extension window-scoped side-panel based on active tab is no longer necessary. Bug: 363743081
For some reason, the compiler started warning an unused variable in our `OmniboxResultView` overrides. This variable does seem to have been unused for a while now, so it is not clear why it wasn't erroring out before. This change adds an override to make sure the variable is declared with `[[maybe_unused]]`. Chromium change: https://chromium.googlesource.com/chromium/src/+/50b3de003c47ec7a4d3347fa296c4072864dcfcb commit 50b3de003c47ec7a4d3347fa296c4072864dcfcb Author: manukh <[email protected]> Date: Tue Oct 15 19:38:31 2024 +0000 [omnibox][history-embeddings] UI work for v2 history embedding answers - Adds new color `kColorOmniboxResultsTextAnswer` and typography `CONTEXT_OMNIBOX_POPUP_LOCAL_ANSWER_HEADER` since the answer text color & size is different than the existing text colors in the omnibox. - Adds a new view OmniboxLocalAnswerHeaderView to represent the '<icon> Summary' or '<icon> Generating...' header messages above answers. In a followup CL, we might also add the separator in this view. This is lazily loaded when an answer match is needed, because some omnibox comment mentioned not lazy-loading rarely used views was increasing latency. - Moves the block of code that sets content & descriptions from `OmniboxResultView` to `OmniboxMatchCellView`. It didn't make sense for the grandparent of the render texts to be fetching & updating the render text. Especially since `OmniboxMatchCellView` already handles updating all its other children, so why should content and descriptions be any different. - Adds a new `LayoutStyle::ANSWER` to `OmniboxMatchCellView` to style answer matches differently than other matches. - Replaces `kMargin` with `kRowHeight`. Before, the row height was derived by adding `kMargin` * 2 to the image heights. Using `kRowHeight` directly seems less error-prone and easier to reuse without duplicating the computation. - Updates the match selection background corner radius from 40 to 20. 40 was incorrect, but it didn't matter since row height was 40 so the radii were capped to 20 anyways. But since answers have higher row height, the distinction now matters. - Add support for multiline `OmniboxTextView`. Also, cache its size. The base class `View` already has a size cache mechanism, but we can't use that since our items change size as the user types or resizes their window. So added a custom cache for the last available size & computed size; so when the available size changes, we can ignore the cached computed size. - Grouped history embedding answers below other suggestions, except IPH. They're expected to be slow and visually loud, so ranking them above other suggestions would be disruptive. - Hid switch-to-tab button on history embedding answers. - Added new feature param `kAnswersInOmniboxScoped` to guard this. - Using a hardcoded mock answer for now so this CL can focus on just view changes. A followup CL will plug in the answer from the service. Bug: 364303536
Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/c0be837dd32c9c92ec22d6b3d43ec414d0c0bc2c OTR to [oO]tr in java code. Bug: 372670589 Change-Id: I6d5aaa3b5b8af401e09c1990e12bfc889e93815c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924233
Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/aecab74413e302b929bc8d6f6274e5ec02c34e2e Clean up irrelevant AutocompleteMatch fields Change-Id: If11fa90715a6d0a9047e79f96b3bb32b67db0ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5935117
This reverts commit 67a142b.
In cr132, SidePanelCoordinator::OnEntryWillDeregister() is removed. We relied on it to deregister observed entry from SidebarContainerView. Instead, we'll use OnEntryWillHide() callback. It'll be called when side panel is closed. At that time, we could remove observing it safely, and will start to observe again if that entry is still live in tab's registry.
github-actions
bot
added
CI/run-network-audit
This makes it necessary to declare this target as a dep of `//brave/browser/ui`. Chromium change: https://chromium.googlesource.com/chromium/src/+/b2877940e18b82a911ba18dfca2ea00988f944b6 commit b2877940e18b82a911ba18dfca2ea00988f944b6 Author: Antonio Gomes <[email protected]> Date: Tue Oct 15 10:37:05 2024 +0000 Modularize chrome/browser/ui/javascript_dialogs This CL adds to chrome/browser/ui/javascript_dialogs its own BUILD.gn file. Given that there is a circular dependency against both //c/b/:b and //c/b/ui:ui, an "impl" GN target was added in order to confine the circular dependencies. Once the modularization advances, both :javascript_dialogs and :impl GN targets should be unified. No behavior change expected. [email protected] Bug: 372506006
|
A Storybook has been deployed to preview UI for the latest push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: