-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update titles for server selection page #25995
Merged
Merged
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeppandya
added
CI/skip-android
Do not run CI builds for Android
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-ios
Do not run CI builds for iOS
CI/skip-windows-x64
Do not run CI builds for Windows x64
unused-CI/skip-linux-x64
Do not run CI builds for Linux x64
CI/skip-macos-arm64
Do not run CI builds for macOS arm64
labels
Oct 15, 2024
samartnik
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mkarolin
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings
++
brave-builds
added a commit
that referenced
this pull request
Oct 15, 2024
brave-builds
added a commit
that referenced
this pull request
Oct 15, 2024
This was referenced Oct 15, 2024
Released in v1.73.14 |
Verification PASSED on
|
Example |
Example |
---|---|
Test Case #2
- brave/brave-browser#41594
- ensured that the title displays the current selected
Country
rather than displayingLocation
as per [Follow up to #36277] Wrong title is shown oncountry
screen: shownLocation
instead of<Country name> server
brave-browser#41594 (comment):
Example |
Example |
Example |
---|---|---|
kjozwiak
pushed a commit
that referenced
this pull request
Oct 17, 2024
Uplift of #25995 (squashed) to beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/skip-android
Do not run CI builds for Android
CI/skip-ios
Do not run CI builds for iOS
CI/skip-macos-arm64
Do not run CI builds for macOS arm64
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-windows-x64
Do not run CI builds for Windows x64
unused-CI/skip-linux-x64
Do not run CI builds for Linux x64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#41593
Resolves brave/brave-browser#41594
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: