Skip to content

Commit

Permalink
Update titles for server selection page (uplift to 1.72.x) (#26008)
Browse files Browse the repository at this point in the history
Uplift of #25995 (squashed) to beta
  • Loading branch information
brave-builds authored Oct 17, 2024
1 parent 66a53d6 commit 94981c5
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ private void initializeViews() {
ActionBar actionBar = getSupportActionBar();
assert actionBar != null;
actionBar.setDisplayHomeAsUpEnabled(true);
actionBar.setTitle(getResources().getString(R.string.change_location));
assert BraveVpnUtils.selectedRegion != null;
actionBar.setTitle(
getResources()
.getString(R.string.region_text, BraveVpnUtils.selectedRegion.namePretty));

mServerRegionList = (RecyclerView) findViewById(R.id.server_list);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ private void initializeViews() {
ActionBar actionBar = getSupportActionBar();
assert actionBar != null;
actionBar.setDisplayHomeAsUpEnabled(true);
actionBar.setTitle(getResources().getString(R.string.change_location));
actionBar.setTitle(getResources().getString(R.string.server_region));

mServerRegionList = (RecyclerView) findViewById(R.id.server_selection_list);

Expand Down
6 changes: 6 additions & 0 deletions browser/ui/android/strings/android_brave_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -2461,6 +2461,12 @@ If you don't accept this request, VPN will not reconnect and your internet conne
<message name="IDS_AVAILABLE_SERVERS" desc="Available servers text">
Available Servers
</message>
<message name="IDS_SERVER_REGION" desc="Server region title for vpn server selection page">
Server region
</message>
<message name="IDS_REGION_TEXT" desc="Specific region title for vpn server selection page">
<ph name="REGION_NAME">%1$s<ex>United states</ex></ph> server
</message>
<message name="IDS_OTHER_ISSUES" desc="Brave Vpn support text">
Select Issue
</message>
Expand Down

0 comments on commit 94981c5

Please sign in to comment.