Canary #17450

….0.6776.1.

`top_frame_origin` is not being passed as a reference to an optional anymore, as that can lead to unwanted copies. This change corrects our overrides to that function to match the signature upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/eeda933c994ab5e0e9612bc695b78e38231a8bd1 commit eeda933c994ab5e0e9612bc695b78e38231a8bd1 Author: Chris Fredrickson <[email protected]> Date: Tue Sep 17 14:06:47 2024 +0000 Use base::optional_ref<T> instead of std::optional<T>& std::optional<T> is a value that might absent, whereas base::optional_ref<T> is a reference that might be absent. Thus, use of std::optional<T> results in an unnecessary copy when implicitly converting from a T&; base::optional_ref avoids that copy. (A function parameter of type base::optional_ref<T> is similar to a parameter of type T*, except that the base::optional_ref allows the use of temporaries.) Change-Id: Ib627b18105e6a6d18d892f4731f5049b183a9df0

With the use of span as an outparam, it becomes possible to better iterate over the items. Chromium change: https://chromium.googlesource.com/chromium/src/+/b3255fdcb98caf809e094ff2016930f8abf96e74 commit b3255fdcb98caf809e094ff2016930f8abf96e74 Author: Fredrik Söderquist <[email protected]> Date: Tue Sep 17 00:16:36 2024 +0000 spanification: WTF::String::CreateUninitialized() Forward to the span<> variant on StringImpl. Bug: 351564777

Chromium change: https://source.chromium.org/chromium/chromium/src/+/924617d4a513876f7cf0097d073a037d08b9eb31 commit 924617d4a513876f7cf0097d073a037d08b9eb31 Author: dpapad <[email protected]> Date: Tue Sep 17 17:57:45 2024 +0000 Settings: Replace remaining <iron-icon src=...> usages with cr-icon. `src=...` is not supported by cr-icon. In order to accommodate, using an <img> element directly when `src=...` is needed (in both cases it was done to display throbber_small.svg). Bug: 40943652

Chromium changes: https://source.chromium.org/chromium/chromium/src/+/1ed8db05a7a2c2affbff615d8aaea759ac87bade commit 1ed8db05a7a2c2affbff615d8aaea759ac87bade Author: Erik Chen <[email protected]> Date: Tue Sep 17 07:31:34 2024 +0000 Reduce fragility in SidePanelCoordinator (part 7 / N) This CL is a refactor with no intended user-visible impact. This CL deletes the view property SidePanelContentState. This is only read by SidePanel and only set by SidePanelCoordinator. By removing the view property we remove an unnecessary layer of indirection. This is replaced by Open and Close methods on SidePanel which SidePanelCoordinator calls. This CL adds a state member to SidePanel to track and expose the internal state machine. State is one of: kClosed, kOpening, kOpen, kClosing. SidePanelCoordinator is the only entity that should be controlling visibility of SidePanel. All other calls to UpdateVisibility() were removed. These calls appear to be side effects of relying of view-properties to propagate state changes. Bug: 363743081 https://source.chromium.org/chromium/chromium/src/+/31a977c143b574bc9d85e1979e2483b3369daf54 commit 31a977c143b574bc9d85e1979e2483b3369daf54 Author: Erik Chen <[email protected]> Date: Wed Sep 18 04:28:39 2024 +0000 Reduce fragility in SidePanelCoordinator (part 9 / N) This CL is a refactor with no intended behavior change. This CL moves the class SidePanelContentSwappingContainer from SidePanelCoordinator to SidePanel. Bug: 363743081

Chromium change: https://source.chromium.org/chromium/chromium/src/+/2646de6874e08c0da01754b72486c29a01cdedd1 commit 2646de6874e08c0da01754b72486c29a01cdedd1 Author: Emily Shack <[email protected]> Date: Tue Sep 17 22:09:42 2024 +0000 Declutter: Allow opening to a specific feature Adds a profile pref for the feature the tab organization tab within the tab search bubble should display when opened. This follows the pattern used for opening the bubble to a specific tab. For now, this is used by auto tab groups entry points to bypass the selector. Future use cases such as the chip and any other new entrypoints will similarly be able to open the bubble directly to declutter. Bug: 366236403

Chromium change: https://source.chromium.org/chromium/chromium/src/+/7a7f7387efa2e2a34fe41cbef79a6f7660ce3328 commit 7a7f7387efa2e2a34fe41cbef79a6f7660ce3328 Author: S. Ganesh <[email protected]> Date: Tue Sep 17 17:18:44 2024 +0000 Add the ability to set a description for the InstallServiceWorkItem Bug: 343638931

On MacOS/iOS: ERROR at //chrome/updater/mac/BUILD.gn:13:1: Value collision. import("//chrome/updater/branding.gni") ^------------------------------------- This import contains "keystone_app_name" See //brave/chromium_src/chrome/updater/branding.gni:18:23: defined here. keystone_app_name = "BraveSoftwareUpdate" ^-------------------- Which would clobber the one in your current scope See //chrome/enterprise_companion/branding.gni:32:23: defined here. keystone_app_name = "ChromiumSoftwareUpdate" ^----------------------- Executing import should not conflict with anything in the current scope unless the values are identical. See //chrome/updater/BUILD.gn:23:14: which caused the file to be included. deps = [ "//chrome/updater/mac" ] ^--------------------- Chromium change: https://source.chromium.org/chromium/chromium/src/+/bd96319778e6f280a4915b29f1ca16c16d6f00af commit bd96319778e6f280a4915b29f1ca16c16d6f00af Author: Noah Rose Ledesma <[email protected]> Date: Tue Aug 6 21:41:11 2024 +0000 Create pkg installer for MacOS Add a build rule which creates a pkg installer for MacOS. The pkg installer copies the application bundle to a staging directory (adj. to the installation), and runs the enterprise_companion binary with the install flag, akin to O4's installer. Behind the install flag, the logic for Linux's installer is now shared with Mac to simply copy the executable to the install directory and configure permissions. Finally, a new integration test target was added to provide coverage of this installation experience. Integration tests are distinct from unit tests in that they will require root/admin privileges. Bug: 344878963

Chromium change: https://source.chromium.org/chromium/chromium/src/+/21849f23ddc564a43b12c209f88cb96621c21040 Use ServiceLoaderUtil with AppHooks Bug: 40901855

Chromium change: brave/chromium@102fef6 [E2E] Draw edge to edge on NTP Use SimpleEdgeToEdgePadAdjuster to pad the feed recycler view on NTP to allow the page draw to edge. Preview: https://screenshot.googleplex.com/95y7x9RMgfXUbJw https://screenshot.googleplex.com/9nRKDBmVSZcJQFG Dark: https://screenshot.googleplex.com/5reX99dKKBFP2sQ https://screenshot.googleplex.com/3pKbxh2Xmbcuram Bug: 339025702

Chromium change: https://source.chromium.org/chromium/chromium/src/+/bec7878b1af9336b7d8ccf6926b6bf28ba658645 [bookmarks] Remove improved bookmarks feature flag and cleanup code Bug: 326237392

Chromium change: https://source.chromium.org/chromium/chromium/src/+/553ab217c7738507c2f5f969c388d82fcae375ab Rename quickactionsearchwidget to shortcuts_widget Change-Id: Ie8dbecd297925950e6a0a0da7c20e74b679383d3

Checks for whether or not metrics reporting are enabled have been removed entirely from `ChromeMetricsServicesManagerClient`, and are now retrieved straight from `ChromeEnabledStateProvider::IsReportingEnabled`. Chromium change: https://chromium.googlesource.com/chromium/src/+/bde3b49864827b605bec6ed246a785cbd252c2cd commit bde3b49864827b605bec6ed246a785cbd252c2cd Author: Alexei Svitkine <[email protected]> Date: Wed Sep 18 15:32:57 2024 +0000 Remove an extra layer of indirection for checking metrics state. This paves the way for additional clean ups. Bug: 367328884

This url is the darkmode URL for `kPrivacyPolicyOnlineURLPath`, which is also not supported. Chromium change: https://chromium.googlesource.com/chromium/src/+/811078c4cf232b15805a2edba21f90655d387af2 commit 811078c4cf232b15805a2edba21f90655d387af2 Author: Christine Ying <[email protected]> Date: Thu Sep 19 16:25:02 2024 +0000 [PrivacyPolicy] Add dark mode support to privacy policy page dark mode screencast: https://screencast.googleplex.com/cast/NjY0OTk2NTA1MTkwNDAwMHw0ODExNTQ3MS03Zg light mode screencast: https://screencast.googleplex.com/cast/NTIzMzYxNjc0MDE1NTM5MnxmNmNkNjk5Ni1kNg Change-Id: Ife38de38796a988fdfa334a8ef9335c621673c42 Bug: 365867510

This is an upstream change to allow contructor args to be passed to this instance. Chromium change: https://chromium.googlesource.com/chromium/src/+/2a1062d25522ebdb3397ad2104110dab7935ae79 commit 2a1062d25522ebdb3397ad2104110dab7935ae79 Author: Alex Ilin <[email protected]> Date: Wed Sep 18 16:25:37 2024 +0000 [google_apis] Replace LazyInstance with a static local variable Store APIKeyCache in a static local variable instead of base::LazyInstance. This will allow adding a constructor parameter to APIKeyCache. Bug: 367764868

Chromium change: https://chromium.googlesource.com/chromium/src/+/1f49958fa6c8dff699904d2b1fd1f74352d45ec2 commit 1f49958fa6c8dff699904d2b1fd1f74352d45ec2 Author: Dave Tapuska <[email protected]> Date: Thu Sep 19 19:39:37 2024 +0000 Change encoding/decoding methods to take a StringView Update methods to operate on a StringView instead of a String. Bug: 366411876

This seems to have been working incidentally, but recently CI issues have shown up in canary.

Chromium change: https://chromium.googlesource.com/chromium/src/+/a2bc8fa9487a475b3151c00bad9aafffb332ba49 commit a2bc8fa9487a475b3151c00bad9aafffb332ba49 Author: Jingqi Sun <[email protected]> Date: Sat Sep 21 06:37:06 2024 +0000 [SidePanel] Encapsulate width preference logic in SidePanel constructor This CL introduces a new method in the SidePanel class to centralize the width preference logic. This ensures that the user-specific configurations are consistently applied whenever a side panel is initialized. Bug: 357101118

`StringView` doesn't have a `StartsWith` member. Chromium changes: https://chromium.googlesource.com/chromium/src/+/a0c53ad73b71beafe9dbd51165b728717752aa6f commit a0c53ad73b71beafe9dbd51165b728717752aa6f Author: Dave Tapuska <[email protected]> Date: Fri Sep 20 19:24:27 2024 +0000 [kURL] Change GetPath to return a StringView Return StringView as returning a String can be a footgun for allocations. Eventually I'll move all properties on KURL to StringViews (this matches what Webkit did for their KURL fork). Bug: 366411876

This is part of an ongoing upstream rewrite to have these services returned by a profile instance. Chromium change: https://chromium.googlesource.com/chromium/src/+/860e3ec83a29a2e5e7c148de24a9eaba3e43ae63 commit 860e3ec83a29a2e5e7c148de24a9eaba3e43ae63 Author: Aliona DANGLA <[email protected]> Date: Tue Sep 17 09:10:29 2024 +0000 [iOS] Updates files under ios/chrome/browser/bookmarks This CL replaces: * ChromeBrowserState => ProfileIOS * GetBrowserState => GetProfile * browser_state => profile * browserState => profile * GetOriginalChromeBrowserState => GetOriginalProfile * HasOffTheRecordChromeBrowserState => HasOffTheRecordProfile * GetOffTheRecordChromeBrowserState => GetOffTheRecordProfile * DestroyOffTheRecordChromeBrowserState => DestroyOffTheRecordProfile web::BrowserState code is not updated. Fixed: 365526102

This affects the path for the shadow file we have in place for insertion. Chromium change: https://chromium.googlesource.com/chromium/src/+/c8f909854f462aeaf91943193016f704a00da9ab commit c8f909854f462aeaf91943193016f704a00da9ab Author: Alex Ilin <[email protected]> Date: Mon Sep 23 14:09:40 2024 +0000 [google-apis] Stop re-including google_api_keys-inc.cc in tests Instead of including google_api_keys-inc.cc multiple times in the tests, we can now construct ApiKeyCache instance in a test and re-assign the global pointer to it. Bug: 367764868

`ApiKeyCache` now has its own header, which allows us to use a shadow file to patch its content. Chromium change: https://chromium.googlesource.com/chromium/src/+/af38c47054c98d03e51b20cfd50e3565f925acd2 commit af38c47054c98d03e51b20cfd50e3565f925acd2 Author: Alex Ilin <[email protected]> Date: Mon Sep 23 13:59:57 2024 +0000 [google_apis] Move ApiKeyCache into a separate file Move ApiKeyCache to a separate file that is included *only once*. Bug: 367764868

This argument is just passed along with all others to the `ChromeContentBrowserClient` method. Chromium change: https://chromium.googlesource.com/chromium/src/+/3585abaa071f83fdcbf097abe7833d42d3744963 commit 3585abaa071f83fdcbf097abe7833d42d3744963 Author: Rupert Ben Wiser <[email protected]> Date: Tue Sep 24 02:58:41 2024 +0000 Add IsolationInfo for embedders handling external protocols WebView lets app developers intercept calls when an external protocol is involved. We'd like to make it clear to those developers what context the request came from. This will just be ignored by other embedders. Bug: 356891482

This change replaces `RegisterEmbedderObservers` with a refactored `RegisterObservers` in its place, and has no behavioural effect. Chromium change: https://chromium.googlesource.com/chromium/src/+/f5327eed5ae54047e2c0e31485777caa34d6d227 commit f5327eed5ae54047e2c0e31485777caa34d6d227 Author: Keren Zhu <[email protected]> Date: Tue Sep 24 20:42:27 2024 +0000 [PLM] refactor metrics embedder to prepare for adding metrics for NTP This change refactors the page load metrics embedder classes to prepare for the addition of a new observer specific to the New Tab Page (NTP). The following changes were made: - `RegisterObservers()` is refactored to accept a `NavigationHandle` argument. This allows page-specific observers to be registered based on the navigated URL. - Remove `RegisterEmbedderObservers` to give embedder subclasses direct control over observer registration. Subclasses can now choose to register common observers by calling their parent's `RegisterObservers` method. This removes the need for special case handling (Side Search, non-tab WebUI and soon NTP) within the base class. - add a placeholder within the `RegisterObservers` method to conditionally register the future NTP-specific observer. This change has no behavioral change. Bug: 365784990

This change has run into build errors because `StringView` doesn't offer a `StartsWith` method. Additionaly, in a generic context where `T::Host` is called, for types like `SecurityOrigin `, `Host` still return `String`, which has to be reconciled with the `KURL` case. Chromium change: https://chromium.googlesource.com/chromium/src/+/55f1e9efbe0c4c1dd9d53da37f030c0041c34591 commit 55f1e9efbe0c4c1dd9d53da37f030c0041c34591 Author: Dave Tapuska <[email protected]> Date: Mon Sep 23 18:46:26 2024 +0000 [kURL] Change GetHost to return a StringView Return StringView as returning a String can be a footgun for allocations. Eventually I'll move all properties on KURL to StringViews (this matches what Webkit did for their KURL fork). Collapse GetHost and GetHostView into one function. Bug: 366411876

This target has been introduced breaking away some of the download code from `//chrome/browser`. Chromium change: https://chromium.googlesource.com/chromium/src/+/8231ebef6aab18268734156dada635b087a51b2e commit 8231ebef6aab18268734156dada635b087a51b2e Author: Antonio Gomes <[email protected]> Date: Tue Sep 24 08:21:41 2024 +0000 Build more files as part of //c/b/download:download GN target ... namely, download_ui_model.h and download_commands.h. These files are included by headers in //c/b/ui/download/ and today build as part of //c/b:b GN target. Hence, modularizing this //c/b/ui/download would cause circular dependencies with //c/b/. [email protected] Bug: 368831367

`hats` code has been designated to its own target, and therefore dependency to this target should be added for cases where we use `hats` headers. Chromium change: https://chromium.googlesource.com/chromium/src/+/c769a4b4b70e9a09d915e615c86c768e3a79784f commit c769a4b4b70e9a09d915e615c86c768e3a79784f Author: Antonio Gomes <[email protected]> Date: Fri Sep 20 15:09:05 2024 +0000 Modularize chrome/browser/ui/hats This CL adds a BUILD.gn to //c/b/ui/hats subdirectory. [email protected] Bug: 36792928

This follows the latest deployment on chromium. Chromium change: https://chromium.googlesource.com/chromium/src/+/a5fb630f300a1a3fdda9bb22a7ca79dd5296def2 commit a5fb630f300a1a3fdda9bb22a7ca79dd5296def2 Author: Mark Mentovai <[email protected]> Date: Wed Sep 18 22:14:57 2024 +0000 Reland "mac: Switch to Xcode 16.0 16A242d with macOS SDK 15.0 24A336" This is a reland of fbc74102ad59 (https://chromium-review.googlesource.com/c/5868532), which was reverted in 1bf416f7ddf0 (https://chromium-review.googlesource.com/c/5867385) because it caused Mac ASan 64 Builder to fail its compile step in the generate_v8_context_snapshot step (https://crbug.com/367764848). This can reland atop daa2e0a59313 (https://chromium-review.googlesource.com/c/5873781), which should prevent generate_v8_context_snapshot from failing under Address Sanitizer. Original change's description: > mac: Switch to Xcode 16.0 16A242d with macOS SDK 15.0 24A336 > > FOR CHECKIN > FOR CHICKEN > PARA POLLO > POUR LE POULET > 🐣 > > Bug: 367439535 > Change-Id: I13c4849eddb458b76d973dcc059c7043b63b4245 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5868532 > Reviewed-by: Nico Weber <[email protected]> > Commit-Queue: Mark Mentovai <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1356474} Bug: 367439535

Unfortunately, `WrapUnique` is a very unfortuntate anchor for substitutions, and it seems a failure is now taking place due to some transient inclusion.

Upstream's logic in `AppLocaleUtils` for `getApplicationLocales` and `setApplicationLocales` is the same as it was in our patch, so we don't need it anymore. Chromium change: https://source.chromium.org/chromium/chromium/src/+/826aadf32e2ebec6a4086d97937f345ea5f3f912 Android: Adopt ServiceLoaderUtil for LanguageProfileDelegate And upstreams & inlines the logic from LocaleManagerDelegate, which existed only to work around Android T SDK not yet being available. Also adds some @JniType annotations to LanguageBridge to simplify changes there. Bug: 40901855

Chromium change: brave/chromium@e3880fa Pad all the recycler view / list view for the hub some the last element can be scrolled away from the bottom insets area. Demo: https://screencast.googleplex.com/cast/NTY4Mzc2MDY1MjYxNTY4MHw1YjNlMjczNS1hZA Bug: 368072594

Chromium change: https://source.chromium.org/chromium/chromium/src/+/db9277a704faa54da6392919398935051ec4a814 Make TaskRunner extend Java's Executor interface This allows TaskRunners to be passed to Java APIs that expect and Executor. Bug: 326475719

Chromium change: https://source.chromium.org/chromium/chromium/src/+/b031df85047dec61c0de4f81ad212bcb52088d9c Revert "Rename quickactionsearchwidget to shortcuts_widget" This reverts commit 553ab217c7738507c2f5f969c388d82fcae375ab. Reason for revert: Bug: b/368500276 No-Try: true Original change's description: > Rename quickactionsearchwidget to shortcuts_widget > > Change-Id: Ie8dbecd297925950e6a0a0da7c20e74b679383d3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5862267 > Reviewed-by: Sky Malice <[email protected]> > Commit-Queue: Gang Wu <[email protected]> > Reviewed-by: Wenyu Fu <[email protected]> > Code-Coverage: [email protected] <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1356491} Change-Id: Id32298409485d903c8594784d9b1ca6ccce4ed0c

Chromium change: https://source.chromium.org/chromium/chromium/src/+/a382ec03169578982da4dbeb0960dc08eae005eb [Data Sharing] Update a11y strings for toolbar TabSwitcherDrawable Update the a11y strings for the toolbar view that hosts the TabSwitcherDrawable icon. Bug: 358464189

Chromium change: https://source.chromium.org/chromium/chromium/src/+/9ae80c355f8e7c332654b6fd9243e146a16ef075 [hub] Add basic search box layout Eventually this fake search box will be hooked up to the SearchActivity. * Add in the layout for the search box. * Add dummy listener for click events. Bug: 364716470

Upstream has dropped `GetSwitchValueFromCommandLine`, and changed the way this function is being tested. This change corrects our override tests to reflect this change. Chromium change: https://chromium.googlesource.com/chromium/src/+/eac5497ea72a76f73f5e6af059716e21cf7bf2ca commit eac5497ea72a76f73f5e6af059716e21cf7bf2ca Author: Peter Kvitek <[email protected]> Date: Wed Sep 18 17:56:31 2024 +0000 [install_static] Refactor command line handling This CL changes command line handling so that it allows caller to check if the specified switch is present in the command line. This is in anticipation of https://crrev.com/c/5855260 that needs to handle --headless switch with or without value. Drive by: changed 'const std::string&' to 'std::string_view' where appropriate. Change-Id: I9858371b52a38a5d580554ef0e37baeca266b73b

This change adds `brave_wayback_machine` buildflags as a public dep for `//brave/browser/ui`, in order to make sure the build flags are built before `//chrome/browser/ui`. This is to avoid build failures due to transient inclusions like in: In file included from ../../chrome/browser/safe_browsing/chrome_password_protection_service.cc:102: In file included from ../../brave/chromium_src/chrome/browser/ui/views/frame/browser_view.h:9: ../../brave/browser/ui/brave_browser_window.h:12:10: fatal error: 'brave/components/brave_wayback_machine/buildflags/buildflags.h' file not found 12 | #include "brave/components/brave_wayback_machine/buildflags/buildflags.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Chromiu change

SharedPinnedTabService::OnBrowserSetLastActive can be called after SharedPinnedTabService::OnBrowserClosing due to BrowserView::OnWidgetActivationChanged becoming active. Extended the DCHECK with the possibility of the browser being in the closing browsers list.

Chromium change: https://source.chromium.org/chromium/chromium/src/+/ff5efbff97142bbf09194aac1542b88b44599d52 commit ff5efbff97142bbf09194aac1542b88b44599d52 Author: Peter Kvitek <[email protected]> Date: Thu Sep 26 12:44:23 2024 +0000 Reland "[headless] Create temporary user data directory early on Windows" This is a reland of commit 0496c1d95307bbf203a9830e2c705483902f8429 This CL fixes unit tests asserts by refactoring failing tests. It supersedes the forward fix CL https://crrev.com/c/5889444, see the relevant comments there. Original change's description: > [headless] Create temporary user data directory early on Windows > > In order to run in parallel with a regular Chrome instance and with > other headless Chrome instances each headless Chrome instance needs > to have its own user data directory. Normally this is done by adding > --user-data-dir switch in headless Chrome initialization code called > from ChromeMain. However, on Windows this is already too late since > user data directory needs to be present during early crash reporter > initialization in ELF. > > This CL adds --headless switch handling to install_static component > which ensures that if the switch is present, the temporary > user data directory is created and passed down to the headless > Chrome initialization code. > > Also fixed a couple of browser tests which used to create a > temporary user data directory and write some test data into it. > Since these were InProcessBrowserTests derived tests they already > had user data directory specified in the command line so adding > a duplicate --user-data-dir resulted in ambiguity that caused > test failure on win-rel. > > Bug: 362545030, 362301064

This reverts commit 42e96fa.

This merely affects the scope of the call. Chromium change: https://chromium.googlesource.com/chromium/src/+/45557e4f3abd4087fe01fbfbf47df08dad851e72 commit 45557e4f3abd4087fe01fbfbf47df08dad851e72 Author: Hyungwook Lee <[email protected]> Date: Thu Sep 26 12:26:15 2024 +0000 Remove some chrome:: namespace from chrome/browser/profiles/incognito_helpers.* Bug: 41050580

This only affects the namespace access. Chromium change: https://chromium.googlesource.com/chromium/src/+/5ec7e7fc25007e705382dd8e58a031410ab77e98 commit 5ec7e7fc25007e705382dd8e58a031410ab77e98 Author: Jason Chase <[email protected]> Date: Thu Sep 26 02:38:49 2024 +0000 Move CallStackProfileParams into //components/sampling_profiler - Continues the refactoring in https://docs.google.com/document/d/12pqVqIpLb5qxmm9T9qatbVcp5UnietMcpByUc0XPfYE/edit?usp=sharing - From a previous CL [1], it was determined that //base should not be aware of specific process/thread/trigger types. - Moves the struct/enums into //components/sampling_profiler, with the other ThreadProfiler logic. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5738660/comment/7228f393_53cf2a32/ Low-Coverage-Reason: TRIVIAL_CHANGE to ios/chrome/browser/web/model/ios_thread_profiler.cc, with no-op moves of struct and enum to different header files. Bug: 354124876

Chromium change: https://chromium.googlesource.com/chromium/src/+/60d3dc8a6a9edf2caca8f2a98180cc1b0ef424b4 commit 60d3dc8a6a9edf2caca8f2a98180cc1b0ef424b4 Author: Hyungwook Lee <[email protected]> Date: Thu Sep 26 12:05:12 2024 +0000 Remove some chrome:: namespace from chrome/renderer/process_state.* Bug: 41050580

With `syn` v1 being dropped upstream, it is necessary now to check out the crate on the local tree. It looks like `gnrt` is not generating `buildrs_support` support `deps` correctly, by referencing to the deps `:lib` target, rather than the `buildrs_support` ones. Chromium change: https://chromium.googlesource.com/chromium/src/+/38f5d23915a308f962997444babacc3e65d2f1ee commit 38f5d23915a308f962997444babacc3e65d2f1ee Author: danakj <[email protected]> Date: Wed Sep 25 22:26:43 2024 +0000 Roll rstest to 0.22 This CL has been created semi-automatically. The expected review process and other details can be found at //tools/crates/create_update_cl.md Updated crates: * rstest: 0.17.0 => 0.22.0 * rstest_macros: 0.17.0 => 0.22.0 * rstest_reuse: 0.5.0 => 0.7.0 New crates: * [email protected] * [email protected] Removed crates: * [email protected] Chromium `supply-chain/config.toml` policy requires that the following audit criteria are met (note that these are the *minimum* required criteria and `supply-chain/audits.toml` can and should record a stricter certification if possible; see also //docs/rust-unsafe.md): * [email protected], [email protected], [email protected], [email protected], [email protected]: crypto-safe, safe-to-run Bug: 369075726

This crate has been deleted for a weeks now, but for some reasons the `BUILD.gn` file for it was left behind, and so the patch in brave for it was still applying unnoticed. The upstream folder is deleted now. Chromium change: https://chromium.googlesource.com/chromium/src/+/ec80bbb4c67e476a5047fb0cf66177f497863dcc commit ec80bbb4c67e476a5047fb0cf66177f497863dcc Author: danakj <[email protected]> Date: Wed Oct 9 17:21:26 2024 +0000 Remove the old syn v1 build dir. syn v1 is gone, and gnrt vendor pointed out this directory got left behind. [email protected] Change-Id: I7fe5e1b3505947d45bcafbf9249cd5374e7b3355

Retrieving this service is supposed to be done through the factory class. Chromium change: https://chromium.googlesource.com/chromium/src/+/9cfd3bade4481a0d1e4e8709fd286e3b31adc4b7 commit 9cfd3bade4481a0d1e4e8709fd286e3b31adc4b7 Author: Victor Hugo Vianna Silva <[email protected]> Date: Thu Sep 26 13:34:47 2024 +0000 Remove AccountConsistencyModeManager::GetForProfile() The corresponding method in the factory can be used directly. No behavior change. Bug: 368246456

With this change value and length are embedded in the span argument. Chromium change: https://chromium.googlesource.com/chromium/src/+/2f2615d47ac182c0eeb0597356cc0a559ae83c8d commit 2f2615d47ac182c0eeb0597356cc0a559ae83c8d Author: Tomasz Wiszkowski <[email protected]> Date: Thu Sep 26 21:56:02 2024 +0000 Drop C-style arrays from generated structs TLDR: Change replaces the following fields in structs generated from JSON: - const TYPE* array_name - size_t array_name_size with - const base::span<const TYPE> array_name and removes some unsafe buffer usage warning suppression pragmas. This change proposes replacing pointer-and-length struct fields with their base::span<> equivalent. The change does not entirely abandon the C-style structs, but hides and abstracts them so that iterating elements no longer causes unsafe buffer usage errors. The change addresses C-style arrays in structs only, and does not solve the equivalent case of generated collections encompassing all JSON elements (such as `kAllEngines`). For that reason many pragma statements could not be removed yet. Bug: b/40285824, b/352691908

This change does unifies the id/status pair data sent during `OnEvent` under a single structure, which affects quite a few places where this event is used. Another place affected by these changes involves instantiating `UpdateContext`, which doesn't require to pass along a `notify_observers_callback` argument. Chromium change: https://chromium.googlesource.com/chromium/src/+/2c20c79dfeff629b1867c5e0a8837149e8a5f668 commit 2c20c79dfeff629b1867c5e0a8837149e8a5f668 Author: Joshua Pawlicki <[email protected]> Date: Fri Sep 27 13:28:14 2024 +0000 update_client: Simplify observer mechanisms. Prior to this CL, there were multiple observer mechanisms that used different types, but all of which mapped to the same underlying concepts. After this CL, there are still multiple mechanisms (depending on whether the observer wants their observations scoped to a single updater operation or whether they want to observe the updater as a whole), but the types are now consistent, and observers get a constref snapshot of the observed item. Bug: 353249967

This constant has been replaced with a static function. The only use of the constant was `constexpr` however it for a list of a single item, and therefore unnecessary to be used as such. Chromium change: https://chromium.googlesource.com/chromium/src/+/4e18bb79eaa862fa61074e4bfd9510dbba3ef182 commit 4e18bb79eaa862fa61074e4bfd9510dbba3ef182 Author: Maksim Sisov <[email protected]> Date: Fri Sep 27 10:53:17 2024 +0000 Prepare to modularize //chrome/browser/ui/tabs Fixes various problems that block modularization of //c/b/ui/tabs. For example, accessing kDisabledRecentlyClosedHeaderCommandId via static function removes dep cycle from a header file. Also prefer using forward declaration instead of including headers from header files. Last, but not least, use unique ptr to create BrowserTabStripTracker as pulling out browser_tab* into a separate source set results in many cyclic deps. [email protected] [email protected] Bug: 364501603

This function and a few others are now passing a `string_view` for things like `host`. This change updates our own overrides to match that. Chromium change: https://chromium.googlesource.com/chromium/src/+/4e18bb79eaa862fa61074e4bfd9510dbba3ef182 commit 4e18bb79eaa862fa61074e4bfd9510dbba3ef182 Author: Maksim Sisov <[email protected]> Date: Fri Sep 27 10:53:17 2024 +0000 Prepare to modularize //chrome/browser/ui/tabs Fixes various problems that block modularization of //c/b/ui/tabs. For example, accessing kDisabledRecentlyClosedHeaderCommandId via static function removes dep cycle from a header file. Also prefer using forward declaration instead of including headers from header files. Last, but not least, use unique ptr to create BrowserTabStripTracker as pulling out browser_tab* into a separate source set results in many cyclic deps. [email protected] [email protected] Bug: 364501603

A substitution failure has popped up on `app_menu_model.cc`, due to the `.cc` shadow failing to premptively include `app_menu_model.h`, which undefs the substitution. This override must have been working incidently due transient header inclusions.

This has been discussed with others, and it looks harmless. Chromium change: https://chromium.googlesource.com/chromium/src/+/080adbbc95c987acc8e40adce21e1ab3f6588e6f commit 080adbbc95c987acc8e40adce21e1ab3f6588e6f Author: Ari Chivukula <[email protected]> Date: Mon Sep 30 17:25:21 2024 +0000 Clean up stale base::Feature "ClientHints*" Let's remove all the flags not to be used in a deprecation that aren't active in finch and have been enabled for a while. Fixed: 356624414, 356624597, 356625182, 356624970, 356624950, 356625165

Chromium change: https://chromium.googlesource.com/chromium/src/+/27f335236769470bab20c8370cb16da24fc2a175 commit 27f335236769470bab20c8370cb16da24fc2a175 Author: manukh <[email protected]> Date: Tue Oct 1 00:32:29 2024 +0000 [omnibox] Cleanup of cr23 features & params - Remove 14 omnibox cr23 flags, 14 features, and 7 params - Remove 2 color tokens that are not needed post-cr23 - Replace a few `Get*()` helpers with `k*` consts now that they don't depend on cr23 state; e.g. `GetWeatherBackgroundSize()` -> `kWeatherBackgroundSize` - Remove dead pre-cr23 code I double checked, the removed features/params in chromium were either not overwritten in finch or were overwritten to their default values. These features were default enabled: - kCr2023ActionChips - kSquareSuggestIcons - kExpandedStateHeight - kExpandedStateShape - kOmniboxSteadyStateHeight These features were default disabled: - kCr2023ActionChipsIcons - kExpandedStateColors - kExpandedStateSuggestIcons - kExpandedLayout - kExpandedStateColors OmniboxExpandedStateSuggestIcons - kExpandedLayout - kSuggestionHoverFillShape - kOmniboxCR23SteadyStateIcons - kOmniboxSteadyStateBackgroundColor - kOmniboxSteadyStateTextStyle - helper IsGM3TextStyleEnabled() - kOmniboxSteadyStateTextColor The default param values were: - kSquareSuggestIconAnswers true - kSquareSuggestIconIcons false - kSquareSuggestIconEntities false - kSquareSuggestIconEntitiesScale .8722 - kSquareSuggestIconWeather true - kFontSizeTouchUI 15 - kFontSizeNonTouchUI 13 The values returned by helpers were: - GetAnswerImageSize 28 - GetEntityImageSize 28 - GetIconAndImageCornerRadius 4 - GetEntityBackgroundScale .8722 - not called - GetWeatherImageSize 24 - GetWeatherBackgroundSize 28 The new constants replacing the old helpers are: - kUniformRowHeightIconSize 28 - kIphTextIndent 14 - kIconAndImageCornerRadius 4 - kWeatherImageSize 24 - kWeatherBackgroundSize 28 Bug: 370088101, 364303536

This change has resulted in the renaming of the keys, but it will also allow us to drop the compiler instructions involving collisions with another enum in the macos sdk. Chromium change: https://chromium.googlesource.com/chromium/src/+/5670f87c2fc0e87834429b3a42e2e013ae5bb912 commit 5670f87c2fc0e87834429b3a42e2e013ae5bb912 Author: Claudio DeSouza <[email protected]> Date: Tue Oct 1 02:55:01 2024 +0000 Make SidePanel::HorizontalAlignment a scoped enum The mac SDK defines `kAlignLeft` and `kAlignRight` as enum constants, and being unscoped, they can collide with the constants in this particular file, depending what sort of transient inclusions one ends up with. This change turns this enum into a scoped enum to avoid this collision. Bug: 40333437

Tnis function used to return a vector. This change corrects one tests where the vector returned was being altered. Chromium change: https://chromium.googlesource.com/chromium/src/+/ceb5f76877e00ffd317ea568dfae25a539a4bf36 commit ceb5f76877e00ffd317ea568dfae25a539a4bf36 Author: Tomasz Wiszkowski <[email protected]> Date: Mon Sep 30 21:47:37 2024 +0000 Replace generated top-level C array with base::span TLDR: instead of generating a: - extern const TYPE kArrayName[]; - extern const size_T kArrayNameLength; the code should now generate: - const base::span<const TYPE> kArrayName; This change ensures the json-to-struct exports a base::span when a 'generate_array' rule is invoked. Migration to generate_array allows us to resolve multiple unsafe buffer access warnings. This is the simplest change that gets the job done. It does not improve the health of the json to struct in any way. Bug: b/40285824

This addition to the ctor of `is_profile_eligible_for_dse_guest_propagation` is irrelevant to our use in tests, and can be defaulted to `false`. Chromium change: https://chromium.googlesource.com/chromium/src/+/cf18d29dd6d004879f57685a452eb92bc1fe9f39 commit cf18d29dd6d004879f57685a452eb92bc1fe9f39 Author: Jack Yammine <[email protected]> Date: Wed Sep 11 16:16:32 2024 +0000 [waffle]Don't show the dialog in a guest session if the pref is set The search engine choice dialog should not be displayed in all guest sessions if the users decide to share the default search engine across guest sessions. Demo: http://b/364254781#comment2 Fixed: b:364254781

It appears this has been working incidently due to some transient inclusion.

JSON resources are now being zipped when stored. To read these resources, it is necessary to unzip their contents, and for that we now should use `LoadDataResourceString`. Chromium change: https://chromium.googlesource.com/chromium/src/+/7ecc2935c70b73f8d2dc505c771327567c5450fc commit 7ecc2935c70b73f8d2dc505c771327567c5450fc Author: Rulong Chen（陈汝龙） <[email protected]> Date: Fri Sep 27 14:45:46 2024 +0000 Grit: Compress all JSON files by default Change Grit's default behavior to gzip-compress all JSON files, unless a |compress| attribute is explicitly specified, such as compress="brotli". out/<out_folder>/resources.pak sizes before/after: macOS: 12957301 -> 11383303, -12% (The majority of the revenue comes from devtools_resources.pak) Bug: 366055332, 40790578

This only affects access to the data members. Chromium change: https://chromium.googlesource.com/chromium/src/+/609ff2321cb123e5f562253ae9cabae9e353b28b commit 609ff2321cb123e5f562253ae9cabae9e353b28b Author: Boris Sazonov <[email protected]> Date: Tue Oct 1 10:00:37 2024 +0000 [Signin] Transform AccountsInCookieJarInfo from struct into a class No behavior change. Bug: 324462717

We now have to go through a different interface to query from `DataTypeManagers` controllers the entity count. This simplifies the code in place a bit too. Chromium changes: https://chromium.googlesource.com/chromium/src/+/9ffc40279cbdeb0d1c8d522f432b20c022c23778 https://chromium.googlesource.com/chromium/src/+/580e71ccd3f7b59eafa956e24c720d33c9f8cf0e commit 9ffc40279cbdeb0d1c8d522f432b20c022c23778 Author: Mikel Astiz <[email protected]> Date: Tue Oct 1 18:54:34 2024 +0000 [sync] Encapsulate controller access inside DataTypeManager This is the last patch in a series that removes the temporary API in DataTypeManager that exposed direct access to the underlying controllers. Such access is still allowed for testing, but otherwise controllers are now fully owned and managed by DataTypeManagerImpl. Semi-related, to exposure of DataTypeStatusTable::TypeErrorMap as part of DataTypeManager's ConfigureResult is also removed, as it leaks internal state and is exclusively used for tests. Change-Id: I674c56cf6e49a1149b8a85fea6afc060aaf2d91b Bug: 40901755 commit 580e71ccd3f7b59eafa956e24c720d33c9f8cf0e Author: Mikel Astiz <[email protected]> Date: Fri Sep 27 13:46:16 2024 +0000 [sync] Refactor debug-only logic away from SyncServiceImpl The functionality to list sync nodes and counters that power sync-internals are now part of DataTypeManager's API and the implementation moved partially to a dedicated class and file. This removes one case where SyncServiceImpl needed to iterate the controller map, which should eventually become a private member in DataTypeManager. Bug: 40901755

This is the common renaming happening in upstream to `Profile` Chromium change: https://chromium.googlesource.com/chromium/src/+/bd8c12c30571ddf568297508b062b7500e88c38e commit bd8c12c30571ddf568297508b062b7500e88c38e Author: Federica Germinario <[email protected]> Date: Wed Sep 25 10:13:38 2024 +0000 [ios] Migrate to ProfileIOS in ios/chrome/browser/shared/model/ This CL refactors subdirectories: - ios/chrome/browser/shared/model/paths - ios/chrome/browser/shared/model/application_context - ios/chrome/browser/shared/model/prefs RegisterBrowserStatePrefs will be removed once internal code is updated Bug: 367245358

In these cases, `GetForProfile` is the method supposed to be used Chromium changes: https://chromium.googlesource.com/chromium/src/+/7156459c913fc1641db858aca453d0269b9c19f5 https://chromium.googlesource.com/chromium/src/+/76d2bfdf847bcef3c1876f594164aca493da83bb commit 7156459c913fc1641db858aca453d0269b9c19f5 Author: Mark Cogan <[email protected]> Date: Wed Sep 25 15:25:23 2024 +0000 [iOS] Updates files under ios/chrome/browser/signin/ Updates code for the name migration to ProfileIOS. This CL replaces: * ChromeBrowserState => ProfileIOS * GetBrowserState => GetProfile * browser_state => profile * browserState => profile * GetOriginalChromeBrowserState => GetOriginalProfile * HasOffTheRecordChromeBrowserState => HasOffTheRecordProfile * GetOffTheRecordChromeBrowserState => GetOffTheRecordProfile * DestroyOffTheRecordChromeBrowserState => DestroyOffTheRecordProfile web::BrowserState code is not updated. SigningBrowserStateInfoUpdater (and factory) is renamed. Bug: 365532011, 361040573, 361040177 commit 76d2bfdf847bcef3c1876f594164aca493da83bb Author: Mark Cogan <[email protected]> Date: Wed Sep 25 10:54:53 2024 +0000 [iOS] Updates files under ios/chrome/browser/sync Updates files for ProfileIOS name change. This CL replaces: * ChromeBrowserState => ProfileIOS * GetBrowserState => GetProfile * browser_state => profile * browserState => profile * GetOriginalChromeBrowserState => GetOriginalProfile * HasOffTheRecordChromeBrowserState => HasOffTheRecordProfile * GetOffTheRecordChromeBrowserState => GetOffTheRecordProfile * DestroyOffTheRecordChromeBrowserState => DestroyOffTheRecordProfile web::BrowserState code is not updated. Also migrates some GetForBrowserState call sites outside of this dir. Bug: 365533473

There is a way now to retrieve all active profiles, where the first one in the vector list represents the last one. Chromium change: https://chromium.googlesource.com/chromium/src/+/50ed9b2a353a2223a8f10c04e78a04586f497cc1 commit 50ed9b2a353a2223a8f10c04e78a04586f497cc1 Author: Sylvain Defresne <[email protected]> Date: Wed Sep 25 11:26:26 2024 +0000 [ios] Remove GetLastUsedProfileDeprecatedDoNotUse() method Change code using GetLastUsedProfileDeprecatedDoNotUse() to use either an arbitrary profile (IOSChromeMainParts) or the kLastUsedProfile pref to decide which profile to use. Since there can be more than one Profile loaded, the notion of "last used profile" does not really make sense. Bug: 333865629

Chromium change: https://source.chromium.org/chromium/chromium/src/+/e6635ffc2cc615ce652951755fff4627980e46b6 android: Migrate LensControllerDelegate Changing how we do AppHooks to simplify GN rules. See internal doc: https://chrome-internal.googlesource.com/clank/internal/apps/+/main/README.md#wiring-up-internal-java-code Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size Bug: 40901855

Chromium change: https://source.chromium.org/chromium/chromium/src/+/2c57ce7d0331365cdf349f90451fb1379a5778ab Adopt ServiceLoaderUtil for CustomizationProviderDelegate Needs to wait for crrev.com/i/7702286 before landing. Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size Bug: 40901855

Chromium change: https://source.chromium.org/chromium/chromium/src/+/a9b7e98a8269f90af6a0f7eb1795b9b96c32b90b [DW] Move desktop windowing code from //chrome to //components Move DesktopWindowStateProvider and AppHeaderState out of //chrome for access by UI components, for eg. the bottom sheet. Bug: 370117828

…g E2E Chromium change: https://source.chromium.org/chromium/chromium/src/+/3c34eed14f29d850c9756a3f7e1ef4f7cb4da709 Extend the omnibox suggestions when drawing E2E By default, the omnibox suggestions fit the height of the screen, without including system bars. When the edge-to-edge feature is enabled, the bottom navigation bar region can be drawn into, showing a gap with tab content underneath the omnibox suggestions list. This change allows for the edge-to-edge feature to communicate extra bottom padding to the omnibox suggestions dropdown to allow it to extend down and cover that bottom region, so the dropdown can draw "edge-to-edge" while keeping all of the suggestions fully visible and interactable. Demo: https://screencast.googleplex.com/cast/NjYyMDM3MTIxNzI4NTEyMHwzOTA4ZmJkZi00NQ Demo (landscape): https://screencast.googleplex.com/cast/NTk5NTYyMjA4NjczNzkyMHw5MzI3Y2ZlYi02YQ Drawing E2E: https://screenshot.googleplex.com/BUEWNAUMbguNCNY.png Drawing E2E (bottom): https://screenshot.googleplex.com/BuCyb2EzK95bsuC.png Bug: b/325636004

Chromium change: https://chromium.googlesource.com/chromium/src/+/7b0f4a87890ea commit 7b0f4a87890eada6c8e66ade31a1524ddd6ba6d3 Author: Erik Chen <[email protected]> Date: Thu Sep 26 21:34:14 2024 +0000 Reland "Modularize //chrome/browser/content_settings" This reverts commit 33aad0933b53aa545d0d2f5f04e158f205ff9740. Reason for revert: Original CL should not have been reverted. Original change's description: > Revert "Modularize //chrome/browser/content_settings" > > This reverts commit b9c3338d51a8b30884cb17b9f7b227fd83bd89e9. > > Reason for revert: Breaks android-desktop-x64-archive-rel and android-desktop-arm64-archive-rel: > https://ci.chromium.org/ui/p/chromium/builders/ci/android-desktop-x64-archive-rel/1999/overview > > Original change's description: > > Modularize //chrome/browser/content_settings > > > > Bug: 369423337

Chromium change: https://chromium.googlesource.com/chromium/src/+/d4f9e696f7559 commit d4f9e696f7559d8462b787d6649689871517db23 Author: Maksim Sisov <[email protected]> Date: Fri Sep 27 06:21:26 2024 +0000 Modularize //chrome/browser/ui/prefs Bug: 368805262

Chromium change: https://chromium.googlesource.com/chromium/src/+/a135ae6e6848f commit a135ae6e6848f5ea4160c82583dfebe95ede4eef Author: Maksim Sisov <[email protected]> Date: Thu Sep 26 07:55:28 2024 +0000 Modularize //chrome/browser/importer Bug: 369506933

Chromium change: https://chromium.googlesource.com/chromium/src/+/eb82f35418eb3 commit eb82f35418eb3b1fe925493fa4f14baa31abed7b Author: Maksim Sisov <[email protected]> Date: Thu Sep 26 09:10:14 2024 +0000 Modularize //chrome/browser/ui/safety_hub Also partial modularize //chrome/browser/ui/webui/settings to avoid circular deps from headers. I just pulled out some stuff in order to unblock other stuff. It is impossible to modularize settings completely due to various dependencies to //c/b from headers. Bug: 368805263, 369369575

Chromium change: https://chromium.googlesource.com/chromium/src/+/b37f809ca2cb2 commit b37f809ca2cb25bd609c7584177a620c8ef47feb Author: Maksim Sisov <[email protected]> Date: Tue Oct 1 09:13:14 2024 +0000 Modularize //chrome/browser/ui/tabs Bug: 364501603

Chromium change: https://source.chromium.org/chromium/chromium/src/+/8595efe0972a10b9527cc992f05e95d5f44c61c2 commit 8595efe0972a10b9527cc992f05e95d5f44c61c2 Author: Noémie St-Onge <[email protected]> Date: Tue Oct 1 15:08:41 2024 +0000 [iOS] Format passkey creation date in CPE This CL formats the creation date of passkeys to be shown in the CPE UI using the iOS NSDateFormatter. Since the format currently found for passkeys in the Password Manager can hardly be matched using the system's formatter, it was updated to match that of the CPE. Fixed: 364321808

Chromium change: https://chromium.googlesource.com/chromium/src/+/55591fe55f080 commit 55591fe55f080ae05af8645e85d465d01fdfe423 Author: Tanmoy Mollik <[email protected]> Date: Thu Sep 26 12:00:35 2024 +0000 [Android] Move c/b/android/signin to c/b/signin/android

Chromium change: https://chromium.googlesource.com/chromium/src/+/cccd6f3ea74cf commit cccd6f3ea74cf6e853c9bc414ad2ae59eea1660a Author: Ari Chivukula <[email protected]> Date: Mon Sep 30 10:32:18 2024 +0000 Clean up stale base::Feature "PermissionDedicatedCpssSettings" This isn't in an active finch trial and is enabled by default, looks like we can clean up some old code too. Fixed: 362247684

Chromium change: https://chromium.googlesource.com/chromium/src/+/26e362a469ca5 commit 26e362a469ca59e50670ee4c46809db9acb55db5 Author: Juan Mojica <[email protected]> Date: Fri Sep 27 17:58:29 2024 +0000 [csc] Remove more failing companion tests. Bug: b:348678854

Presubmit: ../../brave/android/java/org/chromium/base/BraveReflectionUtil.java:43: warning: [UnnecessaryParentheses] These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them assert (false); ^ (see https://errorprone.info/bugpattern/UnnecessaryParentheses) Did you mean 'assert false;'?

Chromium change: https://source.chromium.org/chromium/chromium/src/+/e4f2e2ba1f825f208b2fb3c841cd9812dbf0e478 commit e4f2e2ba1f825f208b2fb3c841cd9812dbf0e478 Author: Mark Cogan <[email protected]> Date: Mon Sep 30 13:04:33 2024 +0000 [iOS] Updates various files under ios/chrome/browser/h* and m* This CL replaces: * ChromeBrowserState => ProfileIOS * GetForBrowserState => GetForProfile at call sites. * GetBrowserState => GetProfile * browser_state, browserState => profile * GetOriginal(Chrome)BrowserState => GetOriginalProfile * HasOffTheRecordChromeBrowserState => HasOffTheRecordProfile * GetOffTheRecordChromeBrowserState => GetOffTheRecordProfile * DestroyOffTheRecordChromeBrowserState => DestroyOffTheRecordProfile * CreateAndInitializeForBrowserState => CreateAndInitializeForProfile * GetCurrentIncognitoBrowserState => GetCurrentIncognitoProfile Test case names using "BrowserState" are updated. Instances of GetForBrowserState that are no longer used are removed. web::BrowserState code is not updated. Bug: 365530626, 365530662, 365528542

There were added new lint checks in C131. This commit fixes the following warnings: warning: [UnnecessaryParentheses] These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them warning: [OperatorPrecedence] Use grouping parenthesis to make the operator precedence explicit warning: [NarrowCalculation] This product of integers could overflow before being implicitly cast to a long warning: [NarrowCalculation] This division will discard the fractional part of the result, despite being assigned to a float warning: [ImmutableEnumChecker] enums should be immutable warning: [Finalize] Do not override finalize warning: [DoubleBraceInitialization] Prefer collection factory methods or builders to the double-brace initialization pattern warning: [UnusedTypeParameter] This type parameter is unused and can be removed warning: [UnnecessaryStringBuilder] Prefer string concatenation over explicitly using `StringBuilder#append`, since `+` reads better and has equivalent or better performance

This component was being always disabled, however it is not gone. Chromium change: https://chromium.googlesource.com/chromium/src/+/780ac3d348f37a20cccefcfc4b84ab4ea898b000 commit 780ac3d348f37a20cccefcfc4b84ab4ea898b000 Author: Juan Mojica <[email protected]> Date: Wed Oct 2 19:17:21 2024 +0000 [companion] Remove the VQS feature. The companion is deprecated and set for removal. Removing VQS as a first step in order to prevent one large monolith CL. Bug: b:348678854

This build failure seems to be the result of changing transient inclusions.

This function is now part of the factory class, to avoid cycle dependencies. Chromium change: https://chromium.googlesource.com/chromium/src/+/a2fde5d151ccd61bd964238ea9ed82ff13e593d0 commit a2fde5d151ccd61bd964238ea9ed82ff13e593d0 Author: Victor Hugo Vianna Silva <[email protected]> Date: Wed Oct 2 22:21:50 2024 +0000 Avoid cyclic dep between NotificationDisplayService and its factory NotificationDisplayService::GetForProfile() is unnecessary, the factory can be used directly. No behavior change, this CL is just search&replace + tools/add_header.py. Bug: 368246456

This code seems to be playing around some different way to get `GaiaCookieManagerService` to trigger `ListAccount`. This change removes the method we have, which is now broken, and uses the way provided in the type interface. Chromium change: https://chromium.googlesource.com/chromium/src/+/3e1f3b460901355ebb7d2e5c274527be93411f51 commit 3e1f3b460901355ebb7d2e5c274527be93411f51 Author: Boris Sazonov <[email protected]> Date: Wed Oct 2 09:49:02 2024 +0000 [Signin] Use AccountsInCookieJarInfo in ListAccounts and OnGaiaAccountsInCookieUpdated Before this CL, GaiaCookieManagerService interface was based on two std::vector<gaia::ListedAccount>, which were immediately converted into AccountsInCookieJarInfo by IdentityManager. This was making it harder to change AccountsInCookieJarInfo API (and was also somewhat clunky for tests). This CL changes GaiaCookieManagerService API so that it exposes AccountsInCookieJarInfo directly, facilitating API changes in subsequent CLs. To adjust to the new API, significant changes were needed in gaia_cookie_manager_service_unittest.cc, so some parts of that file were revised to improve consistency and readability. Bug: 324462717

This only affects a few overrides, and the value itself gets passed along. Chromium change: https://chromium.googlesource.com/chromium/src/+/1906ce629724800bc36d91c94ad2ca7f5c38f936 commit 1906ce629724800bc36d91c94ad2ca7f5c38f936 Author: Dave Tapuska <[email protected]> Date: Thu Oct 3 19:28:23 2024 +0000 Convert canvas code to use bindings enumerations We had needless conversions from strings -> enums and back. Bug: 366411876, 370425456 Change-Id: Ic2bd5e0b459760d34187a35f2ca47fd38aec8cf2

These `nullptr` derefs are taking place on unit tests instantiating `BookmarkContextMenuController` with no `BookmarkMergedSurfaceServiceFactory` instance provided to the profile builder. Chromium change: https://chromium.googlesource.com/chromium/src/+/5b4ef906cf8425b4ecca1dfa17261baafdb78561 commit 5b4ef906cf8425b4ecca1dfa17261baafdb78561 Author: Monica Basta <[email protected]> Date: Wed Oct 2 15:40:46 2024 +0000 [B4B-D] Update BookmarkContextMenuController to use BookmarkMergedSurfaceService This CL includes no change of behavior. It is a preparation to support Butter for bookmarks on desktop for UIs that merges account and local bookmark. The first step is to migrate those UIs to use `BookmarkMergedSurfaceService`. `BookmarkContextMenuController` is the menu that shows on right-click on a bookmark. It shouldn't care about the order of bookmarks but the count and the bookmark urls. The params passed in its constructor `parent` should be the parent for new nodes while `selection` should contain both local and account permanent nodes for the case of Bookmark bar, all bookmarks button...etc. This is not handled in this CL and will be updates with the callers of this class. Bug: b/369304373, b/364594278

These cases will be left on the unsupported side, as we do not support `SoftwareProfider`, or `SoftwareRSA`. Chromium change: https://chromium.googlesource.com/chromium/src/+/649869eb96e3df8e86c94dcc7706d623d53a73a0 commit 649869eb96e3df8e86c94dcc7706d623d53a73a0 Author: Kristian Monsen <[email protected]> Date: Fri Oct 4 18:35:34 2024 +0000 Add RSA software unsecure provider Most of the dbsc unit tests are based on the unsecure crypto provider due to better latency and reliability. Adding an RSA provider to be able to increase test coverage. Bug: 353766139

It looks like we had tried in the past to avoid `Init` substitutions on some `std` header file. This change properly preempts the inclusion chain for the unwanted substitution.

With the introduction of lit, these polymer checks are being removed, as lit will be used both on ios and android. This change replaces all `include_polimer` checks to merely be checks for not ios and android. Chromium change: https://chromium.googlesource.com/chromium/src/+/27af2840dc73c5e5a0cb13e368b2a44820ba7431 commit 27af2840dc73c5e5a0cb13e368b2a44820ba7431 Author: dpapad <[email protected]> Date: Mon Oct 7 23:55:53 2024 +0000 FlagsUI: Leverage cr-button instead of a custom button. As part of this change, several changes are needed to make cr_button.ts available on Android and iOS builds. Bug: 40246381

Chromium change: https://chromium.googlesource.com/chromium/src/+/39641ed514b688f531b4de88b30f2222dbb6ff3a commit 39641ed514b688f531b4de88b30f2222dbb6ff3a Author: Antonio Gomes <[email protected]> Date: Thu Oct 3 00:58:30 2024 +0000 Modularize chrome/browser/ui/hid This CL adds to chrome/browser/ui/hid its own BUILD.gn file, so it has its own GN targets, cleaning chrome/browser/ui/BUILD.gn and better defining dependencies across modules. [email protected] Bug: 370804668

Chromium change: https://chromium.googlesource.com/chromium/src/+/a2fb619d8dc2437b2e1825cc04f97538bfff0b47 commit a2fb619d8dc2437b2e1825cc04f97538bfff0b47 Author: Antonio Gomes <[email protected]> Date: Thu Oct 3 02:21:31 2024 +0000 Extract url_identity.cc|h into their own GN target ... sibling to //c/b/ui:ui. Ths work here is done in the context of the modularization of //c/b/ui:hid. In practice, it allows the modularization of //c/b/chooser_controller/ to take place, and later the removal of the circular dependency between //c/b:browser and //c/b/ui:hid. [email protected] Bug: 370804668

Chromium change: https://source.chromium.org/chromium/chromium/src/+/1281ce90e172379572151dcaed23bb268a2d64b0 [Android] Migrate LocaleManagerDelegate to ServiceLoaderUtil Cq-Include-Trybots: luci.chrome.try:android-internal-rel,android-internal-binary-size Bug: 40901855

Chromium change: https://source.chromium.org/chromium/chromium/src/+/6887cdbbde3ff83ba930bd24f5e223c08d16d471 Android: Adopt ServiceLoaderUtil for SearchEngineCountryDelegate Bug: 40901855

Chromium change: https://source.chromium.org/chromium/chromium/src/+/78b03df18d4625181de54bf6a7efa805c20b367d Move base.cached_flags to components.cached_flags We will need to depend on components/variations to support fieldtrial_testing_config.json. Since base can't use cached flags, and many clients of base won't either, it makes more sense to put it in components. Bug: 370797986

Chromium change: https://source.chromium.org/chromium/chromium/src/+/696283b120c52f3adeafe40b96a1607fb14f5718 Reapply "[Autofill][Passwords] Split //c/b/touch_to_fill" This is a clean reland of crrev.com/c/4994310. It's produced by reverting the revert crrev.com/c/5015784 $ git revert ccfd1cf9e278a79425e2170fa96239208a87214b because Gerrit's "Create Reland" reports a merge conflict with HEAD. The revert was due to a failing presubmit script, which is fixed by crrev.com/c/5012716. Gardeners: please ping before reverting. Bug: 1498976, 1500689, 1500689

Chromium change: https://source.chromium.org/chromium/chromium/src/+/4e75e680857aa2e0f2364e0977bba5eddfe048f0 [Anchor] Introduce an empty ToolbarLongPressMenuHandler.java This CL provides the skeleton for the toolbar long-press menu functionality. Change-Id: Icf06372970f9f19befe97d4dc82e0450a2ab356a

Chromium change: https://source.chromium.org/chromium/chromium/src/+/aed9e53b463e687a70b2f5db0ad5299bdde31168 [Anchor] Add ToolbarPositionController This class is currently functionless except for a static util to check if the device supports position customization. Bug: 369133658

Chromium change: https://source.chromium.org/chromium/chromium/src/+/79741f6bd5052dbfb30025c44f4b6851cb664e38 [Settings] Rename SettingsLauncher to SettingsNavigation Now that SettingsLauncher provides a method to go back to the previous page, it makes more sense to replace "launcher" in its name to something more generic. This patch renames SettingsLauncher and its friends to SettingsNavigation. Also, methods in the interface are renamed to drop mentions of "activity" since they don't necessarily start a new activity in the single-activity mode. Summary of changes: - SettingsLauncher -> SettingsNavigation (w/ variants) - launchSettingsActivity -> startSettings - createSettingsActivityIntent -> createSettingsIntent - finishCurrentFragment -> finishCurrentSettings Bug: b/356743945

Follow up to #25771

Chromium change: https://source.chromium.org/chromium/chromium/src/+/7fe4e803bdd1ff1a5d45231e88480536bb00d887 commit 7fe4e803bdd1ff1a5d45231e88480536bb00d887 Author: Teresa Mao <[email protected]> Date: Mon Oct 7 22:46:42 2024 +0000 WebUI: Migrate NewTabUI to WebUIConfig. Bug: 40222519

This is a simple header inclusion/shadow file fix. Chromium change: https://chromium.googlesource.com/chromium/src/+/d004977e47c6aff2833c145caa7c183993f56524 commit d004977e47c6aff2833c145caa7c183993f56524 Author: Alex Rudenko <[email protected]> Date: Tue Oct 8 14:19:19 2024 +0000 [DevTools] move feature flags to the devtools directory As instructed by the comment in chrome/browser/browser_features.h that indicates that new feature flags should not be added to chrome/browser/browser_features.h Fixed: 370684557

This "learn more" link is shown for an AI settings page, and it doesn't apply to brave. Chromium change: https://chromium.googlesource.com/chromium/src/+/fc8347ee8e44e4adb3bae918ed7d0fc36fa9ad7b commit fc8347ee8e44e4adb3bae918ed7d0fc36fa9ad7b Author: Zaina Al-Mashni <[email protected]> Date: Tue Oct 8 18:21:37 2024 +0000 [Synapse] Open HC article from themes row Bug: 362225975

This is an immaterial change to our use of this class. Chromium change: https://chromium.googlesource.com/chromium/src/+/2d06b51d4aadd635a65856bc6323ec0bdc460090 commit 2d06b51d4aadd635a65856bc6323ec0bdc460090 Author: Boris Sazonov <[email protected]> Date: Tue Oct 8 10:37:37 2024 +0000 [Signin] Add AccountsInCookieJarInfo::GetAllAccounts Adds AccountsInCookieJarInfo::GetAllAccounts method that exposes all accounts in cookies in the same order as returned by ListAccounts. To do this, this CL also changes how AccountsInCookieJarInfo constructor gets the list of accounts - it now does all the filtering for various getters inside the constructor. Bug: 324462717

This is merely a renaming of the constant scope. Chromium change: https://chromium.googlesource.com/chromium/src/+/67c9ae7503c8705fc628a28d7fec7e6b1318dd31 commit 67c9ae7503c8705fc628a28d7fec7e6b1318dd31 Author: David Bertoni <[email protected]> Date: Wed Oct 9 22:00:33 2024 +0000 [Extensions] Clean up dependencies on tabs API constants. Multiple dependency cycles are created by other APIs and lower-level code relying on constants defined in the tabs API directory. This CL breaks these cycles by doing the following: 1. Constants that are used across APIs and lower-level code are moved into ExtensionTabUtil. 2. Constants that are used only in.cc files are moved into those files. 3. One constant is added to extensions/common/constants.h. This will eventually be used in other places in Extension code. 4. Constants that are only used in the tabs API directory remain in tab_constants.h. 5. Constants that are no longer referenced anywhere are removed. Bug: 40593486

`GetAccessibleNodeData` has been deleted. This change merges the two substitution into one, using `CloseButtonPressed` as the anchor as we need to virtualise it anyway. Chromium change: https://chromium.googlesource.com/chromium/src/+/0d780729a481d154faca39772062f7ac917838d0 commit 0d780729a481d154faca39772062f7ac917838d0 Author: Javier Contreras Tenorio (from Dev Box) <[email protected]> Date: Wed Oct 9 22:08:42 2024 +0000 [views-ax] Migrate remaining Views a11y attributes to new system The AXNodeData migration in Views is nearing completion, so we are going back and cleaning up any remaining views whose attributes have not been migrated. These are very simple migrations that for the most part just need to be moved to the ctor. This CL is part of the ViewsAX project: https://docs.google.com/document/d/1Ku7HOyDsiZem1yaV6ccZ-tz3lO2XR2NEcm8HjR6d-VY/edit#heading=h.ke1u3utej413 Bug: 325137417

This is yet another "Learn More" link for the settings AI page that we are not providing. Chromium change: https://chromium.googlesource.com/chromium/src/+/e57265db20c0352a7055c8c3ca2c572561a7b000 commit e57265db20c0352a7055c8c3ca2c572561a7b000 Author: Zaina Al-Mashni <[email protected]> Date: Wed Oct 9 17:59:08 2024 +0000 [Synapse] Remove toggle from tab organization subpage Remove toggle and add a "learn more" HC link to the tab organization row in the subpage. Screenshot: https://screenshot.googleplex.com/UYs6WWU3UpDhQ7R Bug: 362225975

Chromium change: https://chromium.googlesource.com/chromium/src/+/d004977e47c6aff2833c145caa7c183993f56524 commit d004977e47c6aff2833c145caa7c183993f56524 Author: Alex Rudenko <[email protected]> Date: Tue Oct 8 14:19:19 2024 +0000 [DevTools] move feature flags to the devtools directory As instructed by the comment in chrome/browser/browser_features.h that indicates that new feature flags should not be added to chrome/browser/browser_features.h Fixed: 370684557

@param

List of the fixed warning types: warning: [ClassCanBeStatic] Inner class is non-static but does not reference enclosing class warning: [AlmostJavadoc] This comment contains Javadoc or HTML tags, but isn't started with a double asterisk warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description. warning: [ObjectToString] DisplayAd is final and does not override Object.toString, so converting it to a string will print its identity (e.g. `DisplayAd@4488aabb`) instead of useful information.

We don't use it since we have our own private tab UI. Chromium change: https://source.chromium.org/chromium/chromium/src/+/11bd4c71e1f22d72e63396f8b47ec3a5ab1957c7 Reland "Use Chrome's fading shadow implementation for IncognitoNTP" This is a reland of commit 4db7d8944ecd4c49a744497b20a94d74687f3b6b The CL was causing device offline on Android 13+ due to crash from emulator GPU mode swiftshader. We have switched the GPU mode to swangle on Android 13 and 15, and the CL runs fine on these builders. (Android 14 builder is not switched. But it is not gardened yet so OK to leave it as broken, and it is easy to make the switch) Original change's description: > Use Chrome's fading shadow implementation for IncognitoNTP > > Replace the view's fading shadow into Chrome's FadingShadowView and > FadingEdgeScrollView. This is a workaround that #requiresFadingEdge > doesn't work with #clipToPadding for ScrollView. > > Before (not edge to edge): > https://screenshot.googleplex.com/9XESPLDvzviZ5cJ > After: > https://screenshot.googleplex.com/83Kd2unzVMBjEvr > > Bug: 365607068 > Change-Id: Ia156e10712de32f7141f379e1926fbcb3251caf0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5846890 > Code-Coverage: [email protected] <[email protected]> > Reviewed-by: Christian Dullweber <[email protected]> > Reviewed-by: Lijin Shen <[email protected]> > Commit-Queue: Wenyu Fu <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1357331} Bug: 365607068, 370084605

Chromium change: https://source.chromium.org/chromium/chromium/src/+/a94a47d595aa23f7b69db524f490a8bc3559246c Android: Fix UnusedVariable Error Prone warnings in //chrome/browser Found by un-disabling the check within compile_java.py Bug: 372458640

Chromium change: https://source.chromium.org/chromium/chromium/src/+/6de234baff1d12fdb8224d12667853ab4fe4c0b1 [Tab Model] Split TabModelFilter into interface and ABC See bug for details on phasing. This is phase 1 which splits the TabModelFilter into an interface and a base class. The base class will go away once all phases are finished. Bug: 372068933

Chromium changes: https://source.chromium.org/chromium/chromium/src/+/df77cbacb9476b0b6d3e75cc34b5d127985e79c3 [Settings] Enable the single-activity mode by default Bug: b/356743945 https://source.chromium.org/chromium/chromium/src/+/cd5fd3e6bcef39a904578857a4c1ab2419efacec [Settings] Add a method to finish the current fragment Some settings page need to finish when the user is done with them. Previously we used getActivity().onBackPressed() to perform this, but we might want to handle finish and back gesture differently, and also it might have unintended interaction with metrics. This patch introduces a canonical method for settings fragments to declare that they are finished and the settings activity should show the previous fragment. We added the new method to SettingsLauncher because existing methods are somewhat similar to the new one (handling navigation). In a later change we plan to rename it to reflect the new addition. Bug: b/356743945

Chromium change: https://source.chromium.org/chromium/chromium/src/+/d004977e47c6aff2833c145caa7c183993f56524 [DevTools] move feature flags to the devtools directory As instructed by the comment in chrome/browser/browser_features.h that indicates that new feature flags should not be added to chrome/browser/browser_features.h Fixed: 370684557

This change corrects the type reference, but it also renames the local variables to reflect the new type. Chromium changes: https://chromium.googlesource.com/chromium/src/+/c521bd420a710b3699c528540b94383aa74f602d https://chromium.googlesource.com/chromium/src/+/fedc5005177316fc76dabf526ff9e105a049fe5b commit c521bd420a710b3699c528540b94383aa74f602d Author: Aliona DANGLA <[email protected]> Date: Wed Oct 9 08:35:42 2024 +0000 [iOS] Updates files under ios/chrome/browser/shared Fixed: 365532210, 370949567, 358060031, 358059298, 361071553 commit fedc5005177316fc76dabf526ff9e105a049fe5b Author: Aliona DANGLA <[email protected]> Date: Wed Oct 9 09:42:48 2024 +0000 [iOS] Remove GetBrowserState function Fixed: 358301380, 369816840, 365531685, 365529650

This provider is required for our linking. Chromium change: https://chromium.googlesource.com/chromium/src/+/efca6d6cbe579048507390bd803d49039e9951db commit efca6d6cbe579048507390bd803d49039e9951db Author: Gauthier Ambard <[email protected]> Date: Tue Oct 8 15:16:36 2024 +0000 [iOS] Use provider for ShareKitFactory Now that we have an implementation of the provider everywhere, use it in the factory to create the service. Bug: 358373145

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/beb0649ca837e commit beb0649ca837e64e0448b618dd46de480183d65b Author: Teresa Mao <[email protected]> Date: Tue Oct 8 20:35:15 2024 +0000 WebUI: Migrate SettingsUI to WebUIConfig. Bug: 40222519 Fixed: 361535277

The constructor is the correct way to pass a vector. Chromium change: https://chromium.googlesource.com/chromium/src/+/64539de59ddc802c4c05407f04ae4c4699ac1596 commit 64539de59ddc802c4c05407f04ae4c4699ac1596 Author: Avi Drissman <[email protected]> Date: Thu Oct 10 22:32:27 2024 +0000 Remove RefCountedBytes::TakeVector It's not needed, as there's a constructor. Fixed: 372269603

The `TabDeclutterController` instance was being retrieved through `Browser*`, however there's some work to make different UI components to not have to rely on the browser instance for things of this kind. This change plumbs `tabs::TabDeclutterController*` through our classes so it can reach its required place. Chromium change: https://chromium.googlesource.com/chromium/src/+/9e5aae5a1ca1015b37c504c0668d46eb87946664 commit 9e5aae5a1ca1015b37c504c0668d46eb87946664 Author: Thomas Lukaszewicz <[email protected]> Date: Thu Oct 10 17:26:14 2024 +0000 [tab search] Pass TabDeclutterController to TabSearchBubbleHost Currently TabSearchBubbleHost is using its GetBrowser() accessor to gain access to the required TabDeclutterController. Current guidance is that direct dependencies on Browser should be avoided, instead feature code should compose their specific dependencies. This CL updates TabSearchBubbleHost to instead compose the required TabDeclutterController directly instead of relying on Browser. Follow up work will further refactor TabSearchBubbleHost to eliminate the Browser dependency completely and, composing only what is necessary. Bug: 371774521

`crypto::SymmetricKey` has been deprecated and the methods it was being used for have been simplified and moved into `crypto::kdf`. This cahnges adds support for our own overrid of `SymmetricKey`, adding our own `DeriveKeyPbkdf2HmacSha256` into the `kdf` header. Chromium change: https://chromium.googlesource.com/chromium/src/+/4046edfc95050796d4a1bc54cdba6942257b6f38 commit 4046edfc95050796d4a1bc54cdba6942257b6f38 Author: Elly <[email protected]> Date: Thu Oct 10 20:51:36 2024 +0000 crypto: add kdf interface Right now, //crypto supports KDFs via two interfaces: * PBKDF2-HMAC-SHA1 and Scrypt on crypto::SymmetricKey * HKDF-SHA256 via free functions This change: * Adds crypto::SubtlePassKey for access to subtle crypto primitives * Creates a new KDF interface * Moves the PBKDF2-HMAC-SHA1 and Scrypt implementations to that interface, and guards them with SubtlePassKeys * Adds new unit tests covering those KDFs * Deprecates SymmetricKey * Deletes many of the unit tests for SymmetricKey, which either covered logic which is now moved to the KDF implementations (and is covered by their tests) or tested key lengths we don't allow in production. Bug: 369653192, 369649346

This is a simple rename from a user's perspective. Chromium change: https://chromium.googlesource.com/chromium/src/+/1eadd223cce221615fa18db6647451a26a0315a2 commit 1eadd223cce221615fa18db6647451a26a0315a2 Author: Gaurav Kumar <[email protected]> Date: Fri Oct 11 07:51:41 2024 +0000 [views-ax] Migration of kName attribute in Tab This CL migrates the kName attribute in views to be updated whenever its value should change, rather than querying the value and computing it only when needed. As part of this change, the following views are updated: Tab, BrowserView, PermissionChipView, and TabSlotView. The Tab class extends TabSlotView. BrowserView::GetAccessibleTabLabel constructs the accessible name for a tab by gathering various properties such as the title, group, memory usage, and possibly other elements like permission chips, to create a comprehensive and accurate label. This CL is part of the ViewsAX project: https://docs.google.com/document/d/1Ku7HOyDsiZem1yaV6ccZ-tz3lO2XR2NEcm8HjR6d-VY/edit#heading=h.ke1u3utej413 Bug: 325137417

This new url value is being replicated in brave's shadow file. For the most part, it is not consequential to repeat its value, because this is a `chrome://` url, and this is about history UI features that we are most likely hinding. Chromium change: https://chromium.googlesource.com/chromium/src/+/6201548495aa32b46a128ff7bbfd259765d6017d commit 6201548495aa32b46a128ff7bbfd259765d6017d Author: Zaina Al-Mashni <[email protected]> Date: Fri Oct 11 15:30:22 2024 +0000 [Synapse] Update History Search promos to point to the new route If the AiSettingsPageRefresh is enabled, History Search settings route is chrome://settings/ai/historySearch. This change updates the remaining linkouts to the old History Search route. Bug: 362225975

The new naming is `kColorOmniboxIcon*`. Chromium change: https://chromium.googlesource.com/chromium/src/+/e692b50e20ea51f29aa26869b385858e6d95c91e commit e692b50e20ea51f29aa26869b385858e6d95c91e Author: Elias Klim <[email protected]> Date: Mon Oct 14 09:50:26 2024 +0000 Fix Google Lens button font color This CL fixes text color for Google Lens Omnibox button for custom theme. It adds kColorOmniboxIconForeground with values of kColorPageInfoForeground. The only difference is ui::GetColorWithMaxContrast(kColorToolbar) for a custom theme. Additionally, this CL refactors incorrectly names PageInfo colors. Particularly, multiple colors with names kColorPageInfo are used only in Omnibox as icon colors. Hence all such colors were renamed to kColorOmniboxIcon. Screenshots: https://g-issues.chromium.org/issues/372632553#comment6 Bug: 372632553

Chromium implementation of DeriveKeyScrypt has a CHECK in it that would crash the browser if the underlying BoringSSL function failed. We use this code from HDKey::GenerateFromV3UTC where the data is retrieved from JSON and can't be guaranteed to always be valid. In order not to crash, added DeriveKeyScrypt implementation without the CHECK and also changed our DeriveKeyPbkdf2HmacSha256 implementation to no use CHECK either. Additionally, moved HDKey::GenerateFromV3UTC code to use DeriveKeyScrypt and DeriveKeyPbkdf2HmacSha256 directly instead of using SymmetricKey wrappers that are being deprecated. Chromium change: https://chromium.googlesource.com/chromium/src/+/4046edfc95050796d4a1bc54cdba6942257b6f38 commit 4046edfc95050796d4a1bc54cdba6942257b6f38 Author: Elly <[email protected]> Date: Thu Oct 10 20:51:36 2024 +0000 crypto: add kdf interface Right now, //crypto supports KDFs via two interfaces: * PBKDF2-HMAC-SHA1 and Scrypt on crypto::SymmetricKey * HKDF-SHA256 via free functions This change: * Adds crypto::SubtlePassKey for access to subtle crypto primitives * Creates a new KDF interface * Moves the PBKDF2-HMAC-SHA1 and Scrypt implementations to that interface, and guards them with SubtlePassKeys * Adds new unit tests covering those KDFs * Deprecates SymmetricKey * Deletes many of the unit tests for SymmetricKey, which either covered logic which is now moved to the KDF implementations (and is covered by their tests) or tested key lengths we don't allow in production. Bug: 369653192, 369649346

Chromium change: https://source.chromium.org/chromium/chromium/src/+/65eee63c0e75ebd343c409a7c14addb00ca4b6dd [Tab Model] Deprecate tab_groups package Merge the tab_groups/ package into tabmodel/. The two packages have significant overlap and should really have a lot of their logic merged anyway. This allows us to package protect TabGroupModelFilterInternal and make destroy method package private as well. Fixed: 372068933

Chromium change: https://source.chromium.org/chromium/chromium/src/+/db64d75a6190bc6f3b1014ba0462f391b2b35135 [bookmarks] Fetch favicons from google if they're not found locally Bug: 368130323,368683034

Chromium change: https://source.chromium.org/chromium/chromium/src/+/3d4bd05bd10bced9902f9dd06cf1ad19389c6ba2 Add EdgeToEdgeStateProvider to replace usage of #setDecorFitsSystemWindows Bug: 369841366

Chromium change: https://source.chromium.org/chromium/chromium/src/+/d15dc67556629c7f39c418cd6b81e03c48eee30c [UPMAccessLossWarning] Add export flow final step metric The new metric tracks the last step that the user took as part of the export flow. Change-Id: I5db5c776b476c49160b39e3f27ee0a50bd8a4d41

The drop shadow on window has changed.

Follow up issues exist/created: * brave/brave-browser#29631 * brave/brave-browser#41674

Chromium's last id went up again and was conflicting with our ids (specifically on MacOS causing a crash constructing Help menu).

…0.6779.1.

This flag was already entirely gutted, so it was no-op. Chromium change: https://chromium.googlesource.com/chromium/src/+/7481666f1005dfd844d7f31d95f353b0a48000b7 commit 7481666f1005dfd844d7f31d95f353b0a48000b7 Author: Kene Okoye <[email protected]> Date: Tue Oct 15 16:30:42 2024 +0000 [PS] ProactiveTopicsEnabled: Remove ProactiveTopicsBlocking flag Bug: 356411190

This must be due to some transient inclusion changing.

This function wasn't even being used in upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/1911cb516aaf7a32618101b968ba9ad339c18632 commit 1911cb516aaf7a32618101b968ba9ad339c18632 Author: Joshua Pawlicki <[email protected]> Date: Tue Oct 15 15:41:56 2024 +0000 update_client: Remove EnabledDeltas from Configurator. This function is no longer ever called. Bug: 353249967

Chromium change: https://chromium.googlesource.com/chromium/src/+/6dd962b30f8540dcbdd48a31e5b51f788924ff21 commit 6dd962b30f8540dcbdd48a31e5b51f788924ff21 Author: Erik Chen <[email protected]> Date: Tue Oct 15 22:02:41 2024 +0000 Reduce fragility in SidePanelCoordinator (part 15 / N) This CL simplifies registration and deregistration of side panel entries. The SidePanelRegistry now has logic that checks if an entry that is about to be deregistered is showing. If so, it synchronously closes the side panel. All other logic coupling registration/deregistration with showing/closing the side panel was removed. This logic was spread across several files but was only intended for extensions. User visible side-effects: * If an active tab-scoped entry is deregistered, the side panel will close as opposed to falling back to the window-scoped side panel. This change intentionally makes the deregister flow identical to the close flow. * Registering a tab-scoped entry will have no effect on the currently showing side panel. Previously, if a window-scoped entry with the same key was showing, the side panel would switch to the tab-scoped entry. * Disabling the tab-scoped side panel for a tab no longer prevents the window-scoped side panel for showing on that tab. Non user-visible side effects: * Many tests are no longer necessary as the new behavior is simpler. * The mechanism to get the cached view from a deregistered entry is no longer necessary. * The logic that dynamically registered/deregistered the extension window-scoped side-panel based on active tab is no longer necessary. Bug: 363743081

For some reason, the compiler started warning an unused variable in our `OmniboxResultView` overrides. This variable does seem to have been unused for a while now, so it is not clear why it wasn't erroring out before. This change adds an override to make sure the variable is declared with `[[maybe_unused]]`. Chromium change: https://chromium.googlesource.com/chromium/src/+/50b3de003c47ec7a4d3347fa296c4072864dcfcb commit 50b3de003c47ec7a4d3347fa296c4072864dcfcb Author: manukh <[email protected]> Date: Tue Oct 15 19:38:31 2024 +0000 [omnibox][history-embeddings] UI work for v2 history embedding answers - Adds new color `kColorOmniboxResultsTextAnswer` and typography `CONTEXT_OMNIBOX_POPUP_LOCAL_ANSWER_HEADER` since the answer text color & size is different than the existing text colors in the omnibox. - Adds a new view OmniboxLocalAnswerHeaderView to represent the '<icon> Summary' or '<icon> Generating...' header messages above answers. In a followup CL, we might also add the separator in this view. This is lazily loaded when an answer match is needed, because some omnibox comment mentioned not lazy-loading rarely used views was increasing latency. - Moves the block of code that sets content & descriptions from `OmniboxResultView` to `OmniboxMatchCellView`. It didn't make sense for the grandparent of the render texts to be fetching & updating the render text. Especially since `OmniboxMatchCellView` already handles updating all its other children, so why should content and descriptions be any different. - Adds a new `LayoutStyle::ANSWER` to `OmniboxMatchCellView` to style answer matches differently than other matches. - Replaces `kMargin` with `kRowHeight`. Before, the row height was derived by adding `kMargin` * 2 to the image heights. Using `kRowHeight` directly seems less error-prone and easier to reuse without duplicating the computation. - Updates the match selection background corner radius from 40 to 20. 40 was incorrect, but it didn't matter since row height was 40 so the radii were capped to 20 anyways. But since answers have higher row height, the distinction now matters. - Add support for multiline `OmniboxTextView`. Also, cache its size. The base class `View` already has a size cache mechanism, but we can't use that since our items change size as the user types or resizes their window. So added a custom cache for the last available size & computed size; so when the available size changes, we can ignore the cached computed size. - Grouped history embedding answers below other suggestions, except IPH. They're expected to be slow and visually loud, so ranking them above other suggestions would be disruptive. - Hid switch-to-tab button on history embedding answers. - Added new feature param `kAnswersInOmniboxScoped` to guard this. - Using a hardcoded mock answer for now so this CL can focus on just view changes. A followup CL will plug in the answer from the service. Bug: 364303536

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/c0be837dd32c9c92ec22d6b3d43ec414d0c0bc2c OTR to [oO]tr in java code. Bug: 372670589 Change-Id: I6d5aaa3b5b8af401e09c1990e12bfc889e93815c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924233

Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/aecab74413e302b929bc8d6f6274e5ec02c34e2e Clean up irrelevant AutocompleteMatch fields Change-Id: If11fa90715a6d0a9047e79f96b3bb32b67db0ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5935117

…0.6781.1.

This reverts commit 67a142b.

In cr132, SidePanelCoordinator::OnEntryWillDeregister() is removed. We relied on it to deregister observed entry from SidebarContainerView. Instead, we'll use OnEntryWillHide() callback. It'll be called when side panel is closed. At that time, we could remove observing it safely, and will start to observe again if that entry is still live in tab's registry.

This arg passing to make the semantics clearer, and avoid hidden copies. Chromium change: https://chromium.googlesource.com/chromium/src/+/9085ad7f8069691579c17d5f2046ac4d61f9010d commit 9085ad7f8069691579c17d5f2046ac4d61f9010d Author: Sorin Jianu <[email protected]> Date: Wed Oct 16 21:57:32 2024 +0000 update_client,updater,cus: take optional types by value https://abseil.io/tips/163 Change-Id: Iad5543266f6135a18c4e7f4fe3a3c5060183b0d8

The return type of `NoSideEffectsToMaybeString` has been changed in this migration. Chromium change: https://chromium.googlesource.com/v8/v8/+/a244268ac8ead1cf2ff145f17914d6d83aa6a00c commit a244268ac8ead1cf2ff145f17914d6d83aa6a00c Author: Nikolaos Papaspyrou <[email protected]> Date: Tue May 7 10:34:23 2024 +0200 [handles] Migrate handles in error message generation to direct This CL migrates some string and error message handles, most of them passed as parameters to error message generation methods, to direct. (This is only relevant for builds with v8_enable_direct_handle=true.) Bug: b/42203211

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Canary #17450

Canary #17450

Commits on Oct 17, 2024

Canary #17450

Are you sure you want to change the base?

Canary #17450

Commits on Oct 17, 2024