Canary #17450
Draft
Canary #17450
+72,725
−3,947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/run-audit-deps
cdesouza-chromium
force-pushed
the
canary
branch
2 times, most recently
from
fe640c8
to
7b3bfc0
Compare
cdesouza-chromium
force-pushed
the
canary
branch
6 times, most recently
from
ccdfe5e
to
fe2c18c
Compare
cdesouza-chromium
force-pushed
the
canary
branch
4 times, most recently
from
7a0d373
to
b3dcdf1
Compare
cdesouza-chromium
force-pushed
the
canary
branch
from
b3dcdf1
to
08abd3f
Compare
cdesouza-chromium
force-pushed
the
canary
branch
from
8f6e2d9
to
f574e1a
Compare
cdesouza-chromium
force-pushed
the
canary
branch
5 times, most recently
from
5570187
to
6c5ec04
Compare
cdesouza-chromium
force-pushed
the
canary
branch
3 times, most recently
from
cc9efb3
to
8333203
Compare
cdesouza-chromium
force-pushed
the
canary
branch
from
c0db4fd
to
d1f69c8
Compare
Chromium change: https://source.chromium.org/chromium/chromium/src/+/65eee63c0e75ebd343c409a7c14addb00ca4b6dd [Tab Model] Deprecate tab_groups package Merge the tab_groups/ package into tabmodel/. The two packages have significant overlap and should really have a lot of their logic merged anyway. This allows us to package protect TabGroupModelFilterInternal and make destroy method package private as well. Fixed: 372068933
Chromium change: https://source.chromium.org/chromium/chromium/src/+/db64d75a6190bc6f3b1014ba0462f391b2b35135 [bookmarks] Fetch favicons from google if they're not found locally Bug: 368130323,368683034
Chromium change: https://source.chromium.org/chromium/chromium/src/+/3d4bd05bd10bced9902f9dd06cf1ad19389c6ba2 Add EdgeToEdgeStateProvider to replace usage of #setDecorFitsSystemWindows Bug: 369841366
Chromium change: https://source.chromium.org/chromium/chromium/src/+/d15dc67556629c7f39c418cd6b81e03c48eee30c [UPMAccessLossWarning] Add export flow final step metric The new metric tracks the last step that the user took as part of the export flow. Change-Id: I5db5c776b476c49160b39e3f27ee0a50bd8a4d41
The drop shadow on window has changed.
Follow up issues exist/created: * brave/brave-browser#29631 * brave/brave-browser#41674
Chromium's last id went up again and was conflicting with our ids (specifically on MacOS causing a crash constructing Help menu).
This flag was already entirely gutted, so it was no-op. Chromium change: https://chromium.googlesource.com/chromium/src/+/7481666f1005dfd844d7f31d95f353b0a48000b7 commit 7481666f1005dfd844d7f31d95f353b0a48000b7 Author: Kene Okoye <[email protected]> Date: Tue Oct 15 16:30:42 2024 +0000 [PS] ProactiveTopicsEnabled: Remove ProactiveTopicsBlocking flag Bug: 356411190
This must be due to some transient inclusion changing.
This function wasn't even being used in upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/1911cb516aaf7a32618101b968ba9ad339c18632 commit 1911cb516aaf7a32618101b968ba9ad339c18632 Author: Joshua Pawlicki <[email protected]> Date: Tue Oct 15 15:41:56 2024 +0000 update_client: Remove EnabledDeltas from Configurator. This function is no longer ever called. Bug: 353249967
Chromium change: https://chromium.googlesource.com/chromium/src/+/6dd962b30f8540dcbdd48a31e5b51f788924ff21 commit 6dd962b30f8540dcbdd48a31e5b51f788924ff21 Author: Erik Chen <[email protected]> Date: Tue Oct 15 22:02:41 2024 +0000 Reduce fragility in SidePanelCoordinator (part 15 / N) This CL simplifies registration and deregistration of side panel entries. The SidePanelRegistry now has logic that checks if an entry that is about to be deregistered is showing. If so, it synchronously closes the side panel. All other logic coupling registration/deregistration with showing/closing the side panel was removed. This logic was spread across several files but was only intended for extensions. User visible side-effects: * If an active tab-scoped entry is deregistered, the side panel will close as opposed to falling back to the window-scoped side panel. This change intentionally makes the deregister flow identical to the close flow. * Registering a tab-scoped entry will have no effect on the currently showing side panel. Previously, if a window-scoped entry with the same key was showing, the side panel would switch to the tab-scoped entry. * Disabling the tab-scoped side panel for a tab no longer prevents the window-scoped side panel for showing on that tab. Non user-visible side effects: * Many tests are no longer necessary as the new behavior is simpler. * The mechanism to get the cached view from a deregistered entry is no longer necessary. * The logic that dynamically registered/deregistered the extension window-scoped side-panel based on active tab is no longer necessary. Bug: 363743081
For some reason, the compiler started warning an unused variable in our `OmniboxResultView` overrides. This variable does seem to have been unused for a while now, so it is not clear why it wasn't erroring out before. This change adds an override to make sure the variable is declared with `[[maybe_unused]]`. Chromium change: https://chromium.googlesource.com/chromium/src/+/50b3de003c47ec7a4d3347fa296c4072864dcfcb commit 50b3de003c47ec7a4d3347fa296c4072864dcfcb Author: manukh <[email protected]> Date: Tue Oct 15 19:38:31 2024 +0000 [omnibox][history-embeddings] UI work for v2 history embedding answers - Adds new color `kColorOmniboxResultsTextAnswer` and typography `CONTEXT_OMNIBOX_POPUP_LOCAL_ANSWER_HEADER` since the answer text color & size is different than the existing text colors in the omnibox. - Adds a new view OmniboxLocalAnswerHeaderView to represent the '<icon> Summary' or '<icon> Generating...' header messages above answers. In a followup CL, we might also add the separator in this view. This is lazily loaded when an answer match is needed, because some omnibox comment mentioned not lazy-loading rarely used views was increasing latency. - Moves the block of code that sets content & descriptions from `OmniboxResultView` to `OmniboxMatchCellView`. It didn't make sense for the grandparent of the render texts to be fetching & updating the render text. Especially since `OmniboxMatchCellView` already handles updating all its other children, so why should content and descriptions be any different. - Adds a new `LayoutStyle::ANSWER` to `OmniboxMatchCellView` to style answer matches differently than other matches. - Replaces `kMargin` with `kRowHeight`. Before, the row height was derived by adding `kMargin` * 2 to the image heights. Using `kRowHeight` directly seems less error-prone and easier to reuse without duplicating the computation. - Updates the match selection background corner radius from 40 to 20. 40 was incorrect, but it didn't matter since row height was 40 so the radii were capped to 20 anyways. But since answers have higher row height, the distinction now matters. - Add support for multiline `OmniboxTextView`. Also, cache its size. The base class `View` already has a size cache mechanism, but we can't use that since our items change size as the user types or resizes their window. So added a custom cache for the last available size & computed size; so when the available size changes, we can ignore the cached computed size. - Grouped history embedding answers below other suggestions, except IPH. They're expected to be slow and visually loud, so ranking them above other suggestions would be disruptive. - Hid switch-to-tab button on history embedding answers. - Added new feature param `kAnswersInOmniboxScoped` to guard this. - Using a hardcoded mock answer for now so this CL can focus on just view changes. A followup CL will plug in the answer from the service. Bug: 364303536
Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/c0be837dd32c9c92ec22d6b3d43ec414d0c0bc2c OTR to [oO]tr in java code. Bug: 372670589 Change-Id: I6d5aaa3b5b8af401e09c1990e12bfc889e93815c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924233
Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/aecab74413e302b929bc8d6f6274e5ec02c34e2e Clean up irrelevant AutocompleteMatch fields Change-Id: If11fa90715a6d0a9047e79f96b3bb32b67db0ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5935117
This reverts commit 67a142b.
In cr132, SidePanelCoordinator::OnEntryWillDeregister() is removed. We relied on it to deregister observed entry from SidebarContainerView. Instead, we'll use OnEntryWillHide() callback. It'll be called when side panel is closed. At that time, we could remove observing it safely, and will start to observe again if that entry is still live in tab's registry.
This arg passing to make the semantics clearer, and avoid hidden copies. Chromium change: https://chromium.googlesource.com/chromium/src/+/9085ad7f8069691579c17d5f2046ac4d61f9010d commit 9085ad7f8069691579c17d5f2046ac4d61f9010d Author: Sorin Jianu <[email protected]> Date: Wed Oct 16 21:57:32 2024 +0000 update_client,updater,cus: take optional types by value https://abseil.io/tips/163 Change-Id: Iad5543266f6135a18c4e7f4fe3a3c5060183b0d8
The return type of `NoSideEffectsToMaybeString` has been changed in this migration. Chromium change: https://chromium.googlesource.com/v8/v8/+/a244268ac8ead1cf2ff145f17914d6d83aa6a00c commit a244268ac8ead1cf2ff145f17914d6d83aa6a00c Author: Nikolaos Papaspyrou <[email protected]> Date: Tue May 7 10:34:23 2024 +0200 [handles] Migrate handles in error message generation to direct This CL migrates some string and error message handles, most of them passed as parameters to error message generation methods, to direct. (This is only relevant for builds with v8_enable_direct_handle=true.) Bug: b/42203211
cdesouza-chromium
force-pushed
the
canary
branch
from
6e61d9b
to
3f58821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: