Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Follow up to #36277] Wrong title is shown on server selection screen: shown Location instead of Server region #41593

Closed
3 of 6 tasks
hffvld opened this issue Oct 11, 2024 · 1 comment · Fixed by brave/brave-core#25995
Closed
3 of 6 tasks

[Follow up to #36277] Wrong title is shown on server selection screen: shown Location instead of Server region #41593

hffvld opened this issue Oct 11, 2024 · 1 comment · Fixed by brave/brave-core#25995
Assignees
@deeppandya
Labels
bug feature/vpn OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Milestone
1.72.x - Beta

Comments

@hffvld
Copy link
Contributor

hffvld commented Oct 11, 2024

Description

Follow-up to #36277.

Steps to reproduce

  1. Launch Brave
  2. Enable VPN
  3. Open Hamburger menu
  4. Tap country to open server selection screen > Observe

Actual result

The wrong title is shown on the server selection screen: shown Location instead of Server region.

1 2
1 2

Expected result

According to Figma design, the title must say Server region.

1 2
1 2

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.71.112
Chromium: 130.0.6723.44 (Official Build) (64-bit)

Device

  • Brand/Model: ANY
  • Android version: ANY

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc @deeppandya
@hffvld hffvld added bug feature/vpn OS/Android Fixes related to Android browser functionality QA/Yes labels Oct 11, 2024
@hffvld hffvld mentioned this issue Oct 12, 2024
Closed
@mattmcalister mattmcalister added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude labels Oct 14, 2024
@deeppandya deeppandya mentioned this issue Oct 15, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 15, 2024
This was referenced Oct 15, 2024
Merged
Closed
@kjozwiak
Copy link
Member

The above requires 1.72.83 or higher for 1.72.x verification 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
bug feature/vpn OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.72.x - Beta
Development

Successfully merging a pull request may close this issue.

Update titles for server selection page brave/brave-core
5 participants
@mattmcalister @kjozwiak @deeppandya @brave-builds @hffvld