Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Update UX with advanced server selection #36277

Closed
deeppandya opened this issue Feb 21, 2024 · 5 comments · Fixed by brave/brave-core#25089
Closed

[Android] Update UX with advanced server selection #36277

deeppandya opened this issue Feb 21, 2024 · 5 comments · Fixed by brave/brave-core#25089
Assignees
@deeppandya
Labels
feature/vpn OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.71.x - Release

Comments

@deeppandya
Copy link

This issue is to update VPN server selection page with more details provided on https://connect-api.guardianapp.com/api/v1.3/servers/all-server-regions/city-by-country

We need help with the design.
@deeppandya deeppandya added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality feature/vpn labels Feb 21, 2024
@deeppandya deeppandya self-assigned this Feb 21, 2024
@bsclifton
Copy link
Member

bsclifton commented Feb 21, 2024 •
edited
Loading

This is one we'll want to do on Desktop and iOS also

cc: @soner-yuksel who has looked at this a bit on iOS (w/ Guardian Connect). More info here on our company Slack:
https://bravesoftware.slack.com/archives/C02ML9R5P1R/p1708427779862459 (no issue created, AFAIK)

cc: @mattmcalister for prioritization - we'd also need designs too 😄

@mattmcalister
Copy link

@aguscruiz more background here https://bravesoftware.slack.com/archives/C02ML9R5P1R/p1707389618292439

@mattmcalister mattmcalister added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Feb 26, 2024
@soner-yuksel soner-yuksel mentioned this issue Feb 27, 2024
Closed
@aguscruiz
Copy link

Design is ready here
https://www.figma.com/file/J4LKBMftiWhqromRWfUQLG/VPN-design?type=design&node-id=21%3A17633&mode=design&t=WazHkvOttDsQlMoG-1

@aguscruiz aguscruiz removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Apr 3, 2024
@mattmcalister mattmcalister mentioned this issue Apr 9, 2024
Closed
@deeppandya deeppandya added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 10, 2024
This was referenced May 9, 2024
Closed
Closed
@bsclifton
Copy link
Member

Desktop #38186
iOS #36409

@bsclifton bsclifton added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jun 4, 2024
@mattmcalister mattmcalister added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 28, 2024
@deeppandya deeppandya mentioned this issue Aug 21, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Sep 6, 2024
@brave-builds brave-builds mentioned this issue Sep 6, 2024
Closed
7 tasks
@deeppandya deeppandya mentioned this issue Sep 17, 2024
Closed
@kjozwiak kjozwiak mentioned this issue Oct 10, 2024
Closed
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 11, 2024
This was referenced Oct 11, 2024
Closed
Closed
Closed
Closed
Closed
@hffvld
Copy link
Contributor

hffvld commented Oct 12, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 AP41.240823.009 release-keys
Brave build: 1.71.112
Chromium: 130.0.6723.44 (Official Build) (64-bit)

Filed follow-up issue #41591, #41592, #41593, #41594 and #41595

ACTUAL RESULTS:

1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 12, 2024
@hffvld hffvld mentioned this issue Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/vpn OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.71.x - Release
Development

Successfully merging a pull request may close this issue.

Advanced server selection ux brave/brave-core
6 participants
@mattmcalister @bsclifton @deeppandya @aguscruiz @brave-builds @hffvld