Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New model: Aqara CL-L02D #2986

Merged
merged 24 commits into from
Jan 28, 2025
Merged

New model: Aqara CL-L02D #2986

merged 24 commits into from
Jan 28, 2025

Conversation

dagobert
Copy link
Collaborator

@dagobert dagobert commented Jan 20, 2025

Device information

https://www.aqara-shop.co.uk/product/aqara-ceiling-light-t1m/

Home Assistant Device information

grafik

Checklist

  • I have created a single PR per device. When you have multiple submissions please create separate PR's.
  • For lights - I have only included the gzipped files (*.gz), not the raw CSV files.
  • For lights - I have provided a CSV file per supported color mode. Look that up in Developer Tools -> States
  • Fix identification problem for sub-profile first
  • Main model.json needs testing before merge

Additional info

Measured with Docker and Shelly PM Mini Gen3.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
pre-commit-ci bot and others added 4 commits January 20, 2025 16:08
for more information, see https://pre-commit.ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

github-actions bot commented Jan 20, 2025

Thank you for submitting light measurements!
Here are some visualizations for the CSV files.

Image
Image

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@dagobert
Copy link
Collaborator Author

RGB plots:

color_temp

hs

White plot:

color_temp

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bramstroker
Copy link
Owner

@dagobert Is this still draft or ready for review?

@dagobert
Copy link
Collaborator Author

@dagobert Is this still draft or ready for review?

Still a draft. I have redone the measurements including standby last night. I will commit them tmr.

Also, I wanted to wait for the "more detail" being released to test configuring the lamp with it.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Redone measurements with more stable dummy load.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Redone measurements with more stable dummy load.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added standyby power measure over 300 seconds with dummy load.
@dagobert
Copy link
Collaborator Author

I am using the newest .4 version and the my testing is done.

But I encountered now a new problem. The discovery now states entity name and not the device name any more. Hence, when I add the powercalc sensor it is named (entity_id) sensor.0x54ef441000b75814_rgb_rgb_light_energy with a double "rgb". This is due to the fact that I had to add

  "sensor_config": {
    "power_sensor_naming": "{} RGB Light Power",
    "energy_sensor_naming": "{} RGB Light Energy"
  }

to prevent the rgb light and the white light overwriting/usinf the same entity_id because, as we alked about, my discovered devices always only carried the device name not the entity name/id. Is it safe to remove "RGB" now for all possibilities of discovery names?

@bramstroker
Copy link
Owner

I am using the newest .4 version and the my testing is done.

But I encountered now a new problem. The discovery now states entity name and not the device name any more. Hence, when I add the powercalc sensor it is named (entity_id) sensor.0x54ef441000b75814_rgb_rgb_light_energy with a double "rgb". This is due to the fact that I had to add

  "sensor_config": {
    "power_sensor_naming": "{} RGB Light Power",
    "energy_sensor_naming": "{} RGB Light Energy"
  }

to prevent the rgb light and the white light overwriting/usinf the same entity_id because, as we alked about, my discovered devices always only carried the device name not the entity name/id. Is it safe to remove "RGB" now for all possibilities of discovery names?

The base/source entity name will be build correctly now, so there is no need for custom naming here anymore.
So this whole naming configuration can be removed from the concerning profiles imho.

@dagobert
Copy link
Collaborator Author

OK.
Now another issue: The standby power is used for both lights leading to the double amount. of standby energy usage.

@bramstroker
Copy link
Owner

No easy solution for that currently. As both entities / profiles are setup separately and don't have correlation to eachother.

Users which have this light are highly likely to setup profiles for both the lights, so I would suggest to set both profiles to half the amount of standby_power.

@dagobert
Copy link
Collaborator Author

No easy solution for that currently. As both entities / profiles are setup separately and don't have correlation to eachother.

Users which have this light are highly likely to setup profiles for both the lights, so I would suggest to set both profiles to half the amount of standby_power.

Thats what I thought. I will do that and add it to the remarks.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added comment, corrected standby power because both light use the standby power. Added comments and remarks.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
removed unnecessary entry.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
removed unnecessary entry.
@dagobert dagobert marked this pull request as ready for review January 27, 2025 19:11
dagobert and others added 2 commits January 28, 2025 10:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Bram Gerritsen <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bramstroker
Copy link
Owner

Thanks @dagobert

@bramstroker bramstroker merged commit 2dd748d into master Jan 28, 2025
13 checks passed
@bramstroker bramstroker deleted the dagobert-aqara-cl_l02d branch February 10, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants