-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More info for choosing the correct subprofile #2993
More info for choosing the correct subprofile #2993
Conversation
If you agree with the PR I will change the other translations. |
@dagobert Yes looks fine, great contribution. I would have implemented something similar. What is up with the 2 PNG's? profile_library/mueller-licht/404005/color_temp.png. |
This reverts commit 394b0b0.
for more information, see https://pre-commit.ci
I have no idea where they are coming from. Sorry for the mess. I have done a revert of the png commit. I think the PR is now ready for you to commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use entity_id
instead of entityid
to be consistent with how it's named everywhere
Co-authored-by: Bram Gerritsen <[email protected]>
Co-authored-by: Bram Gerritsen <[email protected]>
Co-authored-by: Bram Gerritsen <[email protected]>
This PR contains changes to help the user to decide for a subprofile.
When having eg. a light device which exposes multiple light switches such as RGB and white, the model created needs to have sub-profiles for each one. Since it is not feasable to match the sub-profiles hard coded to the corresponding light entity the uiser needs to decide at configuration time.
When such a light is discovered by powercalc for every light entity there is a seperate item in the integration page. This item has no information that identifies it to which light entity it belongs. all of them are named the same.
When starting the configuration within flow there is still no information which entity the flow belongs to.
This PR introduces an addition to the description in the sub-profile step: It adds the entity ID of the discovery source.
This PR is related to #2978, #2986