Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More info for choosing the correct subprofile #2993

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

dagobert
Copy link
Collaborator

@dagobert dagobert commented Jan 22, 2025

This PR contains changes to help the user to decide for a subprofile.

When having eg. a light device which exposes multiple light switches such as RGB and white, the model created needs to have sub-profiles for each one. Since it is not feasable to match the sub-profiles hard coded to the corresponding light entity the uiser needs to decide at configuration time.

When such a light is discovered by powercalc for every light entity there is a seperate item in the integration page. This item has no information that identifies it to which light entity it belongs. all of them are named the same.
When starting the configuration within flow there is still no information which entity the flow belongs to.

This PR introduces an addition to the description in the sub-profile step: It adds the entity ID of the discovery source.

This PR is related to #2978, #2986

@dagobert
Copy link
Collaborator Author

If you agree with the PR I will change the other translations.

@bramstroker
Copy link
Owner

@dagobert Yes looks fine, great contribution. I would have implemented something similar.
No need to modify the other languages, they can be translated with crowdin later on.

What is up with the 2 PNG's? profile_library/mueller-licht/404005/color_temp.png.
You commited them yesterday when you started this branch I see.
Could you please remove these?

@dagobert
Copy link
Collaborator Author

@dagobert Yes looks fine, great contribution. I would have implemented something similar. No need to modify the other languages, they can be translated with crowdin later on.

What is up with the 2 PNG's? profile_library/mueller-licht/404005/color_temp.png. You commited them yesterday when you started this branch I see. Could you please remove these?

I have no idea where they are coming from. Sorry for the mess. I have done a revert of the png commit. I think the PR is now ready for you to commit.

@bramstroker bramstroker marked this pull request as ready for review January 23, 2025 14:29
Copy link
Owner

@bramstroker bramstroker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use entity_id instead of entityid to be consistent with how it's named everywhere

@bramstroker bramstroker merged commit c493c44 into bramstroker:master Jan 23, 2025
11 checks passed
@dagobert dagobert deleted the dagobert-more-info-subprofile branch January 24, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants