Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for different lock modes #88

Merged
merged 17 commits into from
Nov 20, 2023
Merged

Support for different lock modes #88

merged 17 commits into from
Nov 20, 2023

Conversation

rkrage
Copy link
Contributor

@rkrage rkrage commented Sep 8, 2023 •
edited
Loading

Addresses #39

@rkrage rkrage changed the title [WIP] Support for different lock modes Support for different lock modes Sep 8, 2023
rkrage
rkrage commented Sep 8, 2023
View reviewed changes
spec/lock_mode_spec.rb Outdated Show resolved Hide resolved
@rkrage rkrage marked this pull request as ready for review September 8, 2023 19:17
@rkrage rkrage force-pushed the safely-acquire-lock-fix branch from 7144675 to bd2c1e9 Compare September 13, 2023 15:56
@rkrage rkrage force-pushed the lock-modes branch 7 times, most recently from 3ba2b5f to 78c6031 Compare September 14, 2023 17:25
@rkrage rkrage force-pushed the safely-acquire-lock-fix branch from c8d2ace to d124b93 Compare September 14, 2023 18:46
@rkrage rkrage force-pushed the safely-acquire-lock-fix branch from 3d164e2 to f644f45 Compare September 15, 2023 20:15
Base automatically changed from safely-acquire-lock-fix to master September 15, 2023 20:41
@rkrage rkrage force-pushed the lock-modes branch 2 times, most recently from 3270aa8 to cd6caf9 Compare September 19, 2023 20:41
rkrage
rkrage commented Sep 21, 2023
View reviewed changes
lib/pg_ha_migrations/lock_mode.rb
share_row_exclusive
exclusive
access_exclusive
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock conflicts pulled from this table: https://www.postgresql.org/docs/current/explicit-locking.html#TABLE-LOCK-COMPATIBILITY

jcoleman
jcoleman reviewed Sep 22, 2023
View reviewed changes
lib/pg_ha_migrations/lock_mode.rb Outdated Show resolved Hide resolved
lib/pg_ha_migrations/lock_mode.rb Outdated Show resolved Hide resolved
lib/pg_ha_migrations/lock_mode.rb Outdated Show resolved Hide resolved
lib/pg_ha_migrations/relation.rb Outdated Show resolved Hide resolved
lib/pg_ha_migrations/relation.rb Outdated Show resolved Hide resolved
lib/pg_ha_migrations/relation.rb Outdated Show resolved Hide resolved
lib/pg_ha_migrations/safe_statements.rb Outdated Show resolved Hide resolved
lib/pg_ha_migrations/safe_statements.rb Outdated Show resolved Hide resolved
@rkrage rkrage changed the base branch from master to pin-partman-version November 17, 2023 17:35
Base automatically changed from pin-partman-version to master November 17, 2023 18:19
jcoleman
jcoleman approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@jcoleman jcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash for merging.

@rkrage rkrage merged commit c4b0d4a into master Nov 20, 2023
108 checks passed
@rkrage rkrage deleted the lock-modes branch November 20, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoleman jcoleman jcoleman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrage @jcoleman